Skip to content

Commit

Permalink
Allow doc value search on unindexed boolean and date fields (#11650)
Browse files Browse the repository at this point in the history
* Making fields searchable

Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>

* Adding tests for boolean fields

Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>

* Added tests for date fields

Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>

* Updating termsQuery logic

Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>

* Spotless

Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>

* Updating terms test

Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>

* Spotless

Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>

* Ensure that the points are intersecting for doc_values

Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>

* Spotless

Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>

* Adding missing javadocs

Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>

* Adding more tests for indexedValueForSearch

Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>

* Adding MatchAllDocsQuery to asserts

Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>

* Fix changelog

Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>

* Simplify loop criteria + remove IndexOrDocValuesQuery

Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>

* Add some comments

Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>

* Fix indendation

Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>

* Fixing boolean field tests

Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>

* Revert to correct logic for termsQuery

Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>

* Update terms logic to be more succinct

Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>

* Fix terms test

Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>

* Adding tests for boolean range query + fix range query to use term query inside

Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>

* Checking if upper and lower terms are valid

Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>

* Checking if upper and lower terms are valid

Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>

* Fixing changelog

Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>

---------

Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
(cherry picked from commit dc77c46)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
  • Loading branch information
github-actions[bot] committed May 2, 2024
1 parent 2d69e44 commit b23425b
Show file tree
Hide file tree
Showing 8 changed files with 573 additions and 28 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
- Refactoring globMatch using simpleMatchWithNormalizedStrings from Regex ([#13104](https://github.com/opensearch-project/OpenSearch/pull/13104))
- [BWC and API enforcement] Reconsider the breaking changes check policy to detect breaking changes against released versions ([#13292](https://github.com/opensearch-project/OpenSearch/pull/13292))
- Switch to macos-13 runner for precommit and assemble github actions due to macos-latest is now arm64 ([#13412](https://github.com/opensearch-project/OpenSearch/pull/13412))
- Add ability for Boolean and date field queries to run when only doc_values are enabled ([#11650](https://github.com/opensearch-project/OpenSearch/pull/11650))
- [Revert] Prevent unnecessary fetch sub phase processor initialization during fetch phase execution ([#12503](https://github.com/opensearch-project/OpenSearch/pull/12503))
- Refactor implementations of query phase searcher, allow QueryCollectorContext to have zero collectors ([#13481](https://github.com/opensearch-project/OpenSearch/pull/13481))

Expand Down

0 comments on commit b23425b

Please sign in to comment.