Create counter atomically

Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>
opensearch-project · Mar 13, 2024 · dc1f4f3 · dc1f4f3
1 parent b52cd83
commit dc1f4f3
Showing 1 changed file with 3 additions and 7 deletions.
diff --git a/server/src/main/java/org/opensearch/action/search/SearchQueryCounters.java b/server/src/main/java/org/opensearch/action/search/SearchQueryCounters.java
@@ -55,20 +55,16 @@ public SearchQueryCounters(MetricsRegistry metricsRegistry) {
     public void incrementCounter(QueryBuilder queryBuilder, int level) {
         String uniqueQueryCounterName = queryBuilder.getName();
 
-        if (!nameToQueryTypeCounters.contains(uniqueQueryCounterName)) {
-            createQueryCounter(uniqueQueryCounterName);
-        }
-
-        Counter counter = nameToQueryTypeCounters.getOrDefault(uniqueQueryCounterName, otherQueryCounter);
+        Counter counter = nameToQueryTypeCounters.computeIfAbsent(uniqueQueryCounterName, k -> createQueryCounter(k));
         counter.add(1, Tags.create().addTag(LEVEL_TAG, level));
     }
 
-    private void createQueryCounter(String counterName) {
+    private Counter createQueryCounter(String counterName) {
         Counter counter = metricsRegistry.createCounter(
             "search.query.type." + counterName + ".count",
             "Counter for the number of top level and nested " + counterName + " search queries",
             UNIT
         );
-        nameToQueryTypeCounters.put(counterName, counter);
+        return counter;
     }
 }