Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Missing toString() method in many requests classes #12144

Closed
guillaume-alvarez opened this issue Feb 2, 2024 · 0 comments · Fixed by #12163
Closed

[BUG] Missing toString() method in many requests classes #12144

guillaume-alvarez opened this issue Feb 2, 2024 · 0 comments · Fixed by #12163
Labels
bug Something isn't working Clients Clients within the Core repository such as High level Rest client and low level client

Comments

@guillaume-alvarez
Copy link
Contributor

Describe the bug

Whereas SearchRequest has a toString() method, making debugging much easier, it is not present in all other requests.

For instance it is missing in

  • MultiSearchRequest
  • CreateIndexRequest
  • MultiGetRequest

Related component

Clients

To Reproduce

  1. Create a MultiSearchRequest object
  2. Try to log it
  3. See something like org.opensearch.action.search.MultiSearchRequest@3eb87ae4

Expected behavior

  1. Create a MultiSearchRequest object
  2. Try to log it
  3. See something like {requests=[SearchRequest{...},...]}

Additional Details

Plugins
N/A

Screenshots
N/A

Host/Environment (please complete the following information):

  • any Java client

Additional context
I will try to provide a fix in PR.

@guillaume-alvarez guillaume-alvarez added bug Something isn't working untriaged labels Feb 2, 2024
@github-actions github-actions bot added the Clients Clients within the Core repository such as High level Rest client and low level client label Feb 2, 2024
kotwanikunal pushed a commit that referenced this issue Feb 12, 2024
…Request classes. (#12163)

fix #12144

Signed-off-by: Guillaume Alvarez <7364145+guillaume-alvarez@users.noreply.github.com>
andrross pushed a commit that referenced this issue Feb 14, 2024
…Request classes. (#12314)

fix #12144

Signed-off-by: Guillaume Alvarez <7364145+guillaume-alvarez@users.noreply.github.com>
peteralfonsi pushed a commit to peteralfonsi/OpenSearch that referenced this issue Mar 1, 2024
…Request classes. (opensearch-project#12163)

fix opensearch-project#12144

Signed-off-by: Guillaume Alvarez <7364145+guillaume-alvarez@users.noreply.github.com>
rayshrey pushed a commit to rayshrey/OpenSearch that referenced this issue Mar 18, 2024
…Request classes. (opensearch-project#12163)

fix opensearch-project#12144

Signed-off-by: Guillaume Alvarez <7364145+guillaume-alvarez@users.noreply.github.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this issue Apr 25, 2024
…Request classes. (opensearch-project#12163)

fix opensearch-project#12144

Signed-off-by: Guillaume Alvarez <7364145+guillaume-alvarez@users.noreply.github.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Clients Clients within the Core repository such as High level Rest client and low level client
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants