Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Fix thirdPartyAudit gradle task for test/frameworks for OpenSearch. #420

Closed
adnapibar opened this issue Mar 19, 2021 · 4 comments
Closed
Labels
bug Something isn't working distributed framework >FORK Related to the fork process Rename Renaming to OpenSearch

Comments

@adnapibar
Copy link
Contributor

Describe the bug
Currently the thirdPartyAudit task is failing for the test:framework module after renaming to OpenSearch.

ERROR: Scanned 2238 class file(s) for forbidden API invocations (in 3.14s), 3 error(s).
ERROR: Check for forbidden API calls failed, see log.
==end of forbidden APIs==
Missing classes:
  * org.apache.tools.ant.BuildException
  * org.apache.tools.ant.DirectoryScanner
  * org.apache.tools.ant.Task
  * org.apache.tools.ant.types.FileSet
Classes with violations:
  * org.objenesis.instantiator.sun.UnsafeFactoryInstantiator

To Reproduce

From the root directory, run

./gradlew :test:framework:thirdPartyAudit --stacktrace

Expected behavior
Task should pass.

@adnapibar adnapibar added bug Something isn't working >FORK Related to the fork process Rename Renaming to OpenSearch labels Mar 19, 2021
adnapibar added a commit that referenced this issue Mar 19, 2021
…ss. (#421)

Currently the thirdPartyAudit task is failing for the test:framework module after renaming to OpenSearch. We have created an issue and temporarily suppressed the errors to unblock the precommit.

Issue: #420

Signed-off-by: Rabi Panda <adnapibar@gmail.com>
@adnapibar
Copy link
Contributor Author

The issue https://github.com/opensearch-project/OpenSearch/blob/rename/opensearch/buildSrc/s[…]n/java/org/opensearch/gradle/precommit/ThirdPartyAuditTask.java and We are still using the securemock and mocksocket from org.elasticsearch

When we have the dependency artifacts ready for org.opensearch group (Issue #114 ), we can revert the thirdPartyAudit changes done in #421

nknize pushed a commit that referenced this issue Mar 20, 2021
…ss. (#421)

Currently the thirdPartyAudit task is failing for the test:framework module after renaming to OpenSearch. We have created an issue and temporarily suppressed the errors to unblock the precommit.

Issue: #420

Signed-off-by: Rabi Panda <adnapibar@gmail.com>
nknize pushed a commit that referenced this issue Mar 22, 2021
…ss. (#421)

Currently the thirdPartyAudit task is failing for the test:framework module after renaming to OpenSearch. We have created an issue and temporarily suppressed the errors to unblock the precommit.

Issue: #420

Signed-off-by: Rabi Panda <adnapibar@gmail.com>
@anasalkouz
Copy link
Member

Hi @adnapibar, I see couple of PL already merged to address the issue, anything else pending? can you close the issue?

@owaiskazi19
Copy link
Member

Looks like ./gradlew :test:framework:thirdPartyAudit is working on main now.

@dblock
Copy link
Member

dblock commented Feb 2, 2022

Closing. Reopen if this isn't finished.

@dblock dblock closed this as completed Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working distributed framework >FORK Related to the fork process Rename Renaming to OpenSearch
Projects
None yet
Development

No branches or pull requests

5 participants