Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Punchlist for ZSTD Compression #9502

Open
10 of 11 tasks
sarthakaggarwal97 opened this issue Aug 23, 2023 · 3 comments
Open
10 of 11 tasks

Punchlist for ZSTD Compression #9502

sarthakaggarwal97 opened this issue Aug 23, 2023 · 3 comments
Labels
enhancement Enhancement or improvement to existing feature or request Plugins

Comments

@sarthakaggarwal97
Copy link
Contributor

sarthakaggarwal97 commented Aug 23, 2023

Is your feature request related to a problem? Please describe.
The issue entails the tasks that are essential to ensure robustness for ZSTD.

Describe the solution you'd like

  • Long running tests to verify for any corruption or memory leaks
  • Reindexing between different compression codecs
  • Create a snapshot, delete an index, restore from snapshot
  • Split/Shrink api since they modify segments to some extent
  • Index Blocks
  • Upgrade from the earliest version supported for version upgrade to 2.x (from os 1.0/es 7.9)
  • Upgrade from the n-1 version
  • Minor version upgrade with zstd and zstd no dict segments
  • Force merge of segments with multiple compression mode into zstd
  • Close an index, update the setting, test the indexing and search flows, snapshots, etc i.e. with multiple compression settings on different segments
  • Move ZStd compression codecs to plugins from core (Optional)

Additional Context
#7908

@sarthakaggarwal97 sarthakaggarwal97 added enhancement Enhancement or improvement to existing feature or request untriaged labels Aug 23, 2023
@dblock
Copy link
Member

dblock commented Aug 24, 2023

#9476 (review)

This is a violation of semver, I propose we close this issue. Some of the checkboxes above do make a ton of sense though as standalone items.

@sarthakaggarwal97
Copy link
Contributor Author

sarthakaggarwal97 commented Aug 24, 2023

@dblock I agree with you. Most of these checkboxes were covered as a part of testing for #7908, let me know if we should create items for any specific checkbox so that we don't lose them. Thank you!

@dblock
Copy link
Member

dblock commented Aug 24, 2023

@dblock I agree with you. Most of these checkboxes were covered as a part of testing for #7908, let me know if we should create items for any specific checkbox so that we don't lose them. Thank you!

Yes, good idea. Up to you if you want to create the remaining ones as standalone features/issues and reference them back to here or rename this issue as something like "punchlist for zstd" :) I would keep the controversial ones like "move to plugin" here for now because they assume we move zstd back to being behind a feature flag/completely optional.

@sarthakaggarwal97 sarthakaggarwal97 changed the title ZSTD compression codecs out of experimental feature flag Punchlist for ZSTD Aug 24, 2023
@sarthakaggarwal97 sarthakaggarwal97 changed the title Punchlist for ZSTD Punchlist for ZSTD Compression Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement or improvement to existing feature or request Plugins
Projects
None yet
Development

No branches or pull requests

4 participants