Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving zstd out of sandbox #7908

Merged

Conversation

sarthakaggarwal97
Copy link
Contributor

@sarthakaggarwal97 sarthakaggarwal97 commented Jun 4, 2023

Description

This PR entails the changes related to moving zstd codec from sandbox to core. The users will be able to set two new codecs zstd and zstd_no_dict upon creating an index.

Related Issues

Resolves #7805

Tested Scenarios

  • Reindexing between different compression codecs
  • Create a snapshot, delete an index, restore from snapshot
  • Split/Shrink api since they modify segments to some extent
  • Index Blocks
  • Upgrade from the earliest version supported for version upgrade to 2.7 (from os 1.0/es 7.9)
  • Upgrade from the n-1 version
  • Minor version upgrade with zstd and zstd no dict segments
  • Force merge of segments with multiple compression mode into zstd
  • Close an index, update the setting, test the indexing and search flows, snapshots, etc i.e. with multiple compression settings on different segments

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 4, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Jun 4, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Jun 5, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Jun 5, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Jun 5, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Jun 5, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Jun 5, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Jun 5, 2023

Gradle Check (Jenkins) Run Completed with:

@sarthakaggarwal97
Copy link
Contributor Author

Flaky Tests: #5176, #7750

@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2023

Gradle Check (Jenkins) Run Completed with:

Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.snapshots.RestoreSnapshotIT.testRestoreRemoteStoreIndicesWithRemoteTranslog
      1 org.opensearch.remotestore.SegmentReplicationUsingRemoteStoreIT.testNodeDropWithOngoingReplication

Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
Copy link
Contributor

@backslasht backslasht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Thanks @sarthakaggarwal97.

@dblock / @reta - What do you folks think?

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      3 org.opensearch.remotestore.RemoteStoreRefreshListenerIT.testRemoteRefreshRetryOnFailure
      1 org.opensearch.remotestore.SegmentReplicationUsingRemoteStoreIT.testNodeDropWithOngoingReplication

Signed-off-by: Daniel (dB.) Doubrovkine <dblock@amazon.com>
Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, let's merge on green.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.snapshots.RestoreSnapshotIT.testRestoreInSameRemoteStoreEnabledIndex
      1 org.opensearch.remotestore.SegmentReplicationUsingRemoteStoreIT.testNodeDropWithOngoingReplication

@dblock
Copy link
Member

dblock commented Jun 28, 2023

@reta you good with this? hit merge

@reta reta merged commit 976048d into opensearch-project:main Jun 29, 2023
9 checks passed
@reta reta added backport 2.x Backport to 2.x branch v2.9.0 'Issues and PRs related to version v2.9.0' labels Jun 29, 2023
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-7908-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 976048d5d630b7adc53f54f2b27558d3a38b1f65
# Push it to GitHub
git push --set-upstream origin backport/backport-7908-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-7908-to-2.x.

@reta
Copy link
Collaborator

reta commented Jun 29, 2023

@sarthakaggarwal97 needs manual backport to 2.x, would you be able to do it? thank you

@sarthakaggarwal97
Copy link
Contributor Author

thanks folks for the reviews!

sarthakaggarwal97 added a commit to sarthakaggarwal97/OpenSearch that referenced this pull request Jun 29, 2023
* Adding zstd module to source

Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>

* Removing zstd module from sandbox

Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>

* Added tests and refactoring

Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>

* Fixing gradle issues

Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>

* flaky test

Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>

* fixing precommit failure

Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>

* Incorporate review comments and fixed precommit failures

Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>

* Incorporating review comments

Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>

* Incorporating review comments

Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>

* Adding Integ tests

Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>

* Incorporating review comments

Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>

---------

Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
Signed-off-by: Daniel (dB.) Doubrovkine <dblock@amazon.com>
Co-authored-by: Daniel (dB.) Doubrovkine <dblock@amazon.com>
(cherry picked from commit 976048d)
baba-devv pushed a commit to baba-devv/OpenSearch that referenced this pull request Jul 29, 2023
* Adding zstd module to source

Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>

* Removing zstd module from sandbox

Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>

* Added tests and refactoring

Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>

* Fixing gradle issues

Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>

* flaky test

Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>

* fixing precommit failure

Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>

* Incorporate review comments and fixed precommit failures

Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>

* Incorporating review comments

Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>

* Incorporating review comments

Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>

* Adding Integ tests

Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>

* Incorporating review comments

Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>

---------

Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
Signed-off-by: Daniel (dB.) Doubrovkine <dblock@amazon.com>
Co-authored-by: Daniel (dB.) Doubrovkine <dblock@amazon.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
* Adding zstd module to source

Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>

* Removing zstd module from sandbox

Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>

* Added tests and refactoring

Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>

* Fixing gradle issues

Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>

* flaky test

Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>

* fixing precommit failure

Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>

* Incorporate review comments and fixed precommit failures

Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>

* Incorporating review comments

Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>

* Incorporating review comments

Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>

* Adding Integ tests

Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>

* Incorporating review comments

Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>

---------

Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
Signed-off-by: Daniel (dB.) Doubrovkine <dblock@amazon.com>
Co-authored-by: Daniel (dB.) Doubrovkine <dblock@amazon.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch v2.9.0 'Issues and PRs related to version v2.9.0'
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Moving zstd and zstd_no_dict compression codecs out of experimental
7 participants