-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix shard failure on flush during upload failures for remote indexes #10513
Conversation
Gradle Check (Jenkins) Run Completed with:
|
Compatibility status:Checks if related components are compatible with change 1ebe969 Incompatible componentsIncompatible components: [https://github.com/opensearch-project/neural-search.git] Skipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git] |
Gradle Check (Jenkins) Run Completed with:
|
server/src/main/java/org/opensearch/index/translog/transfer/TranslogUploadFailedException.java
Show resolved
Hide resolved
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Ashish Singh <ssashish@amazon.com>
|
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #10513 +/- ##
============================================
- Coverage 71.30% 71.12% -0.18%
+ Complexity 58435 58317 -118
============================================
Files 4844 4845 +1
Lines 275284 275290 +6
Branches 40083 40083
============================================
- Hits 196290 195806 -484
- Misses 62605 63047 +442
- Partials 16389 16437 +48
|
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Ashish Singh <ssashish@amazon.com>
flaky test - #10542 |
Gradle Check (Jenkins) Run Completed with:
|
…pensearch-project#10513) Signed-off-by: Ashish Singh <ssashish@amazon.com>
…pensearch-project#10513) Signed-off-by: Ashish Singh <ssashish@amazon.com>
…pensearch-project#10513) Signed-off-by: Ashish Singh <ssashish@amazon.com> Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>
…pensearch-project#10513) Signed-off-by: Ashish Singh <ssashish@amazon.com>
Signed-off-by: Ashish Singh <ssashish@amazon.com>
Signed-off-by: Ashish Singh <ssashish@amazon.com>
…pensearch-project#10513) Signed-off-by: Ashish Singh <ssashish@amazon.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Description
If a flush happens while the remote uploads for translog (or ckp or the metadata file) are failing due to whatsoever reasons (be it transient), it was leading to shard failure. With this PR, we are not failing the engine if the exception thrown during flush is TranslogUploadFailedException.
Related Issues
Resolves #10512
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.