Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes ByteArrayIndexInput::validatePos and adds UT #10551

Merged

Conversation

parasjain1
Copy link
Contributor

@parasjain1 parasjain1 commented Oct 11, 2023

Description

Fixes ByteArrayIndexInput::validatePos and adds UT

Related Issues

Resolves #10481

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Oct 11, 2023

Compatibility status:

Checks if related components are compatible with change 407ddff

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/sql.git]

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Copy link
Contributor

❌ Gradle check result for 78ade58: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@andrross
Copy link
Member

@parasjain1 Can you fix the spotless error here?

@opensearch-trigger-bot
Copy link
Contributor

This PR is stalled because it has been open for 30 days with no activity.

@opensearch-trigger-bot opensearch-trigger-bot bot added the stalled Issues that have stalled label Dec 20, 2023
@ticheng-aws
Copy link
Contributor

@parasjain1 Can you fix the spotless error here?

Hi @parasjain1, do we have any updates? You can run ./gradlew :server:spotlessApply to fix the spotless error. Thank you.

@opensearch-trigger-bot opensearch-trigger-bot bot removed the stalled Issues that have stalled label Jan 7, 2024
@opensearch-trigger-bot
Copy link
Contributor

This PR is stalled because it has been open for 30 days with no activity.

@opensearch-trigger-bot opensearch-trigger-bot bot added the stalled Issues that have stalled label Feb 11, 2024
Paras Jain and others added 2 commits February 13, 2024 14:56
Signed-off-by: Paras Jain <parasjaz@amazon.com>
Signed-off-by: Andrew Ross <andrross@amazon.com>
Copy link
Contributor

❕ Gradle check result for 407ddff: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.remotestore.RemoteIndexPrimaryRelocationIT.testPrimaryRelocationWhileIndexing
      1 org.opensearch.cluster.routing.allocation.decider.DiskThresholdDeciderIT.testIndexCreateBlockIsRemovedWhenAnyNodesNotExceedHighWatermarkWithAutoReleaseEnabled

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Feb 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bff8eb7) 71.49% compared to head (407ddff) 71.45%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #10551      +/-   ##
============================================
- Coverage     71.49%   71.45%   -0.05%     
+ Complexity    59859    59846      -13     
============================================
  Files          4959     4959              
  Lines        281129   281129              
  Branches      40857    40857              
============================================
- Hits         201003   200882     -121     
- Misses        63425    63609     +184     
+ Partials      16701    16638      -63     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kotwanikunal kotwanikunal merged commit bb0b4b0 into opensearch-project:main Feb 15, 2024
33 of 34 checks passed
@kotwanikunal kotwanikunal added the backport 2.x Backport to 2.x branch label Feb 15, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 15, 2024
* Prevent read beyond slice boundary in ByteArrayIndexInput

Signed-off-by: Paras Jain <parasjaz@amazon.com>

* Fix spotless errors

Signed-off-by: Andrew Ross <andrross@amazon.com>

---------

Signed-off-by: Paras Jain <parasjaz@amazon.com>
Signed-off-by: Andrew Ross <andrross@amazon.com>
Co-authored-by: Paras Jain <parasjaz@amazon.com>
Co-authored-by: Andrew Ross <andrross@amazon.com>
(cherry picked from commit bb0b4b0)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
peteralfonsi pushed a commit to peteralfonsi/OpenSearch that referenced this pull request Mar 1, 2024
…t#10551)

* Prevent read beyond slice boundary in ByteArrayIndexInput

Signed-off-by: Paras Jain <parasjaz@amazon.com>

* Fix spotless errors

Signed-off-by: Andrew Ross <andrross@amazon.com>

---------

Signed-off-by: Paras Jain <parasjaz@amazon.com>
Signed-off-by: Andrew Ross <andrross@amazon.com>
Co-authored-by: Paras Jain <parasjaz@amazon.com>
Co-authored-by: Andrew Ross <andrross@amazon.com>
rayshrey pushed a commit to rayshrey/OpenSearch that referenced this pull request Mar 18, 2024
…t#10551)

* Prevent read beyond slice boundary in ByteArrayIndexInput

Signed-off-by: Paras Jain <parasjaz@amazon.com>

* Fix spotless errors

Signed-off-by: Andrew Ross <andrross@amazon.com>

---------

Signed-off-by: Paras Jain <parasjaz@amazon.com>
Signed-off-by: Andrew Ross <andrross@amazon.com>
Co-authored-by: Paras Jain <parasjaz@amazon.com>
Co-authored-by: Andrew Ross <andrross@amazon.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
…t#10551)

* Prevent read beyond slice boundary in ByteArrayIndexInput

Signed-off-by: Paras Jain <parasjaz@amazon.com>

* Fix spotless errors

Signed-off-by: Andrew Ross <andrross@amazon.com>

---------

Signed-off-by: Paras Jain <parasjaz@amazon.com>
Signed-off-by: Andrew Ross <andrross@amazon.com>
Co-authored-by: Paras Jain <parasjaz@amazon.com>
Co-authored-by: Andrew Ross <andrross@amazon.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
bowenlan-amzn pushed a commit to bowenlan-amzn/OpenSearch that referenced this pull request May 24, 2024
…t#10551)

* Prevent read beyond slice boundary in ByteArrayIndexInput

Signed-off-by: Paras Jain <parasjaz@amazon.com>

* Fix spotless errors

Signed-off-by: Andrew Ross <andrross@amazon.com>

---------

Signed-off-by: Paras Jain <parasjaz@amazon.com>
Signed-off-by: Andrew Ross <andrross@amazon.com>
Co-authored-by: Paras Jain <parasjaz@amazon.com>
Co-authored-by: Andrew Ross <andrross@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch bug Something isn't working stalled Issues that have stalled Storage Issues and PRs relating to data and metadata storage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] ByteArrayIndexInput::readBytes can read beyond valid boundary of the slice
7 participants