Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the means to extract the contextual properties from HttpChannel, TcpChannel and TrasportChannel without excessive typecasting #10562

Merged
merged 2 commits into from
Oct 11, 2023

Address code review comments

1c184e2
Select commit
Loading
Failed to load commit list.
Merged

Add the means to extract the contextual properties from HttpChannel, TcpChannel and TrasportChannel without excessive typecasting #10562

Address code review comments
1c184e2
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch failed Oct 11, 2023 in 1s

0.00% of diff hit (target 71.16%)

View this Pull Request on Codecov

0.00% of diff hit (target 71.16%)

Annotations

Check warning on line 105 in modules/transport-netty4/src/main/java/org/opensearch/http/netty4/Netty4HttpChannel.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

modules/transport-netty4/src/main/java/org/opensearch/http/netty4/Netty4HttpChannel.java#L105 

Added line #L105 was not covered by tests

Check warning on line 108 in modules/transport-netty4/src/main/java/org/opensearch/http/netty4/Netty4HttpChannel.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

modules/transport-netty4/src/main/java/org/opensearch/http/netty4/Netty4HttpChannel.java#L108 

Added line #L108 was not covered by tests

Check warning on line 112 in modules/transport-netty4/src/main/java/org/opensearch/http/netty4/Netty4HttpChannel.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

modules/transport-netty4/src/main/java/org/opensearch/http/netty4/Netty4HttpChannel.java#L112 

Added line #L112 was not covered by tests

Check warning on line 115 in modules/transport-netty4/src/main/java/org/opensearch/http/netty4/Netty4HttpChannel.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

modules/transport-netty4/src/main/java/org/opensearch/http/netty4/Netty4HttpChannel.java#L115 

Added line #L115 was not covered by tests

Check warning on line 171 in modules/transport-netty4/src/main/java/org/opensearch/transport/netty4/Netty4TcpChannel.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

modules/transport-netty4/src/main/java/org/opensearch/transport/netty4/Netty4TcpChannel.java#L171 

Added line #L171 was not covered by tests

Check warning on line 174 in modules/transport-netty4/src/main/java/org/opensearch/transport/netty4/Netty4TcpChannel.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

modules/transport-netty4/src/main/java/org/opensearch/transport/netty4/Netty4TcpChannel.java#L174 

Added line #L174 was not covered by tests

Check warning on line 177 in modules/transport-netty4/src/main/java/org/opensearch/transport/netty4/Netty4TcpChannel.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

modules/transport-netty4/src/main/java/org/opensearch/transport/netty4/Netty4TcpChannel.java#L177 

Added line #L177 was not covered by tests

Check warning on line 87 in server/src/main/java/org/opensearch/http/HttpChannel.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

server/src/main/java/org/opensearch/http/HttpChannel.java#L87 

Added line #L87 was not covered by tests

Check warning on line 99 in server/src/main/java/org/opensearch/telemetry/tracing/channels/TraceableHttpChannel.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

server/src/main/java/org/opensearch/telemetry/tracing/channels/TraceableHttpChannel.java#L99 

Added line #L99 was not covered by tests

Check warning on line 116 in server/src/main/java/org/opensearch/telemetry/tracing/channels/TraceableTcpTransportChannel.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

server/src/main/java/org/opensearch/telemetry/tracing/channels/TraceableTcpTransportChannel.java#L116 

Added line #L116 was not covered by tests

Check warning on line 96 in server/src/main/java/org/opensearch/transport/TaskTransportChannel.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

server/src/main/java/org/opensearch/transport/TaskTransportChannel.java#L96 

Added line #L96 was not covered by tests

Check warning on line 111 in server/src/main/java/org/opensearch/transport/TcpChannel.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

server/src/main/java/org/opensearch/transport/TcpChannel.java#L111 

Added line #L111 was not covered by tests

Check warning on line 136 in server/src/main/java/org/opensearch/transport/TcpTransportChannel.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

server/src/main/java/org/opensearch/transport/TcpTransportChannel.java#L136 

Added line #L136 was not covered by tests

Check warning on line 94 in server/src/main/java/org/opensearch/transport/TransportChannel.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

server/src/main/java/org/opensearch/transport/TransportChannel.java#L94 

Added line #L94 was not covered by tests
View more details on Codecov