Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Remove] Remaining Joda and Joda Dependency #10949

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[Remove] Remaining Joda and Joda Dependency #10949

wants to merge 4 commits into from

Conversation

nknize
Copy link
Collaborator

@nknize nknize commented Oct 26, 2023 •
edited by reta
Loading

Joda was deprecated in Elasticsearch 7.x. OpenSearch should have proactively removed in 2.0. This PR removes the remaining Joda dependency and formatting logic in favor of java 8 time. It adds a new LegacyFormatName class, however, to ensure camelCase DateFormat is supported for indexes created in ElasticSearch 7.x (and carried through OpenSearch 1.x).

relates #5910
relates #8110

Closes #3995

@nknize nknize added pending backport Identifies an issue or PR that still needs to be backported backwards-compatibility >breaking Identifies a breaking change. v3.0.0 Issues and PRs related to version 3.0.0 skip-changelog labels Oct 26, 2023
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 5599d3e: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@nknize
[Remove] Remaining Joda and Joda Dependency
71de5ba 
Joda was deprecated in Elasticsearch 7.x. OpenSearch should have
proactively removed in 2.0. This commit removes the remaining Joda
dependency and formatting logic in favor of java 8 time. It adds a
new LegacyFormat class, however, to ensure camelCase DateFormat is
supported for indexes created in ElasticSearch 7.x (and carried through
OpenSearch 1.x).

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
@nknize
fix failing tests
3739a5e 
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
@nknize
update changelog, fix tests
2e9e1c6 
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
@nknize
add original forPattern method to preserve interface.
07b930e 
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for 07b930e: SUCCESS

reta
reta reviewed Nov 13, 2023
View reviewed changes
server/src/main/java/org/opensearch/index/mapper/ParametrizedFieldMapper.java
@@ -325,7 +325,8 @@ private void init(FieldMapper toInit) {
setValue(initializer.apply(toInit));
}

private void parse(String field, ParserContext context, Object in) {
// public for testing only
public void parse(String field, ParserContext context, Object in) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This visibility change seems to be not needed, what test needs it?

@github-actions github-actions bot added dependencies Pull requests that update a dependency file enhancement Enhancement or improvement to existing feature or request labels Nov 22, 2023
@opensearch-trigger-bot
Copy link
Contributor

This PR is stalled because it has been open for 30 days with no activity.

@opensearch-trigger-bot opensearch-trigger-bot bot added stalled Issues that have stalled and removed stalled Issues that have stalled labels Jan 3, 2024
@ticheng-aws
Copy link
Contributor

Hi @nknize, the PR is stalled. Is this being worked upon?

@nknize
Copy link
Collaborator Author

nknize commented Jan 9, 2024

These PRs have been ready for review / approval for quite a while. Either no one has been comfortable approving them or everyone is busy with their own tasks. I'll rebase when there's a need (approval or change) otherwise I'll be rebasing in perpetuity.

@msfroh
Copy link
Collaborator

msfroh commented Jan 9, 2024

These PRs have been ready for review / approval for quite a while. Either no one has been comfortable approving them or everyone is busy with their own tasks. I'll rebase when there's a need (approval or change) otherwise I'll be rebasing in perpetuity.

To be fair, @reta reviewed it on November 13th, asked a question and got no reply.

@nknize nknize added feedback needed Issue or PR needs feedback stalled Issues that have stalled labels Jan 14, 2024
@opensearch-trigger-bot opensearch-trigger-bot bot removed the stalled Issues that have stalled label Jan 17, 2024
@opensearch-trigger-bot
Copy link
Contributor

This PR is stalled because it has been open for 30 days with no activity.

@opensearch-trigger-bot opensearch-trigger-bot bot added stalled Issues that have stalled and removed stalled Issues that have stalled labels Feb 22, 2024
@opensearch-trigger-bot
Copy link
Contributor

This PR is stalled because it has been open for 30 days with no activity.

@opensearch-trigger-bot opensearch-trigger-bot bot added stalled Issues that have stalled and removed stalled Issues that have stalled labels Mar 31, 2024
@opensearch-trigger-bot
Copy link
Contributor

This PR is stalled because it has been open for 30 days with no activity.

@opensearch-trigger-bot opensearch-trigger-bot bot added the stalled Issues that have stalled label May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reta reta reta left review comments

@abbashus abbashus Awaiting requested review from abbashus

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@kartg kartg Awaiting requested review from kartg

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@peternied peternied Awaiting requested review from peternied

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@ryanbogan ryanbogan Awaiting requested review from ryanbogan

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@setiah setiah Awaiting requested review from setiah

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

@adnapibar adnapibar Awaiting requested review from adnapibar

@tlfeng tlfeng Awaiting requested review from tlfeng

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
backwards-compatibility >breaking Identifies a breaking change. dependencies Pull requests that update a dependency file enhancement Enhancement or improvement to existing feature or request feedback needed Issue or PR needs feedback pending backport Identifies an issue or PR that still needs to be backported stalled Issues that have stalled v3.0.0 Issues and PRs related to version 3.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove Joda and Joda Wrappers
5 participants
@nknize @reta @peternied @ticheng-aws @msfroh