-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improving the performance of date histogram aggregation (without any sub-aggregation) #11083
Merged
Merged
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
f9b0d5f
Adding filter based optimization logic to date histogram aggregation
jainankitk 05ca07b
Reading the field name for aggregation correctly
jainankitk e7f8a8c
Adding the limit on number of buckets for filter aggregation
jainankitk d8487f8
Applying the optimizations for match all query as well
jainankitk d4ada64
Handling the unwrapped match all query
jainankitk f12ed77
Adding logic for recursively unwrapping the query
jainankitk d9bbd1f
Restructuring the code for making it more reusable and unit testable
jainankitk 5f25240
Adding javadocs for fixing build failure
jainankitk 88b7cca
Fixing minor bugs in refactoring
jainankitk 0c27add
Adding logic for optimizing auto date histogram
jainankitk c19f785
Fixing bugs and passing unit tests for date histogram
jainankitk e900f8e
Temporarily reverting auto date histogram changes
jainankitk e2dbf88
Fixing spotless check bugs
jainankitk 06d6c42
Adding back auto date histogram and passing all unit tests
jainankitk 62542c7
Fixing the integration tests for reduced collector work
jainankitk e09f2eb
Fixing the integration test regression
jainankitk 95627c8
Addressing code review comments
jainankitk ba9e605
Merge branch 'main' into date-histo
jainankitk 7265177
Merge remote-tracking branch 'origin/main' into date-histo
jainankitk b401a12
Merge remote-tracking branch 'origin/main' into date-histo
jainankitk 15f9543
Fixing hardbound, missing and script test cases
jainankitk 4c3b917
Removing collect_count validation to prevent backward compatibility t…
jainankitk b535934
Finally fixing hardbounds test case
jainankitk be20dde
Merge remote-tracking branch 'origin/main' into date-histo
jainankitk e225781
Refactoring code for reusability
jainankitk File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jainankitk What is the reason to change the visibility level? this is internal API and should stay as such
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The offset value is needed for creating the correct range buckets in
FilterRewriteHelper::createFilterForAggregations
. Some of the calendar intervals like month/quarter/year can have varying number of days, which is stored in extraLocalOffsetLookup. Do you see any harm in making just getter public? If yes, do you have a workaround in mind?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jainankitk please take a loot at #11392
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good one, thanks!