Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] Enabling sort optimization back for half_float with custom comparator… #11197

Merged
merged 1 commit into from
Nov 14, 2023
Merged

[Backport 2.x] Enabling sort optimization back for half_float with custom comparator… #11197

merged 1 commit into from
Nov 14, 2023

Conversation

gashutos
Copy link
Contributor

Backport of #11024

@gashutos @reta @backslasht
Enabling sort optimization back for half_float with custom comparators (
1c697fd 
opensearch-project#11024)

* Enabling sort optimizatin back for half_float with custom comparators

Signed-off-by: Chaitanya Gohel <gashutos@amazon.com>

* Fixing tests

Signed-off-by: Chaitanya Gohel <gashutos@amazon.com>

* Adding test for Indecx sort half_float

Signed-off-by: Chaitanya Gohel <gashutos@amazon.com>

* Making indexFieldData provate in FloatValuesComparatorSource

Signed-off-by: Chaitanya Gohel <gashutos@amazon.com>

* Update server/src/main/java/org/opensearch/index/search/comparators/HalfFloatComparator.java

Co-authored-by: Andriy Redko <drreta@gmail.com>
Signed-off-by: Chaitanya Gohel <104654647+gashutos@users.noreply.github.com>

* Adding missing value instead null

Signed-off-by: Chaitanya Gohel <gashutos@amazon.com>

* Adding more tests for desc order sort

Signed-off-by: Chaitanya Gohel <gashutos@amazon.com>

* Update rest-api-spec/src/main/resources/rest-api-spec/test/search/90_search_after.yml

Co-authored-by: Prabhakar Sithanandam <prabhakar.s87@gmail.com>
Signed-off-by: Chaitanya Gohel <104654647+gashutos@users.noreply.github.com>

* Adding tests in case missing values are competitive

Signed-off-by: Chaitanya Gohel <gashutos@amazon.com>

* chanheing newly added test supported version 3.0.0

Signed-off-by: Chaitanya Gohel <gashutos@amazon.com>

* Assing missing float tests

Signed-off-by: Chaitanya Gohel <gashutos@amazon.com>

* Remove missing value change to be part of another PR

Signed-off-by: Chaitanya Gohel <gashutos@amazon.com>

---------

Signed-off-by: Chaitanya Gohel <gashutos@amazon.com>
Signed-off-by: Chaitanya Gohel <104654647+gashutos@users.noreply.github.com>
Co-authored-by: Andriy Redko <drreta@gmail.com>
Co-authored-by: Prabhakar Sithanandam <prabhakar.s87@gmail.com>
@gashutos
Copy link
Contributor Author

@reta

@github-actions GitHub Actions
Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change 1c697fd

Incompatible components

Incompatible components: [https://github.com/opensearch-project/performance-analyzer.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/alerting.git]

@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for 1c697fd: SUCCESS

@reta reta added backport PRs or issues specific to backporting features or enhancments v2.12.0 Issues and PRs related to version 2.12.0 labels Nov 14, 2023
@reta reta merged commit c2b5587 into opensearch-project:2.x Nov 14, 2023
70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reta reta reta approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@setiah setiah Awaiting requested review from setiah

@kartg kartg Awaiting requested review from kartg

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@peternied peternied Awaiting requested review from peternied

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@ryanbogan ryanbogan Awaiting requested review from ryanbogan

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89 dreamer-89 is a code owner

@tlfeng tlfeng Awaiting requested review from tlfeng tlfeng is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

Assignees
No one assigned
Labels
backport PRs or issues specific to backporting features or enhancments v2.12.0 Issues and PRs related to version 2.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gashutos @reta