Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] Improve boolean parsing performance #11351

Merged
merged 1 commit into from
Nov 30, 2023
Merged

[Backport 2.x] Improve boolean parsing performance #11351

merged 1 commit into from
Nov 30, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 26a1439 from #11308.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 27, 2023 •
edited

Compatibility status:

Checks if related components are compatible with change 4a0d90f

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/performance-analyzer.git]

@github-actions GitHub Actions
Copy link
Contributor

❕ Gradle check result for f4243e5: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.remotestore.RemoteStoreStatsIT.testDownloadStatsCorrectnessSinglePrimarySingleReplica

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@codecov Codecov
Copy link

codecov bot commented Nov 27, 2023 •
edited

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (ca8b54c) 71.10% compared to head (4a0d90f) 71.05%.

Files Patch % Lines
.../src/main/java/org/opensearch/common/Booleans.java 76.19% 0 Missing and 5 partials ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##                2.x   #11351      +/-   ##
============================================
- Coverage     71.10%   71.05%   -0.05%     
+ Complexity    59204    59110      -94     
============================================
  Files          4869     4869              
  Lines        278732   278708      -24     
  Branches      40848    40833      -15     
============================================
- Hits         198196   198047     -149     
- Misses        63786    63925     +139     
+ Partials      16750    16736      -14

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions @andrross
Improve boolean parsing performance (#11308)
4a0d90f 
Signed-off-by: Ketan Verma <ketan9495@gmail.com>
Signed-off-by: Ketan Verma <9292653+ketanv3@users.noreply.github.com>
(cherry picked from commit 26a1439)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@andrross andrross force-pushed the backport/backport-11308-to-2.x branch from f4243e5 to 4a0d90f Compare November 30, 2023 17:57
@andrross
Copy link
Member

I pushed a rebase of the changelog to fix conflicts...no other changes

@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for 4a0d90f: SUCCESS

@kotwanikunal kotwanikunal merged commit 2212625 into 2.x Nov 30, 2023
16 checks passed
@github-actions github-actions bot deleted the backport/backport-11308-to-2.x branch November 30, 2023 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrross andrross andrross approved these changes

@kotwanikunal kotwanikunal kotwanikunal approved these changes

@reta reta Awaiting requested review from reta reta is a code owner

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@setiah setiah Awaiting requested review from setiah

@kartg kartg Awaiting requested review from kartg

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@peternied peternied Awaiting requested review from peternied

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@ryanbogan ryanbogan Awaiting requested review from ryanbogan

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89 dreamer-89 is a code owner

@tlfeng tlfeng Awaiting requested review from tlfeng tlfeng is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andrross @kotwanikunal