-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 2.x] Delegating CachingWeightWrapper#count to internal weight object (#10543) #11389
[Backport 2.x] Delegating CachingWeightWrapper#count to internal weight object (#10543) #11389
Conversation
…search-project#10543) * adding delegation from CachingWeightWrapper#count to internal weight object and its unit test Signed-off-by: Niyati Aggarwal <niyatiagg4641@gmail.com> * fixing checkstyle violations Signed-off-by: Niyati Aggarwal <niyatiagg4641@gmail.com> * fixing existing tests Signed-off-by: Niyati Aggarwal <niyatiagg4641@gmail.com> * adding test for delegating count to internal weight object Signed-off-by: Niyati Aggarwal <niyatiagg4641@gmail.com> * Fixing failing unit tests Signed-off-by: Niyati Aggarwal <niyatiagg4641@gmail.com> * Adding the change log Signed-off-by: Niyati Aggarwal <niyatiagg4641@gmail.com> --------- Signed-off-by: Niyati Aggarwal <niyatiagg4641@gmail.com> (cherry picked from commit 72e63f2) Signed-off-by: Ankit Jain <akjain@amazon.com>
0253a12
to
63c6265
Compare
Compatibility status:Checks if related components are compatible with change 63c6265 Incompatible componentsSkipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/alerting.git] |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #11389 +/- ##
============================================
- Coverage 71.11% 71.11% -0.01%
+ Complexity 59181 59171 -10
============================================
Files 4869 4869
Lines 278725 278727 +2
Branches 40847 40847
============================================
- Hits 198224 198215 -9
+ Misses 63816 63698 -118
- Partials 16685 16814 +129 ☔ View full report in Codecov by Sentry. |
❌ Gradle check result for 63c6265: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Unrelated failures due to flaky test |
❌ Gradle check result for 63c6265: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 63c6265: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 63c6265: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
Signed-off-by: Niyati Aggarwal niyatiagg4641@gmail.com
Signed-off-by: Niyati Aggarwal niyatiagg4641@gmail.com
Signed-off-by: Niyati Aggarwal niyatiagg4641@gmail.com
Signed-off-by: Niyati Aggarwal niyatiagg4641@gmail.com
Signed-off-by: Niyati Aggarwal niyatiagg4641@gmail.com
Signed-off-by: Niyati Aggarwal niyatiagg4641@gmail.com
Signed-off-by: Niyati Aggarwal niyatiagg4641@gmail.com
(cherry picked from commit 72e63f2)
Description
Backport of #10543
Related Issues
Resolves #10060
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.