Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] Delegating CachingWeightWrapper#count to internal weight object (#10543) #11389

Merged
merged 1 commit into from
Nov 30, 2023
Merged

[Backport 2.x] Delegating CachingWeightWrapper#count to internal weight object (#10543) #11389

merged 1 commit into from
Nov 30, 2023

Conversation

jainankitk
Copy link
Contributor

  • adding delegation from CachingWeightWrapper#count to internal weight object and its unit test

Signed-off-by: Niyati Aggarwal niyatiagg4641@gmail.com

  • fixing checkstyle violations

Signed-off-by: Niyati Aggarwal niyatiagg4641@gmail.com

  • fixing existing tests

Signed-off-by: Niyati Aggarwal niyatiagg4641@gmail.com

  • adding test for delegating count to internal weight object

Signed-off-by: Niyati Aggarwal niyatiagg4641@gmail.com

  • Fixing failing unit tests

Signed-off-by: Niyati Aggarwal niyatiagg4641@gmail.com

  • Adding the change log

Signed-off-by: Niyati Aggarwal niyatiagg4641@gmail.com

Signed-off-by: Niyati Aggarwal niyatiagg4641@gmail.com
(cherry picked from commit 72e63f2)

Description

Backport of #10543

Related Issues

Resolves #10060

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions bot added bug Something isn't working good first issue Good for newcomers Search Search query, autocomplete ...etc labels Nov 29, 2023
@jainankitk jainankitk removed bug Something isn't working good first issue Good for newcomers labels Nov 29, 2023
@github-actions github-actions bot added bug Something isn't working good first issue Good for newcomers labels Nov 29, 2023
@jainankitk jainankitk mentioned this pull request Nov 29, 2023
Merged
7 tasks
@niyatiagg @jainankitk
Delegating CachingWeightWrapper#count to internal weight object (open…
63c6265 
…search-project#10543)

* adding delegation from CachingWeightWrapper#count to internal weight object and its unit test

Signed-off-by: Niyati Aggarwal <niyatiagg4641@gmail.com>

* fixing checkstyle violations

Signed-off-by: Niyati Aggarwal <niyatiagg4641@gmail.com>

* fixing existing tests

Signed-off-by: Niyati Aggarwal <niyatiagg4641@gmail.com>

* adding test for delegating count to internal weight object

Signed-off-by: Niyati Aggarwal <niyatiagg4641@gmail.com>

* Fixing failing unit tests

Signed-off-by: Niyati Aggarwal <niyatiagg4641@gmail.com>

* Adding the change log

Signed-off-by: Niyati Aggarwal <niyatiagg4641@gmail.com>

---------

Signed-off-by: Niyati Aggarwal <niyatiagg4641@gmail.com>
(cherry picked from commit 72e63f2)
Signed-off-by: Ankit Jain <akjain@amazon.com>
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 29, 2023 •
edited
Loading

Compatibility status:

Checks if related components are compatible with change 63c6265

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/alerting.git]

@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for 0253a12: SUCCESS

@codecov Codecov
Copy link

codecov bot commented Nov 29, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b2770de) 71.11% compared to head (63c6265) 71.11%.
Report is 9 commits behind head on 2.x.

Additional details and impacted files 
@@             Coverage Diff              @@
##                2.x   #11389      +/-   ##
============================================
- Coverage     71.11%   71.11%   -0.01%     
+ Complexity    59181    59171      -10     
============================================
  Files          4869     4869              
  Lines        278725   278727       +2     
  Branches      40847    40847              
============================================
- Hits         198224   198215       -9     
+ Misses        63816    63698     -118     
- Partials      16685    16814     +129

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 63c6265: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@jainankitk
Copy link
Contributor Author

Unrelated failures due to flaky test

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 63c6265: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@andrross andrross changed the title Delegating CachingWeightWrapper#count to internal weight object (#10543) [Backport 2.x] Delegating CachingWeightWrapper#count to internal weight object (#10543) Nov 29, 2023
@andrross
Copy link
Member

❌ Gradle check result for 63c6265: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

#10704

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 63c6265: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 63c6265: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@andrross
Copy link
Member

❌ Gradle check result for 63c6265: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

#11413

@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for 63c6265: SUCCESS

@msfroh msfroh merged commit 5cdf020 into opensearch-project:2.x Nov 30, 2023
18 checks passed
@jainankitk jainankitk deleted the backport/backport-10543-to-2.x branch December 1, 2023 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msfroh msfroh msfroh approved these changes

@reta reta Awaiting requested review from reta reta is a code owner

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@setiah setiah Awaiting requested review from setiah

@kartg kartg Awaiting requested review from kartg

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@peternied peternied Awaiting requested review from peternied

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@ryanbogan ryanbogan Awaiting requested review from ryanbogan

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89

@tlfeng tlfeng Awaiting requested review from tlfeng

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers Search Search query, autocomplete ...etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jainankitk @andrross @msfroh @niyatiagg