Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Personalize code ownership areas #11600

Merged
merged 2 commits into from
Dec 14, 2023

Conversation

peternied
Copy link
Member

@peternied peternied commented Dec 12, 2023

Description

Personalize code ownership areas

Also includes peternied's personalization

Related Issues

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Also include peternied's personalizations

Signed-off-by: Peter Nied <petern@amazon.com>
Signed-off-by: Peter Nied <petern@amazon.com>
@github-actions github-actions bot added the RFC Issues requesting major changes label Dec 12, 2023
@peternied peternied changed the title Personalize of code ownership areas Personalize code ownership areas Dec 12, 2023
@peternied peternied self-assigned this Dec 12, 2023
Copy link
Contributor

❌ Gradle check result for 989fc32: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@peternied
Copy link
Member Author

@msfroh @reta @dblock @andrross feel free to update this PR or comment with areas you'd like to own and I'll include you in this first rollout.

Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change 989fc32

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/performance-analyzer.git]

Copy link
Contributor

❕ Gradle check result for 989fc32: UNSTABLE

  • TEST FAILURES:
      2 org.opensearch.smoketest.SmokeTestMultiNodeClientYamlTestSuiteIT.test {yaml=pit/10_basic/Delete all}
      1 org.opensearch.remotestore.RemoteIndexPrimaryRelocationIT.testPrimaryRelocationWhileIndexing

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Dec 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a8da66c) 71.34% compared to head (989fc32) 71.33%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #11600      +/-   ##
============================================
- Coverage     71.34%   71.33%   -0.01%     
+ Complexity    59204    59190      -14     
============================================
  Files          4906     4906              
  Lines        278178   278178              
  Branches      40421    40421              
============================================
- Hits         198456   198434      -22     
  Misses        63269    63269              
- Partials      16453    16475      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peternied peternied merged commit 9f42963 into opensearch-project:main Dec 14, 2023
68 of 122 checks passed
@peternied peternied deleted the petern-codeownership branch December 14, 2023 22:02
@peternied peternied added the backport 2.x Backport to 2.x branch label Dec 14, 2023
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-11600-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 9f4296343cc0b0089c8b5e6912910e3a8339a017
# Push it to GitHub
git push --set-upstream origin backport/backport-11600-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-11600-to-2.x.

peternied added a commit to peternied/OpenSearch-1 that referenced this pull request Dec 14, 2023
peternied added a commit that referenced this pull request Dec 14, 2023
Signed-off-by: Peter Nied <petern@amazon.com>
rayshrey pushed a commit to rayshrey/OpenSearch that referenced this pull request Mar 18, 2024
Signed-off-by: Peter Nied <petern@amazon.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
Signed-off-by: Peter Nied <petern@amazon.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch bug Something isn't working RFC Issues requesting major changes skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC] [Bug] New pull request automatically assigns and notifies every maintainer.
2 participants