Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the means to extract the contextual underlying channel from HttpChannel without excessive typecasting #11751

Merged
merged 1 commit into from Jan 4, 2024

Conversation

reta
Copy link
Collaborator

@reta reta commented Jan 4, 2024

Description

Follow up on #10562 since more type casting code has been added into the security plugin.

Related Issues

Relates to opensearch-project/security#3911

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…hannel without excessive typecasting

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Copy link
Contributor

github-actions bot commented Jan 4, 2024

Compatibility status:

Checks if related components are compatible with change 1a6940b

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/performance-analyzer.git]

Copy link
Contributor

github-actions bot commented Jan 4, 2024

❌ Gradle check result for dd95708: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Jan 4, 2024

✅ Gradle check result for 1a6940b: SUCCESS

Copy link

codecov bot commented Jan 4, 2024

Codecov Report

Attention: 167 lines in your changes are missing coverage. Please review.

Comparison is base (36bd674) 71.27% compared to head (1a6940b) 71.36%.
Report is 2 commits behind head on main.

Files Patch % Lines
...org/opensearch/index/mapper/NumberFieldMapper.java 40.26% 68 Missing and 21 partials ⚠️
.../document/SortedUnsignedLongDocValuesSetQuery.java 15.09% 43 Missing and 2 partials ⚠️
.../main/java/org/apache/lucene/util/LongHashSet.java 39.62% 21 Missing and 11 partials ⚠️
.../org/opensearch/http/netty4/Netty4HttpChannel.java 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #11751      +/-   ##
============================================
+ Coverage     71.27%   71.36%   +0.09%     
- Complexity    59176    59273      +97     
============================================
  Files          4909     4911       +2     
  Lines        278429   278656     +227     
  Branches      40460    40525      +65     
============================================
+ Hits         198443   198869     +426     
+ Misses        63528    63268     -260     
- Partials      16458    16519      +61     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peternied peternied merged commit 808ed56 into opensearch-project:main Jan 4, 2024
29 of 30 checks passed
@peternied peternied added the backport 2.x Backport to 2.x branch label Jan 4, 2024
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-11751-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 808ed56bcbc6ed547f64895cd02283df07fb5c48
# Push it to GitHub
git push --set-upstream origin backport/backport-11751-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-11751-to-2.x.

reta added a commit to reta/OpenSearch that referenced this pull request Jan 4, 2024
…hannel without excessive typecasting (opensearch-project#11751)

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
(cherry picked from commit 808ed56)
@reta reta added the v3.0.0 Issues and PRs related to version 3.0.0 label Jan 4, 2024
reta added a commit that referenced this pull request Jan 4, 2024
…hannel without excessive typecasting (#11751) (#11754)

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
(cherry picked from commit 808ed56)
rayshrey pushed a commit to rayshrey/OpenSearch that referenced this pull request Mar 18, 2024
…hannel without excessive typecasting (opensearch-project#11751)

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
…hannel without excessive typecasting (opensearch-project#11751)

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch backport-failed v3.0.0 Issues and PRs related to version 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants