Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TRIAGING.md for triage agenda and processes #11814

Merged
merged 4 commits into from
Jan 16, 2024
Merged

Add TRIAGING.md for triage agenda and processes #11814

merged 4 commits into from
Jan 16, 2024

Conversation

peternied
Copy link
Member

@peternied peternied commented Jan 8, 2024 •
edited

Description

Documents the repository wide triaging processes for OpenSearch

  • Meeting format and agenda
  • Public meeting schedule - Weekly Wed - 10a CT
  • Commonly used labels
  • Triaging outcomes and canned responses

Related Issues

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@peternied
Add TRIAGING.md for triage agenda and processes
cd5152f 
Documents the repository wide triaging processes for OpenSearch
- Meeting format and agenda
- Public meeting schedule - Weekly Wed - 10a CT
- Commonly used labels
- Triaging outcomes and canned responses

Signed-off-by: Peter Nied <petern@amazon.com>
peternied
peternied commented Jan 8, 2024
View reviewed changes
TRIAGING.md Outdated Show resolved Hide resolved
TRIAGING.md Outdated Show resolved Hide resolved
TRIAGING.md Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 8, 2024

❌ Gradle check result for cd5152f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 8, 2024 •
edited

Compatibility status:

Checks if related components are compatible with change 20841f4

Incompatible components

Incompatible components: [https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/k-nn.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/sql.git]

macohen
macohen suggested changes Jan 8, 2024
View reviewed changes
Copy link
Contributor

@macohen macohen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'd like to see the addition to the question about attending the session (line 5)

TRIAGING.md Show resolved Hide resolved
TRIAGING.md Outdated Show resolved Hide resolved
reta
reta reviewed Jan 9, 2024
View reviewed changes
TRIAGING.md Outdated Show resolved Hide resolved
reta
reta reviewed Jan 9, 2024
View reviewed changes
TRIAGING.md Outdated Show resolved Hide resolved
reta
reta reviewed Jan 9, 2024
View reviewed changes
TRIAGING.md Outdated Show resolved Hide resolved
@reta
Copy link
Collaborator

reta commented Jan 9, 2024

Thanks @peternied , love this initiative !

@peternied
Address initial round of feedback
18d513c 
Signed-off-by: Peter Nied <petern@amazon.com>
Signed-off-by: Peter Nied <peternied@hotmail.com>
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 18d513c: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@peternied
Copy editing pass and additional supporting sections
47a2841 
Signed-off-by: Peter Nied <petern@amazon.com>
Signed-off-by: Peter Nied <peternied@hotmail.com>
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 47a2841: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

minalsha
minalsha reviewed Jan 10, 2024
View reviewed changes
Copy link
Contributor

@minalsha minalsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

anasalkouz
anasalkouz reviewed Jan 10, 2024
View reviewed changes
Copy link
Member

@anasalkouz anasalkouz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General feedback. It's not clear to me what is the triage process that the group will follow in the meeting. I think we need clear definition of the triaging process

TRIAGING.md Show resolved Hide resolved
TRIAGING.md Show resolved Hide resolved
@peternied
Copy link
Member Author

@anasalkouz Thanks for taking the time to read and provide feedback.

It's not clear to me what is the triage process that the group will follow in the meeting. I think we need clear definition of the triaging process

I'm not sure if you are asking about the mechanics, or the criteria used for triage. I'll speak to them both, but please let me know if I am mistaken.

Mechanically, the triage facilitator will open the query, open an issue, scan the issue's title and body. There will be a brief discussion to accept or why to reject, criteria could be; is it clear what the issue is, is it clear that it should be fixed, is it clear that this repository to fix it? Labels will be added/removed, then a small blurb will be written with a tag indicating it came from triage and it will be commented on or closed. Then the triage facilitator moves on to the next issue...

For the criteria, the extremes of accept and reject are easy - ✅ Filled in the whole template ❌ Spam. There will be be variance for what gets approved / rejected. Since the issues will have the reason for rejection is included in the issue we can tweak these over time to update the template, document criteria, or update the TRIAGING.md with changes.

@peternied
Merge remote-tracking branch 'origin/main' into triaging.md
20841f4 
Signed-off-by: Peter Nied <peternied@hotmail.com>
@peternied
Copy link
Member Author

Note my previous comment ^ might be a candidate for a follow up PR if there is a strong desire

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 20841f4: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@peternied
Copy link
Member Author

❌ Gradle check result for 20841f4: FAILURE

@github-actions GitHub Actions
Copy link
Contributor

❕ Gradle check result for 20841f4: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.remotestore.RemoteIndexPrimaryRelocationIT.testPrimaryRelocationWhileIndexing

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@peternied
Copy link
Member Author

❕ Gradle check result for 20841f4: UNSTABLE

peternied
peternied commented Jan 11, 2024
View reviewed changes
Copy link
Member Author

@peternied peternied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"

@peternied peternied merged commit 1d8bbd5 into opensearch-project:main Jan 16, 2024
32 of 34 checks passed
@peternied peternied deleted the triaging.md branch January 16, 2024 22:56
peteralfonsi pushed a commit to peteralfonsi/OpenSearch that referenced this pull request Mar 1, 2024
@peternied
Add TRIAGING.md for triage agenda and processes (opensearch-project#1…
abdb915 
…1814)

Signed-off-by: Peter Nied <petern@amazon.com>
Signed-off-by: Peter Nied <peternied@hotmail.com>
rayshrey pushed a commit to rayshrey/OpenSearch that referenced this pull request Mar 18, 2024
@peternied @rayshrey
Add TRIAGING.md for triage agenda and processes (opensearch-project#1…
d0ab603 
…1814)

Signed-off-by: Peter Nied <petern@amazon.com>
Signed-off-by: Peter Nied <peternied@hotmail.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
@peternied @shiv0408
Add TRIAGING.md for triage agenda and processes (opensearch-project#1…
fda6c6d 
…1814)

Signed-off-by: Peter Nied <petern@amazon.com>
Signed-off-by: Peter Nied <peternied@hotmail.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anasalkouz anasalkouz anasalkouz left review comments

@minalsha minalsha minalsha left review comments

@macohen macohen macohen requested changes

@reta reta reta approved these changes

@deshsidd deshsidd deshsidd approved these changes

@abbashus abbashus Awaiting requested review from abbashus

@adnapibar adnapibar Awaiting requested review from adnapibar

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@kartg kartg Awaiting requested review from kartg

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@ryanbogan ryanbogan Awaiting requested review from ryanbogan

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@tlfeng tlfeng Awaiting requested review from tlfeng

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

Assignees
No one assigned
Labels
skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@peternied @reta @macohen @deshsidd @anasalkouz @minalsha