Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Enable must_exist parameter for update aliases API (#11210) #11833

Merged

Conversation

gaobinlong
Copy link
Contributor

@gaobinlong gaobinlong commented Jan 10, 2024

Description

Backport #11210 to 2.x.

Related Issues

#2949

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…t#11210)

* Enable must_exist parameter for update aliases API

Signed-off-by: Gao Binlong <gbinlong@amazon.com>

* modify changelog

Signed-off-by: Gao Binlong <gbinlong@amazon.com>

* Fix test failure

Signed-off-by: Gao Binlong <gbinlong@amazon.com>

* Fix test failure

Signed-off-by: Gao Binlong <gbinlong@amazon.com>

* Remove silently when all aliases are non-existing and must_exist is false

Signed-off-by: Gao Binlong <gbinlong@amazon.com>

* Modify some comments to run gradle check again

Signed-off-by: Gao Binlong <gbinlong@amazon.com>

* Add more yaml test

Signed-off-by: Gao Binlong <gbinlong@amazon.com>

---------

Signed-off-by: Gao Binlong <gbinlong@amazon.com>
(cherry picked from commit a1e4602)
Signed-off-by: Gao Binlong <gbinlong@amazon.com>
Copy link
Contributor

❌ Gradle check result for 46b94a0: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Jan 10, 2024

Compatibility status:

Checks if related components are compatible with change ca113ea

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/performance-analyzer.git]

Copy link
Contributor

✅ Gradle check result for 0f233c7: SUCCESS

Copy link

codecov bot commented Jan 10, 2024

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (166ede7) 71.10% compared to head (ca113ea) 70.91%.

Files Patch % Lines
...n/indices/alias/TransportIndicesAliasesAction.java 16.66% 9 Missing and 1 partial ⚠️
...ion/admin/indices/alias/IndicesAliasesRequest.java 50.00% 1 Missing and 2 partials ⚠️
...a/org/opensearch/cluster/metadata/AliasAction.java 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #11833      +/-   ##
============================================
- Coverage     71.10%   70.91%   -0.19%     
+ Complexity    59359    59239     -120     
============================================
  Files          4889     4889              
  Lines        279808   279821      +13     
  Branches      41028    41034       +6     
============================================
- Hits         198954   198440     -514     
- Misses        64019    64525     +506     
- Partials      16835    16856      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Gao Binlong <gbinlong@amazon.com>
Copy link
Contributor

❕ Gradle check result for ca113ea: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.remotestore.RemoteStoreStatsIT.testDownloadStatsCorrectnessSinglePrimarySingleReplica

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@gaobinlong
Copy link
Contributor Author

There is an issue tracking the flaky test.

@gaobinlong
Copy link
Contributor Author

@reta, please help to review this backport PR, thanks!

@reta reta added the v2.12.0 Issues and PRs related to version 2.12.0 label Jan 10, 2024
@reta reta merged commit acef38e into opensearch-project:2.x Jan 10, 2024
31 of 32 checks passed
@gaobinlong gaobinlong deleted the backport/backport-11210-to-2.x branch June 19, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v2.12.0 Issues and PRs related to version 2.12.0
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

None yet

2 participants