Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport] [2.x] Add advance(int) for numeric values in order to allow point based optimization to kick in (#12089) #12129

Merged
merged 1 commit into from
Feb 2, 2024
Merged

[Backport] [2.x] Add advance(int) for numeric values in order to allow point based optimization to kick in (#12089) #12129

merged 1 commit into from
Feb 2, 2024

Conversation

reta
Copy link
Collaborator

@reta reta commented Feb 1, 2024

Backport of #12089 to 2.x

@reta
Add advance(int) for numeric values in order to allow point based opt…
e81a243 
…imization to kick in (opensearch-project#12089)

* Add advance(int) for numeric values in order to allow point based optimization to kick in

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

* Address code review comments

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

---------

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
(cherry picked from commit 4471a8d)
@reta reta changed the title [Bacjport] [2.x] Add advance(int) for numeric values in order to allow point based optimization to kick in (#12089) [Backport] [2.x] Add advance(int) for numeric values in order to allow point based optimization to kick in (#12089) Feb 1, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 1, 2024

Compatibility status:

Checks if related components are compatible with change e81a243

Incompatible components

Incompatible components: [https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/performance-analyzer-rca.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/alerting.git]

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 1, 2024

✅ Gradle check result for e81a243: SUCCESS

@codecov Codecov
Copy link

codecov bot commented Feb 1, 2024

Codecov Report

Attention: 27 lines in your changes are missing coverage. Please review.

Comparison is base (3b47fa3) 71.13% compared to head (e81a243) 71.03%.

Files Patch % Lines
...java/org/opensearch/index/fielddata/FieldData.java 0.00% 8 Missing ⚠️
...x/fielddata/plain/SortedNumericIndexFieldData.java 0.00% 4 Missing ⚠️
...pensearch/index/fielddata/NumericDoubleValues.java 0.00% 3 Missing ⚠️
...ain/java/org/opensearch/search/MultiValueMode.java 0.00% 2 Missing ⚠️
.../fielddata/SingletonSortedNumericDoubleValues.java 0.00% 1 Missing ⚠️
...ex/fielddata/SortableLongBitsNumericDocValues.java 0.00% 1 Missing ⚠️
...elddata/SortableLongBitsToNumericDoubleValues.java 0.00% 1 Missing ⚠️
...a/SortableLongBitsToSortedNumericDoubleValues.java 0.00% 1 Missing ⚠️
...rch/index/fielddata/SortedNumericDoubleValues.java 0.00% 1 Missing ⚠️
...x/fielddata/UnsignedLongToNumericDoubleValues.java 0.00% 1 Missing ⚠️
... and 4 more
Additional details and impacted files 
@@             Coverage Diff              @@
##                2.x   #12129      +/-   ##
============================================
- Coverage     71.13%   71.03%   -0.11%     
+ Complexity    59468    59442      -26     
============================================
  Files          4894     4894              
  Lines        280277   280304      +27     
  Branches      41115    41115              
============================================
- Hits         199384   199121     -263     
- Misses        64023    64310     +287     
- Partials      16870    16873       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reta reta added the bug Something isn't working label Feb 1, 2024
@reta reta added the backport PRs or issues specific to backporting features or enhancments label Feb 1, 2024
@reta
Copy link
Collaborator Author

reta commented Feb 1, 2024

@andrross @msfroh mind approving this backport folks? thank you

@andrross andrross merged commit 4faa3eb into opensearch-project:2.x Feb 2, 2024
84 of 86 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrross andrross andrross approved these changes

@deshsidd deshsidd deshsidd approved these changes

@abbashus abbashus Awaiting requested review from abbashus

@adnapibar adnapibar Awaiting requested review from adnapibar

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@kartg kartg Awaiting requested review from kartg

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@ryanbogan ryanbogan Awaiting requested review from ryanbogan

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@tlfeng tlfeng Awaiting requested review from tlfeng

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

Assignees
No one assigned
Labels
backport PRs or issues specific to backporting features or enhancments bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@reta @andrross @deshsidd