Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x]Remote reindex: Add support for configurable retry mechanism #12634

Merged
merged 2 commits into from
Mar 14, 2024

Conversation

ankitkala
Copy link
Member

@ankitkala ankitkala commented Mar 13, 2024

2.x Backport PR for #12561

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ankitkala ankitkala changed the title Remote reindex: Add support for configurable retry mechanism [Backport 2.x]Remote reindex: Add support for configurable retry mechanism Mar 13, 2024
Copy link
Contributor

❌ Gradle check result for 3b4e417: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Mar 13, 2024

Compatibility status:

Checks if related components are compatible with change 94185b2

Incompatible components

Incompatible components: [https://github.com/opensearch-project/security-analytics.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/performance-analyzer.git]

Signed-off-by: Ankit Kala <ankikala@amazon.com>
Signed-off-by: Ankit Kala <ankikala@amazon.com>
Copy link
Contributor

❌ Gradle check result for 7a07d28: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❕ Gradle check result for 94185b2: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.search.SearchWeightedRoutingIT.testMultiGetWithNetworkDisruption_FailOpenEnabled

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Mar 14, 2024

Codecov Report

Attention: Patch coverage is 94.73684% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 71.21%. Comparing base (0dd892c) to head (94185b2).
Report is 16 commits behind head on 2.x.

Files Patch % Lines
...ndex/reindex/remote/RemoteScrollableHitSource.java 92.30% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #12634      +/-   ##
============================================
- Coverage     71.28%   71.21%   -0.08%     
+ Complexity    60145    60129      -16     
============================================
  Files          4957     4958       +1     
  Lines        282799   282967     +168     
  Branches      41409    41436      +27     
============================================
- Hits         201591   201504      -87     
- Misses        64189    64408     +219     
- Partials      17019    17055      +36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ankitkala
Copy link
Member Author

ankitkala commented Mar 14, 2024

❕ Gradle check result for 94185b2: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.search.SearchWeightedRoutingIT.testMultiGetWithNetworkDisruption_FailOpenEnabled

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Flaky test: #10755

@shwetathareja shwetathareja merged commit 94fad2c into opensearch-project:2.x Mar 14, 2024
79 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants