Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport to 2.x "Add explicit dependency to validatePom and generatePom tasks" #12909

Merged
merged 2 commits into from
Mar 26, 2024

Conversation

zelinh
Copy link
Member

@zelinh zelinh commented Mar 25, 2024

Description

Backport to 2.x branch for #12807
#12876

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Zelin Hao <zelinhao@amazon.com>
@zelinh zelinh force-pushed the add-dependency-pomvalidate-2x branch from 5e7a074 to 7be643f Compare March 25, 2024 19:58
Copy link
Contributor

❌ Gradle check result for 5e7a074: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Mar 25, 2024

Compatibility status:

Checks if related components are compatible with change 555cd5a

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/sql.git]

Signed-off-by: Zelin Hao <zelinhao@amazon.com>
@zelinh zelinh force-pushed the add-dependency-pomvalidate-2x branch from 4f5a3b0 to 555cd5a Compare March 25, 2024 20:45
Copy link
Contributor

❌ Gradle check result for 7be643f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 4f5a3b0: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 555cd5a: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@zelinh
Copy link
Member Author

zelinh commented Mar 25, 2024

❌ Gradle check result for 555cd5a: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Due to Jenkins restart, this GHA seems to lose connection. The gradle check itself resumed and succeeded.
https://build.ci.opensearch.org/job/gradle-check/35895/

Copy link
Contributor

✅ Gradle check result for 555cd5a: SUCCESS

Copy link

codecov bot commented Mar 25, 2024

Codecov Report

Attention: Patch coverage is 21.42857% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 71.11%. Comparing base (0dd892c) to head (555cd5a).
Report is 85 commits behind head on 2.x.

Files Patch % Lines
...gradle/precommit/PomValidationPrecommitPlugin.java 30.00% 7 Missing ⚠️
.../java/org/opensearch/gradle/pluginzip/Publish.java 0.00% 3 Missing ⚠️
...opensearch/gradle/precommit/PomValidationTask.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #12909      +/-   ##
============================================
- Coverage     71.28%   71.11%   -0.17%     
- Complexity    60145    60346     +201     
============================================
  Files          4957     4985      +28     
  Lines        282799   284407    +1608     
  Branches      41409    41582     +173     
============================================
+ Hits         201591   202267     +676     
- Misses        64189    65056     +867     
- Partials      17019    17084      +65     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reta reta merged commit f45c1d5 into opensearch-project:2.x Mar 26, 2024
28 of 29 checks passed
@zelinh zelinh deleted the add-dependency-pomvalidate-2x branch March 27, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants