Improve error messages for _stats with closed indices
#13012
Conversation
srikanthpadakanti
requested review from
abbashus,
adnapibar,
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
dreamer-89,
gbbafna,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
ryanbogan,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami,
tlfeng and
VachaShah
as code owners
|
❌ Gradle check result for 9ca6e0e: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for f9c68b0: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Compatibility status:Checks if related components are compatible with change 71f5199 Incompatible componentsSkipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/performance-analyzer.git] |
server/src/main/java/org/opensearch/action/support/IndicesOptions.java
Outdated
Show resolved
Hide resolved
|
@srikanthpadakanti thanks for the change, could you please add a test case for it as well? thank you |
|
❌ Gradle check result for 664b51e: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
server/src/main/java/org/opensearch/cluster/metadata/IndexNameExpressionResolver.java
Outdated
Show resolved
Hide resolved
Signed-off-by: srikanth padakanti <srikanth29.9@gmail.com>
|
❌ Gradle check result for f7a1951: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: srikanth padakanti <srikanth29.9@gmail.com>
|
|
|
❌ Gradle check result for 51ed18f: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❕ Gradle check result for c208a44: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
|
@srikanthpadakanti could you please resolve the conflicts? thank you |
Signed-off-by: Srikanth Padakanti <srikanth29.9@gmail.com>
|
@reta Please validate and approve. Thanks. |
|
❌ Gradle check result for 6de3241: null Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
@mch2 @peternied LGTY folks? thank you! |
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-13012-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 98009ed9b83d43377e6b3ffa610db7154ff7d200
# Push it to GitHub
git push --set-upstream origin backport/backport-13012-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.xThen, create a pull request where the |
|
@srikanthpadakanti could you please backport manually to |
|
|
@srikanthpadakanti - Does anything need to change in the documentation, or does it now work according to the documentation? Thanks. |
@hdhalter I thinks the change is very internal - no user visible API changes, thank you. |
Hello @hdhalter No changes needed in documentation. Now the exception message is thrown with clear instructions what needs to be done. |
Description
The expand_wildcards parameter has the following options according to docs:
all and closed options are supposed to expand on closed indices.
When either of these options are provided while the cluster contains a closed index, a bad request is returned:
{
"error": {
"root_cause": [
{
"type": "index_closed_exception",
"reason": "closed",
"index": "test-index",
"index_uuid": "DH_Phg7YTpSG-KZfAPoddQ"
}
],
"type": "index_closed_exception",
"reason": "closed",
"index": "test-index",
"index_uuid": "DH_Phg7YTpSG-KZfAPoddQ"
},
"status": 400
}
The fix addresses the above addressed issue and it expands the closed index with all and closed options.
Related Issues
Resolves #11180
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.