Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement mark() in class FilterStreamInput #13098

Merged
merged 3 commits into from
Apr 9, 2024

Conversation

kkewwei
Copy link
Contributor

@kkewwei kkewwei commented Apr 5, 2024

Signed-off-by: kkewwei kkewwei@163.com

Description

Implement mark() in class FilterStreamInput

Related Issues

Resolves #13096

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

github-actions bot commented Apr 5, 2024

❌ Gradle check result for 1a87940: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Apr 5, 2024

❌ Gradle check result for bea846c: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Apr 5, 2024

❌ Gradle check result for 1d10350: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Apr 5, 2024

❕ Gradle check result for d0ad0d9: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.remotestore.multipart.RemoteStoreMultipartIT.testOverriddenBufferInterval

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.43%. Comparing base (b15cb0c) to head (c8a0961).
Report is 138 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #13098      +/-   ##
============================================
+ Coverage     71.42%   71.43%   +0.01%     
- Complexity    59978    60454     +476     
============================================
  Files          4985     5026      +41     
  Lines        282275   284528    +2253     
  Branches      40946    41215     +269     
============================================
+ Hits         201603   203260    +1657     
- Misses        63999    64449     +450     
- Partials      16673    16819     +146     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reta
Copy link
Collaborator

reta commented Apr 5, 2024

Please add CHANGELOG entry

Copy link
Contributor

github-actions bot commented Apr 5, 2024

❌ Gradle check result for 34f9f36: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Apr 5, 2024

✅ Gradle check result for 967fa37: SUCCESS

Copy link
Contributor

github-actions bot commented Apr 5, 2024

✅ Gradle check result for 612b2fa: SUCCESS

Signed-off-by: kkewwei <kkewwei@163.com>
Signed-off-by: kkewwei <kkewwei@163.com>
Signed-off-by: kkewwei <kkewwei@163.com>
Copy link
Contributor

github-actions bot commented Apr 7, 2024

❌ Gradle check result for 943b988: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Apr 7, 2024

❕ Gradle check result for c8a0961: UNSTABLE

  • TEST FAILURES:
      2 org.opensearch.cluster.coordination.AwarenessAttributeDecommissionIT.testConcurrentDecommissionAction

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@kkewwei
Copy link
Contributor Author

kkewwei commented Apr 7, 2024

❕ Gradle check result for c8a0961: UNSTABLE

  • TEST FAILURES:
      2 org.opensearch.cluster.coordination.AwarenessAttributeDecommissionIT.testConcurrentDecommissionAction

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

testConcurrentDecommissionAction #12197

@reta reta merged commit 8779e52 into opensearch-project:main Apr 9, 2024
46 of 52 checks passed
@reta reta added the backport 2.x Backport to 2.x branch label Apr 9, 2024
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-13098-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 8779e5297a502d4bfc1c0b199813babb7bc62726
# Push it to GitHub
git push --set-upstream origin backport/backport-13098-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-13098-to-2.x.

@reta
Copy link
Collaborator

reta commented Apr 9, 2024

@kkewwei could you please backport to 2.x? thank you

@kkewwei kkewwei deleted the issue-13096 branch April 10, 2024 06:29
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
* implement mark() in class FilterStreamInput

Signed-off-by: kkewwei <kkewwei@163.com>

* implement markSupported() in class FilterStreamInput

Signed-off-by: kkewwei <kkewwei@163.com>

* add CHANGELOG

Signed-off-by: kkewwei <kkewwei@163.com>

---------

Signed-off-by: kkewwei <kkewwei@163.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch backport-failed bug Something isn't working Other
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] implement mark() in class FilterStreamInput
3 participants