Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump joda from 2.12.2 to 2.12.7 #13193

Merged
merged 5 commits into from
Apr 16, 2024
Merged

Bump joda from 2.12.2 to 2.12.7 #13193

merged 5 commits into from
Apr 16, 2024

Conversation

cwperks
Copy link
Member

@cwperks cwperks commented Apr 15, 2024 •
edited by peternied

Description

Bump joda from 2.12.2 to 2.12.7

Related Issues

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@cwperks
Bump joda from 2.12.2 to 2.12.7
d312aaf 
Signed-off-by: Craig Perkins <cwperx@amazon.com>
@cwperks
Add to CHANGELOG
2e8c58b 
Signed-off-by: Craig Perkins <cwperx@amazon.com>
@github-actions GitHub Actions

This comment was marked as resolved.

Sign in to view
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for d312aaf: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 2e8c58b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@owaiskazi19 owaiskazi19 mentioned this pull request Apr 15, 2024
Closed
7 tasks
@owaiskazi19

This comment was marked as resolved.

Sign in to view
@github-actions github-actions bot added >FORK Related to the fork process enhancement Enhancement or improvement to existing feature or request Rename Renaming to OpenSearch v1.1.0 Issues, PRs, related to the 1.1.0 release v2.0.0 Version 2.0.0 labels Apr 15, 2024
@peternied
Merge branch 'main' into bump-joda
d34e2fa 
Signed-off-by: Peter Nied <petern@amazon.com>
@peternied peternied self-assigned this Apr 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for d34e2fa: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

peternied
peternied requested changes Apr 15, 2024
View reviewed changes
Copy link
Member

@peternied peternied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a regression introduced by the dependency change 👎

@cwperks can you look into this failure?

org.opensearch.common.time.DateUtilsTests.testTimezoneIds

java.lang.AssertionError: Antarctica/Vostok
Expected: <25200000>
     but: was <21600000>

@cwperks
Copy link
Member Author

cwperks commented Apr 15, 2024

@peternied I fixed the error by updating the test. There's a list of IGNORE tzs in the test for this exact case. I was able to remove America/Ciudad_Juarez from this list and have it continue to work, but I had to add Antarctica/Vostok to the ignore list.

@cwperks cwperks added the backport 2.x Backport to 2.x branch label Apr 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for 037dbb4: SUCCESS

@reta reta self-requested a review April 16, 2024 00:57
@peternied peternied merged commit 5e72e1d into opensearch-project:main Apr 16, 2024
34 of 35 checks passed
@peternied peternied mentioned this pull request Apr 16, 2024
Closed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 16, 2024
@github-actions @peternied
Bump joda from 2.12.2 to 2.12.7 (#13193)
e6516e2 
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Peter Nied <petern@amazon.com>
Co-authored-by: Peter Nied <petern@amazon.com>
(cherry picked from commit 5e72e1d)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Apr 16, 2024
Merged
@peternied peternied mentioned this pull request Apr 16, 2024
Closed
peternied added a commit that referenced this pull request Apr 16, 2024
@opensearch-trigger-bot @github-actions @peternied
Bump joda from 2.12.2 to 2.12.7 (#13193) (#13222)
f3d30d3 
(cherry picked from commit 5e72e1d)

Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Peter Nied <petern@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Peter Nied <petern@amazon.com>
@BrewTestBot BrewTestBot mentioned this pull request May 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reta reta reta approved these changes

@peternied peternied peternied approved these changes

@abbashus abbashus Awaiting requested review from abbashus

@adnapibar adnapibar Awaiting requested review from adnapibar

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89 dreamer-89 is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@ryanbogan ryanbogan Awaiting requested review from ryanbogan

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@tlfeng tlfeng Awaiting requested review from tlfeng tlfeng is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

Assignees

@peternied peternied

Labels
backport 2.x Backport to 2.x branch enhancement Enhancement or improvement to existing feature or request >FORK Related to the fork process Rename Renaming to OpenSearch v1.1.0 Issues, PRs, related to the 1.1.0 release v2.0.0 Version 2.0.0
Projects
None yet
Milestone
No milestone
4 participants
@cwperks @owaiskazi19 @reta @peternied