Initial commit for index routing table manifest #13255
Conversation
Signed-off-by: Bukhtawar Khan <bukhtawa@amazon.com>
Bukhtawar
requested review from
anasalkouz,
andrross,
CEHENKLE,
dblock,
dbwiddis,
dreamer-89,
gbbafna,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami,
tlfeng and
VachaShah
as code owners
|
❌ Gradle check result for 4afb08b: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Bukhtawar Khan <bukhtawa@amazon.com>
Signed-off-by: Bukhtawar Khan <bukhtawa@amazon.com>
|
❌ Gradle check result for b38752c: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for f6eda99: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Bukhtawar Khan <bukhtawa@amazon.com>
|
❌ Gradle check result for c6ed63f: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
| @@ -319,6 +391,8 @@ public void writeTo(StreamOutput out) throws IOException { | |||
| if (out.getVersion().onOrAfter(Version.V_2_12_0)) { | |||
| out.writeInt(codecVersion); | |||
| out.writeString(globalMetadataFileName); | |||
| } else if (out.getVersion().onOrAfter(Version.V_2_14_0)) { | |||
There was a problem hiding this comment.
We would need to change to if instead of else if so both blocks are executed for versions after 2.14
| private void initialFill() throws IOException { | ||
| BytesReference bytesReference = indexRoutingTableHeader.write(); | ||
| buf = bytesReference.toBytesRef().bytes; | ||
| count = bytesReference.length(); |
There was a problem hiding this comment.
With this the initialization of buf in ctor is not used. Also, the buffer size will not be size from this point onwards but would be count
| leftOverBuf = null; | ||
| } else { | ||
| System.arraycopy(bytesRef.toBytesRef().bytes, 0, buf, count, buf.length - count); | ||
| count += buf.length - count; |
There was a problem hiding this comment.
This essentially becomes count = buf.length, right?
| } else { | ||
| System.arraycopy(bytesRef.toBytesRef().bytes, 0, buf, count, buf.length - count); | ||
| count += buf.length - count; | ||
| leftOverBuf = new byte[bytesRef.length() - count]; |
There was a problem hiding this comment.
This line should be before changing the value of count. Also, it should be:
leftOverBuf = new byte[bytesRef.length() - (buf.length - count)];
| System.arraycopy(bytesRef.toBytesRef().bytes, 0, buf, count, buf.length - count); | ||
| count += buf.length - count; | ||
| leftOverBuf = new byte[bytesRef.length() - count]; | ||
| System.arraycopy(bytesRef.toBytesRef().bytes, buf.length - count + 1, leftOverBuf, 0, bytesRef.length() - count); |
There was a problem hiding this comment.
Need to change values of 2nd and 5th parameters.
| import java.io.InputStream; | ||
| import java.util.Iterator; | ||
|
|
||
| public class IndexRoutingTableInputStream extends InputStream { |
There was a problem hiding this comment.
This is a useful extension. Just thinking if this can be made generic where, in this case, T would be IndexRoutingTable?
| @@ -237,6 +275,25 @@ public ClusterMetadataManifest( | |||
| String previousClusterUUID, | |||
| boolean clusterUUIDCommitted | |||
| ) { | |||
| this(clusterTerm, version, clusterUUID, stateUUID, opensearchVersion, nodeId, committed, codecVersion, | |||
| globalMetadataFileName, indices, previousClusterUUID, clusterUUIDCommitted, null); | |||
There was a problem hiding this comment.
Passing indicesRouting as null will throw NPE in the next step when converting to Collections.unmodifiableList
| builder.startArray(INDICES_ROUTING_FIELD.getPreferredName()); | ||
| { | ||
| for (UploadedIndexMetadata uploadedIndexMetadata : indicesRouting) { | ||
| uploadedIndexMetadata.toXContent(builder, params); | ||
| } | ||
| } |
There was a problem hiding this comment.
builder.endArray needs to be called at the end after adding all uploadedIndexMetadata
|
This PR is stalled because it has been open for 30 days with no activity. |
Description
Adds index routing info to the cluster metadata manifest
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.