Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore deleted section of Contributing.md #13415

Merged
merged 1 commit into from Apr 28, 2024

Conversation

scrawfor99
Copy link
Contributor

Description

I accidentally deleted this section of the Contributing.md section and missed it during review

It originally came from @reta : https://github.com/opensearch-project/OpenSearch/pull/10751/files

Related Issues

Resolves #[Issue number to be closed when this PR is merged]
#12981 (comment)

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Stephen Crawford <steecraw@amazon.com>
Copy link
Contributor

❕ Gradle check result for 42eeefe: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.remotestore.RemoteStoreStatsIT.testNonZeroPrimaryStatsOnNewlyCreatedIndexWithZeroDocs
      1 org.opensearch.gateway.RecoveryFromGatewayIT.testShardStoreFetchMultiNodeMultiIndexesUsingBatchAction

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Apr 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.56%. Comparing base (b15cb0c) to head (42eeefe).
Report is 227 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #13415      +/-   ##
============================================
+ Coverage     71.42%   71.56%   +0.14%     
- Complexity    59978    60838     +860     
============================================
  Files          4985     5045      +60     
  Lines        282275   286080    +3805     
  Branches      40946    41432     +486     
============================================
+ Hits         201603   204737    +3134     
- Misses        63999    64439     +440     
- Partials      16673    16904     +231     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reta
Copy link
Collaborator

reta commented Apr 27, 2024

@scrawfor99 could you rebase please? some GA actions are failing but should be fixed by #13412, thank you

@dbwiddis dbwiddis merged commit fc81a90 into opensearch-project:main Apr 28, 2024
65 of 75 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants