Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant condition in jvmStats test #14075

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

lukas-vlcek
Copy link
Contributor

@lukas-vlcek lukas-vlcek commented Jun 7, 2024

Description

Removing second use of the frequentyl() function. This function is alraedy used in the beginning of the testing block immediately after the declaration of jvmStats variable. The second use of the frequently() could cause all the other variables that were carefully prepared for the constructor to not be used at all.

Related Issues

n/a

Check List

  • Functionality includes testing.
    - [ ] API changes companion pull request created, if applicable.
    - [ ] Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@lukas-vlcek
Copy link
Contributor Author

I do not think this needs to go into CHANGELOG (unless the process was changed). Can someone add skip-changelog flog to this PR please?

Copy link
Contributor

github-actions bot commented Jun 7, 2024

❌ Gradle check result for eddf6ee: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Jun 7, 2024

❌ Gradle check result for f5bf84b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@andrross andrross changed the title Small fix in jvmStats test Remove redundant condition in jvmStats test Jun 7, 2024
@andrross
Copy link
Member

andrross commented Jun 7, 2024

@lukas-vlcek Looks like a spotless formatting error on the build

Removing second use of the `frequentyl()` function. This function is alraedy used in the
beginning of the testing block immediately after the declaration of `jvmStats` variable.
The second use of the `frequently()` could cause all the other variables that were carefully
prepared for the constructor to not be used at all.

Signed-off-by: Lukáš Vlček <lukas.vlcek@aiven.io>
@lukas-vlcek
Copy link
Contributor Author

@andrross Ooops, sorry, fixed.

Copy link
Contributor

github-actions bot commented Jun 7, 2024

❌ Gradle check result for 54dc5e4:

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Jun 7, 2024

❌ Gradle check result for 54dc5e4:

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@lukas-vlcek
Copy link
Contributor Author

I am not sure about the build failure:

cause-exception : com.thoughtworks.xstream.mapper.CannotResolveClassException
cause-message : com.michelin.cio.hudson.plugins.rolestrategy.RoleBasedAuthorizationStrategy
class : hudson.model.Hudson required-type : hudson.model.Hudson
converter-type : hudson.util.RobustReflectionConverter
path : /hudson/authorizationStrategy line number : 10 version : not available

Is this a CI system failure?

@dblock
Copy link
Member

dblock commented Jun 10, 2024

Is this a CI system failure?

Probably. Kicked it.

Copy link
Contributor

❕ Gradle check result for 54dc5e4: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.repositories.azure.AzureBlobContainerRetriesTests.testWriteBlobWithRetries

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Jun 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.61%. Comparing base (b15cb0c) to head (54dc5e4).
Report is 385 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #14075      +/-   ##
============================================
+ Coverage     71.42%   71.61%   +0.19%     
- Complexity    59978    61554    +1576     
============================================
  Files          4985     5081      +96     
  Lines        282275   289071    +6796     
  Branches      40946    41836     +890     
============================================
+ Hits         201603   207008    +5405     
- Misses        63999    65004    +1005     
- Partials      16673    17059     +386     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dblock dblock added the backport 2.x Backport to 2.x branch label Jun 10, 2024
@dblock dblock merged commit 13dd322 into opensearch-project:main Jun 10, 2024
30 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 10, 2024
Removing second use of the `frequentyl()` function. This function is alraedy used in the
beginning of the testing block immediately after the declaration of `jvmStats` variable.
The second use of the `frequently()` could cause all the other variables that were carefully
prepared for the constructor to not be used at all.

Signed-off-by: Lukáš Vlček <lukas.vlcek@aiven.io>
(cherry picked from commit 13dd322)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@lukas-vlcek lukas-vlcek deleted the fix_jvmStats_test branch June 10, 2024 18:07
parv0201 pushed a commit to parv0201/OpenSearch that referenced this pull request Jun 10, 2024
Removing second use of the `frequentyl()` function. This function is alraedy used in the
beginning of the testing block immediately after the declaration of `jvmStats` variable.
The second use of the `frequently()` could cause all the other variables that were carefully
prepared for the constructor to not be used at all.

Signed-off-by: Lukáš Vlček <lukas.vlcek@aiven.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants