-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make IndicesRequestCacheCleanupIT more robust #14478
Make IndicesRequestCacheCleanupIT more robust #14478
Conversation
Signed-off-by: Kiran Prakash <awskiran@amazon.com>
@andrross can you review this ? |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-14478-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 e8b7913926a9428a0a737569e6df44cfeff3defb
# Push it to GitHub
git push --set-upstream origin backport/backport-14478-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x Then, create a pull request where the |
@andrross I will create a manual backport, thanks for merging. |
@kiranprakash154 The backport shouldn't fail unless we've missed a previous one. I don't think there's any reason this code should be different across the main and 2.x branches. |
Signed-off-by: Kiran Prakash <awskiran@amazon.com> (cherry picked from commit e8b7913) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
It failed because the previous backport was not merged yet, Jay merged it yesterday - #14482 I retried and looks like the auto backport worked - #14498 |
(cherry picked from commit e8b7913) Signed-off-by: Kiran Prakash <awskiran@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
This is a followup to #14369
and has 3 changes
testCacheWithInvalidation
to keep it consistent with other tests.TimeValue.timeValueDays(1)
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.