Refactored the GeoBoundsAggregation code from server folder to geo module. #3992

navneet1v · 2022-07-22T20:54:51Z

Description

This change refactors the code of GeoBoundsAggregation on GeoPoints from the server folder to the modules/geo.

The proposal is being discussed and signed off here: opensearch-project/geospatial#92

Issues Resolved

#3980

High Level Task: opensearch-project/geospatial#104

Check List

New functionality includes testing.
- All tests pass
New functionality has been documented.
- New functionality has javadoc added
Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Navneet Verma navneev@amazon.com

github-actions · 2022-07-22T21:01:43Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/929/
CommitID: ca8462a9f9ca88088c93fe9ba5d9011a97124d29

github-actions · 2022-07-22T21:06:57Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/930/
CommitID: 2bdc39df37a6599176a7394872df897ef4d46591

github-actions · 2022-07-22T21:33:08Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/931/
CommitID: 38b48474f836e2cb1fe7106890278b85e46538d2

nknize

Love this! I have just a couple initial questions before fully approving.

nknize · 2022-07-27T16:29:03Z

modules/geo/src/internalClusterTest/java/org/opensearch/geo/GeoPluginIntegTestCase.java

+     */
+    @Override
+    protected boolean addMockGeoShapeFieldMapper() {
+        return false;


In what test scenarios would this get set to true?

As per the documentation there are test cases which are written in the server folder which depends on this, which test the indexing of geoshape as the geoshape mapper is still in the server folder.

Here is the failure CI link which suggest what tests failed when we removed this addMockGeoShapeFieldMapper function.

https://build.ci.opensearch.org/job/gradle-check/1049/console

REPRODUCE WITH: ./gradlew ':server:internalClusterTest' --tests "org.opensearch.search.geo.LegacyGeoShapeIntegrationIT.testIgnoreMalformed" -Dtests.seed=451EB605A707A8A9 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=is-IS -Dtests.timezone=America/Argentina/Salta -Druntime.java=17 org.opensearch.search.geo.LegacyGeoShapeIntegrationIT > testIgnoreMalformed FAILED MapperParsingException[Failed to parse mapping [_doc]: No handler for type [geo_shape] declared on field [shape]]; nested: MapperParsingException[No handler for type [geo_shape] declared on field [shape]]; at __randomizedtesting.SeedInfo.seed([451EB605A707A8A9:2383346D65B64520]:0) at org.opensearch.index.mapper.MapperService.internalMerge(MapperService.java:443) at org.opensearch.index.mapper.MapperService.merge(MapperService.java:411) at org.opensearch.cluster.metadata.MetadataCreateIndexService.updateIndexMappingsAndBuildSortOrder(MetadataCreateIndexService.java:1115) at org.opensearch.cluster.metadata.MetadataCreateIndexService.lambda$applyCreateIndexWithTemporaryService$2(MetadataCreateIndexService.java:453) at org.opensearch.indices.IndicesService.withTempIndexService(IndicesService.java:687) at org.opensearch.cluster.metadata.MetadataCreateIndexService.applyCreateIndexWithTemporaryService(MetadataCreateIndexService.java:451) at org.opensearch.cluster.metadata.MetadataCreateIndexService.applyCreateIndexRequestWithV1Templates(MetadataCreateIndexService.java:556) at org.opensearch.cluster.metadata.MetadataCreateIndexService.applyCreateIndexRequest(MetadataCreateIndexService.java:413) at org.opensearch.cluster.metadata.MetadataCreateIndexService.applyCreateIndexRequest(MetadataCreateIndexService.java:420) at org.opensearch.cluster.metadata.MetadataCreateIndexService$1.execute(MetadataCreateIndexService.java:326) at org.opensearch.cluster.ClusterStateUpdateTask.execute(ClusterStateUpdateTask.java:65) at org.opensearch.cluster.service.MasterService.executeTasks(MasterService.java:824) at org.opensearch.cluster.service.MasterService.calculateTaskOutputs(MasterService.java:395) at org.opensearch.cluster.service.MasterService.runTasks(MasterService.java:266) at org.opensearch.cluster.service.MasterService$Batcher.run(MasterService.java:190) at org.opensearch.cluster.service.TaskBatcher.runIfNotProcessed(TaskBatcher.java:176) at org.opensearch.cluster.service.TaskBatcher$BatchedTask.run(TaskBatcher.java:214) at org.opensearch.common.util.concurrent.ThreadContext$ContextPreservingRunnable.run(ThreadContext.java:739) at org.opensearch.common.util.concurrent.PrioritizedOpenSearchThreadPoolExecutor$TieBreakingPrioritizedRunnable.runAndClean(PrioritizedOpenSearchThreadPoolExecutor.java:282) at org.opensearch.common.util.concurrent.PrioritizedOpenSearchThreadPoolExecutor$TieBreakingPrioritizedRunnable.run(PrioritizedOpenSearchThreadPoolExecutor.java:245) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) at java.lang.Thread.run(Thread.java:833) Caused by: MapperParsingException[No handler for type [geo_shape] declared on field [shape]] at org.opensearch.index.mapper.ObjectMapper$TypeParser.parseProperties(ObjectMapper.java:380) at org.opensearch.index.mapper.ObjectMapper$TypeParser.parseObjectOrDocumentTypeProperties(ObjectMapper.java:295) at org.opensearch.index.mapper.RootObjectMapper$TypeParser.parse(RootObjectMapper.java:182) at org.opensearch.index.mapper.DocumentMapperParser.parse(DocumentMapperParser.java:143) at org.opensearch.index.mapper.DocumentMapperParser.parse(DocumentMapperParser.java:132) at org.opensearch.index.mapper.MapperService.internalMerge(MapperService.java:441) ... 22 more REPRODUCE WITH: ./gradlew ':server:internalClusterTest' --tests "org.opensearch.search.geo.LegacyGeoShapeIntegrationIT.testOrientationPersistence" -Dtests.seed=451EB605A707A8A9 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=is-IS -Dtests.timezone=America/Argentina/Salta -Druntime.java=17 org.opensearch.search.geo.LegacyGeoShapeIntegrationIT > testOrientationPersistence FAILED MapperParsingException[Failed to parse mapping [_doc]: No handler for type [geo_shape] declared on field [location]]; nested: MapperParsingException[No handler for type [geo_shape] declared on field [location]]; at __randomizedtesting.SeedInfo.seed([451EB605A707A8A9:14C1668D19C14D41]:0) at org.opensearch.index.mapper.MapperService.internalMerge(MapperService.java:443) at org.opensearch.index.mapper.MapperService.merge(MapperService.java:411) at org.opensearch.cluster.metadata.MetadataCreateIndexService.updateIndexMappingsAndBuildSortOrder(MetadataCreateIndexService.java:1115) at org.opensearch.cluster.metadata.MetadataCreateIndexService.lambda$applyCreateIndexWithTemporaryService$2(MetadataCreateIndexService.java:453) at org.opensearch.indices.IndicesService.withTempIndexService(IndicesService.java:687) at org.opensearch.cluster.metadata.MetadataCreateIndexService.applyCreateIndexWithTemporaryService(MetadataCreateIndexService.java:451) at org.opensearch.cluster.metadata.MetadataCreateIndexService.applyCreateIndexRequestWithV1Templates(MetadataCreateIndexService.java:556) at org.opensearch.cluster.metadata.MetadataCreateIndexService.applyCreateIndexRequest(MetadataCreateIndexService.java:413) at org.opensearch.cluster.metadata.MetadataCreateIndexService.applyCreateIndexRequest(MetadataCreateIndexService.java:420) at org.opensearch.cluster.metadata.MetadataCreateIndexService$1.execute(MetadataCreateIndexService.java:326) at org.opensearch.cluster.ClusterStateUpdateTask.execute(ClusterStateUpdateTask.java:65) at org.opensearch.cluster.service.MasterService.executeTasks(MasterService.java:824) at org.opensearch.cluster.service.MasterService.calculateTaskOutputs(MasterService.java:395) at org.opensearch.cluster.service.MasterService.runTasks(MasterService.java:266) at org.opensearch.cluster.service.MasterService$Batcher.run(MasterService.java:190) at org.opensearch.cluster.service.TaskBatcher.runIfNotProcessed(TaskBatcher.java:176) at org.opensearch.cluster.service.TaskBatcher$BatchedTask.run(TaskBatcher.java:214) at org.opensearch.common.util.concurrent.ThreadContext$ContextPreservingRunnable.run(ThreadContext.java:739) at org.opensearch.common.util.concurrent.PrioritizedOpenSearchThreadPoolExecutor$TieBreakingPrioritizedRunnable.runAndClean(PrioritizedOpenSearchThreadPoolExecutor.java:282) at org.opensearch.common.util.concurrent.PrioritizedOpenSearchThreadPoolExecutor$TieBreakingPrioritizedRunnable.run(PrioritizedOpenSearchThreadPoolExecutor.java:245) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) at java.lang.Thread.run(Thread.java:833) Caused by: MapperParsingException[No handler for type [geo_shape] declared on field [location]] at org.opensearch.index.mapper.ObjectMapper$TypeParser.parseProperties(ObjectMapper.java:380) at org.opensearch.index.mapper.ObjectMapper$TypeParser.parseObjectOrDocumentTypeProperties(ObjectMapper.java:295) at org.opensearch.index.mapper.RootObjectMapper$TypeParser.parse(RootObjectMapper.java:182) at org.opensearch.index.mapper.DocumentMapperParser.parse(DocumentMapperParser.java:143) at org.opensearch.index.mapper.DocumentMapperParser.parse(DocumentMapperParser.java:132) at org.opensearch.index.mapper.MapperService.internalMerge(MapperService.java:441) ... 22 more REPRODUCE WITH: ./gradlew ':server:internalClusterTest' --tests "org.opensearch.search.geo.LegacyGeoShapeIntegrationIT.testDisallowExpensiveQueries" -Dtests.seed=451EB605A707A8A9 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=is-IS -Dtests.timezone=America/Argentina/Salta -Druntime.java=17 org.opensearch.search.geo.LegacyGeoShapeIntegrationIT > testDisallowExpensiveQueries FAILED MapperParsingException[Failed to parse mapping [_doc]: No handler for type [geo_shape] declared on field [shape]]; nested: MapperParsingException[No handler for type [geo_shape] declared on field [shape]]; at __randomizedtesting.SeedInfo.seed([451EB605A707A8A9:6209CE80B3E38F79]:0) at org.opensearch.index.mapper.MapperService.internalMerge(MapperService.java:443) at org.opensearch.index.mapper.MapperService.merge(MapperService.java:411) at org.opensearch.cluster.metadata.MetadataCreateIndexService.updateIndexMappingsAndBuildSortOrder(MetadataCreateIndexService.java:1115) at org.opensearch.cluster.metadata.MetadataCreateIndexService.lambda$applyCreateIndexWithTemporaryService$2(MetadataCreateIndexService.java:453) at org.opensearch.indices.IndicesService.withTempIndexService(IndicesService.java:687) at org.opensearch.cluster.metadata.MetadataCreateIndexService.applyCreateIndexWithTemporaryService(MetadataCreateIndexService.java:451) at org.opensearch.cluster.metadata.MetadataCreateIndexService.applyCreateIndexRequestWithV1Templates(MetadataCreateIndexService.java:556) at org.opensearch.cluster.metadata.MetadataCreateIndexService.applyCreateIndexRequest(MetadataCreateIndexService.java:413) at org.opensearch.cluster.metadata.MetadataCreateIndexService.applyCreateIndexRequest(MetadataCreateIndexService.java:420) at org.opensearch.cluster.metadata.MetadataCreateIndexService$1.execute(MetadataCreateIndexService.java:326) at org.opensearch.cluster.ClusterStateUpdateTask.execute(ClusterStateUpdateTask.java:65) at org.opensearch.cluster.service.MasterService.executeTasks(MasterService.java:824) at org.opensearch.cluster.service.MasterService.calculateTaskOutputs(MasterService.java:395) at org.opensearch.cluster.service.MasterService.runTasks(MasterService.java:266) at org.opensearch.cluster.service.MasterService$Batcher.run(MasterService.java:190) at org.opensearch.cluster.service.TaskBatcher.runIfNotProcessed(TaskBatcher.java:176) at org.opensearch.cluster.service.TaskBatcher$BatchedTask.run(TaskBatcher.java:214) at org.opensearch.common.util.concurrent.ThreadContext$ContextPreservingRunnable.run(ThreadContext.java:739) at org.opensearch.common.util.concurrent.PrioritizedOpenSearchThreadPoolExecutor$TieBreakingPrioritizedRunnable.runAndClean(PrioritizedOpenSearchThreadPoolExecutor.java:282) at org.opensearch.common.util.concurrent.PrioritizedOpenSearchThreadPoolExecutor$TieBreakingPrioritizedRunnable.run(PrioritizedOpenSearchThreadPoolExecutor.java:245) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) at java.lang.Thread.run(Thread.java:833) Caused by: MapperParsingException[No handler for type [geo_shape] declared on field [shape]] at org.opensearch.index.mapper.ObjectMapper$TypeParser.parseProperties(ObjectMapper.java:380) at org.opensearch.index.mapper.ObjectMapper$TypeParser.parseObjectOrDocumentTypeProperties(ObjectMapper.java:295) at org.opensearch.index.mapper.RootObjectMapper$TypeParser.parse(RootObjectMapper.java:182) at org.opensearch.index.mapper.DocumentMapperParser.parse(DocumentMapperParser.java:143) at org.opensearch.index.mapper.DocumentMapperParser.parse(DocumentMapperParser.java:132) at org.opensearch.index.mapper.MapperService.internalMerge(MapperService.java:441) ... 22 more REPRODUCE WITH: ./gradlew ':server:internalClusterTest' --tests "org.opensearch.search.geo.LegacyGeoShapeIntegrationIT.testLegacyCircle" -Dtests.seed=451EB605A707A8A9 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=is-IS -Dtests.timezone=America/Argentina/Salta -Druntime.java=17 org.opensearch.search.geo.LegacyGeoShapeIntegrationIT > testLegacyCircle FAILED MapperParsingException[Failed to parse mapping [_doc]: No handler for type [geo_shape] declared on field [shape]]; nested: MapperParsingException[No handler for type [geo_shape] declared on field [shape]]; at __randomizedtesting.SeedInfo.seed([451EB605A707A8A9:5646E7CB6FDF1CF8]:0) at org.opensearch.index.mapper.MapperService.internalMerge(MapperService.java:443) at org.opensearch.index.mapper.MapperService.merge(MapperService.java:411) at org.opensearch.cluster.metadata.MetadataCreateIndexService.updateIndexMappingsAndBuildSortOrder(MetadataCreateIndexService.java:1115) at org.opensearch.cluster.metadata.MetadataCreateIndexService.lambda$applyCreateIndexWithTemporaryService$2(MetadataCreateIndexService.java:453) at org.opensearch.indices.IndicesService.withTempIndexService(IndicesService.java:687) at org.opensearch.cluster.metadata.MetadataCreateIndexService.applyCreateIndexWithTemporaryService(MetadataCreateIndexService.java:451) at org.opensearch.cluster.metadata.MetadataCreateIndexService.applyCreateIndexRequestWithV1Templates(MetadataCreateIndexService.java:556) at org.opensearch.cluster.metadata.MetadataCreateIndexService.applyCreateIndexRequest(MetadataCreateIndexService.java:413) at org.opensearch.cluster.metadata.MetadataCreateIndexService.applyCreateIndexRequest(MetadataCreateIndexService.java:420) at org.opensearch.cluster.metadata.MetadataCreateIndexService$1.execute(MetadataCreateIndexService.java:326) at org.opensearch.cluster.ClusterStateUpdateTask.execute(ClusterStateUpdateTask.java:65) at org.opensearch.cluster.service.MasterService.executeTasks(MasterService.java:824) at org.opensearch.cluster.service.MasterService.calculateTaskOutputs(MasterService.java:395) at org.opensearch.cluster.service.MasterService.runTasks(MasterService.java:266) at org.opensearch.cluster.service.MasterService$Batcher.run(MasterService.java:190) at org.opensearch.cluster.service.TaskBatcher.runIfNotProcessed(TaskBatcher.java:176) at org.opensearch.cluster.service.TaskBatcher$BatchedTask.run(TaskBatcher.java:214) at org.opensearch.common.util.concurrent.ThreadContext$ContextPreservingRunnable.run(ThreadContext.java:739) at org.opensearch.common.util.concurrent.PrioritizedOpenSearchThreadPoolExecutor$TieBreakingPrioritizedRunnable.runAndClean(PrioritizedOpenSearchThreadPoolExecutor.java:282) at org.opensearch.common.util.concurrent.PrioritizedOpenSearchThreadPoolExecutor$TieBreakingPrioritizedRunnable.run(PrioritizedOpenSearchThreadPoolExecutor.java:245) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) at java.lang.Thread.run(Thread.java:833) Caused by: MapperParsingException[No handler for type [geo_shape] declared on field [shape]] at org.opensearch.index.mapper.ObjectMapper$TypeParser.parseProperties(ObjectMapper.java:380) at org.opensearch.index.mapper.ObjectMapper$TypeParser.parseObjectOrDocumentTypeProperties(ObjectMapper.java:295) at org.opensearch.index.mapper.RootObjectMapper$TypeParser.parse(RootObjectMapper.java:182) at org.opensearch.index.mapper.DocumentMapperParser.parse(DocumentMapperParser.java:143) at org.opensearch.index.mapper.DocumentMapperParser.parse(DocumentMapperParser.java:132) at org.opensearch.index.mapper.MapperService.internalMerge(MapperService.java:441) ... 22 more REPRODUCE WITH: ./gradlew ':server:internalClusterTest' --tests "org.opensearch.search.geo.LegacyGeoShapeIntegrationIT.testIndexShapeRouting" -Dtests.seed=451EB605A707A8A9 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=is-IS -Dtests.timezone=America/Argentina/Salta -Druntime.java=17 org.opensearch.search.geo.LegacyGeoShapeIntegrationIT > testIndexShapeRouting FAILED MapperParsingException[Failed to parse mapping [_doc]: No handler for type [geo_shape] declared on field [shape]]; nested: MapperParsingException[No handler for type [geo_shape] declared on field [shape]]; at __randomizedtesting.SeedInfo.seed([451EB605A707A8A9:12DFAF8F1ED154AC]:0) at org.opensearch.index.mapper.MapperService.internalMerge(MapperService.java:443) at org.opensearch.index.mapper.MapperService.merge(MapperService.java:411) at org.opensearch.cluster.metadata.MetadataCreateIndexService.updateIndexMappingsAndBuildSortOrder(MetadataCreateIndexService.java:1115) at org.opensearch.cluster.metadata.MetadataCreateIndexService.lambda$applyCreateIndexWithTemporaryService$2(MetadataCreateIndexService.java:453) at org.opensearch.indices.IndicesService.withTempIndexService(IndicesService.java:687) at org.opensearch.cluster.metadata.MetadataCreateIndexService.applyCreateIndexWithTemporaryService(MetadataCreateIndexService.java:451) at org.opensearch.cluster.metadata.MetadataCreateIndexService.applyCreateIndexRequestWithV1Templates(MetadataCreateIndexService.java:556) at org.opensearch.cluster.metadata.MetadataCreateIndexService.applyCreateIndexRequest(MetadataCreateIndexService.java:413) at org.opensearch.cluster.metadata.MetadataCreateIndexService.applyCreateIndexRequest(MetadataCreateIndexService.java:420) at org.opensearch.cluster.metadata.MetadataCreateIndexService$1.execute(MetadataCreateIndexService.java:326) at org.opensearch.cluster.ClusterStateUpdateTask.execute(ClusterStateUpdateTask.java:65) at org.opensearch.cluster.service.MasterService.executeTasks(MasterService.java:824) at org.opensearch.cluster.service.MasterService.calculateTaskOutputs(MasterService.java:395) at org.opensearch.cluster.service.MasterService.runTasks(MasterService.java:266) at org.opensearch.cluster.service.MasterService$Batcher.run(MasterService.java:190) at org.opensearch.cluster.service.TaskBatcher.runIfNotProcessed(TaskBatcher.java:176) at org.opensearch.cluster.service.TaskBatcher$BatchedTask.run(TaskBatcher.java:214) at org.opensearch.common.util.concurrent.ThreadContext$ContextPreservingRunnable.run(ThreadContext.java:739) at org.opensearch.common.util.concurrent.PrioritizedOpenSearchThreadPoolExecutor$TieBreakingPrioritizedRunnable.runAndClean(PrioritizedOpenSearchThreadPoolExecutor.java:282) at org.opensearch.common.util.concurrent.PrioritizedOpenSearchThreadPoolExecutor$TieBreakingPrioritizedRunnable.run(PrioritizedOpenSearchThreadPoolExecutor.java:245) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) at java.lang.Thread.run(Thread.java:833) Caused by: MapperParsingException[No handler for type [geo_shape] declared on field [shape]] at org.opensearch.index.mapper.ObjectMapper$TypeParser.parseProperties(ObjectMapper.java:380) at org.opensearch.index.mapper.ObjectMapper$TypeParser.parseObjectOrDocumentTypeProperties(ObjectMapper.java:295) at org.opensearch.index.mapper.RootObjectMapper$TypeParser.parse(RootObjectMapper.java:182) at org.opensearch.index.mapper.DocumentMapperParser.parse(DocumentMapperParser.java:143) at org.opensearch.index.mapper.DocumentMapperParser.parse(DocumentMapperParser.java:132) at org.opensearch.index.mapper.MapperService.internalMerge(MapperService.java:441) ... 22 more

nknize · 2022-07-27T16:40:58Z

...es/geo/src/main/java/org/opensearch/geo/search/aggregations/metrics/GeoBoundsAggregator.java

-    DoubleArray posRights;
-    DoubleArray negLefts;
-    DoubleArray negRights;
+final class GeoBoundsAggregator extends AbstractGeoBoundsAggregator<ValuesSource.GeoPoint> {


Will there be a new ValuesSource.GeoShape when shape docvalues are added to lucene? Or are you planning on creating a ValuesSource.Geo that handles both?

I was planning to create a new ValueSource which will be ValueSource.GeoShape for geoshapes.

On your comment if I am planning to combine them the honest ans is no I have not thought about it for now. I am not even sure if it is possible or not. But in regards for this PR, I would like to keep this as a refactor code PR.

I will try to put forward proposal on combining the ValuesSource.GeoShape and ValuesSource.GeoPoint to make ValuesSource.Geo and then we can take it from there.

github-actions · 2022-07-27T20:50:15Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/1049/
CommitID: 0127ade3727bf7c213cd1f784918ff37f11ea34b

github-actions · 2022-07-27T22:00:21Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/1055/
CommitID: e87bfa18e685a6f41f164912e04a25ca8d00bada

github-actions · 2022-07-27T22:31:11Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/1056/
CommitID: 448a55885376c901be855eab315617384f6b69bd

VijayanB · 2022-07-30T00:47:57Z

@navneet1v Since you are refactoring/moving one aggregation at a time, shall we create tasks for list of aggregation that will be refactored and link to corresponding PR?

navneet1v · 2022-07-30T01:06:03Z

@navneet1v Since you are refactoring/moving one aggregation at a time, shall we create tasks for list of aggregation that will be refactored and link to corresponding PR?

Sure. I think I had this thing in mind but I forgot. Let me create an issue and link it in all the places.

The issue will be an uber issue which will list RFCs, and implementation issues for every Aggregation.

navneet1v · 2022-07-30T01:17:20Z

@navneet1v Since you are refactoring/moving one aggregation at a time, shall we create tasks for list of aggregation that will be refactored and link to corresponding PR?

Sure. I think I had this thing in mind but I forgot. Let me create an issue and link it in all the places.

The issue will be an uber issue which will list RFCs, and implementation issues for every Aggregation.

Issue: opensearch-project/geospatial#104

modules/geo/build.gradle

...ternalClusterTest/java/org/opensearch/geo/search/aggregations/metrics/GeoPluginBoundsIT.java

...rc/main/java/org/opensearch/geo/search/aggregations/metrics/AbstractGeoBoundsAggregator.java

github-actions · 2022-08-01T23:39:03Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/1225/
CommitID: c50c38f8919d8e9ba86f800907936aa7b0238165

github-actions · 2022-08-02T00:13:35Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/1226/
CommitID: c8f4681f93d855ea7514614bb6b7f0090f8c9968

github-actions · 2022-08-02T00:29:31Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/1228/
CommitID: 92bff540b0c3b3d1ba150f872012a190a81cadde

github-actions · 2022-08-02T01:13:18Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/1229/
CommitID: 1ff755e89721473ed203719942d7c56131a90f17

modules/geo/src/main/java/org/opensearch/geo/GeoPlugin.java

github-actions · 2022-08-04T04:38:27Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/1424/
CommitID: 3e35c52a0f8aadf799cce197549e7cdc1c40d797

github-actions · 2022-08-04T05:11:56Z

Gradle Check (Jenkins) Run Completed with:

RESULT: UNSTABLE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/1426/
CommitID: 3c84bef10f76f0908d1a5357e02c131c9675369d

github-actions · 2022-08-04T05:44:43Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/1430/
CommitID: a335f28ce1f7e29328a7e83ce44d39be7b6bb599

navneet1v · 2022-08-04T05:49:54Z

@opensearch-project/opensearch-core can anyone take a look into this CR, it has been there for long period of time.

…server folder to geo module.(opensearch-project#3980) Signed-off-by: Navneet Verma <navneev@amazon.com>

github-actions · 2022-08-04T20:18:51Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/1459/
CommitID: 074b5fc

nknize

LGTM! One minor nit we can do in a follow up PR.

...rg/opensearch/geo/search/aggregations/metrics/AbstractGeoAggregatorTestCaseModulePlugin.java

navneet1v · 2022-08-09T19:55:22Z

LGTM! One minor nit we can do in a follow up PR.

sure will fix in the next PR for moving the GeoTile and GeoHashGird aggregation to Geo module

navneet1v · 2022-08-09T20:40:10Z

Backport of 2.x is pending. Need to figure out a way to backport these changes to the 2.x branch.

opensearch-trigger-bot · 2022-08-09T20:40:22Z

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-3992-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 4751f3bd296e6952b852a457a82220ec248b037a
# Push it to GitHub
git push --set-upstream origin backport/backport-3992-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-3992-to-2.x.

navneet1v · 2022-08-09T21:34:01Z

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

BASH (SHELL) (16 lines)

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-3992-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 4751f3bd296e6952b852a457a82220ec248b037a
# Push it to GitHub
git push --set-upstream origin backport/backport-3992-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-3992-to-2.x.

Back-porting PR: #4179

navneet1v requested review from a team and reta as code owners July 22, 2022 20:54

navneet1v added Plugins Search:Aggregations v2.5.0 'Issues and PRs related to version v2.5.0' labels Jul 22, 2022

navneet1v force-pushed the main branch 2 times, most recently from 2bdc39d to 38b4847 Compare July 22, 2022 21:05

navneet1v added the Geospatial label Jul 22, 2022

nknize reviewed Jul 27, 2022

View reviewed changes

navneet1v force-pushed the main branch from 38b4847 to 0127ade Compare July 27, 2022 20:21

navneet1v force-pushed the main branch from 0127ade to e87bfa1 Compare July 27, 2022 21:47

navneet1v force-pushed the main branch from e87bfa1 to 448a558 Compare July 27, 2022 22:07

nknize mentioned this pull request Jul 29, 2022

[Refactor] *Plugin classes in modules/ source module to *Module classes #4034

Closed

VijayanB reviewed Aug 1, 2022

View reviewed changes

modules/geo/build.gradle Show resolved Hide resolved

VijayanB reviewed Aug 1, 2022

View reviewed changes

...ternalClusterTest/java/org/opensearch/geo/search/aggregations/metrics/GeoPluginBoundsIT.java Outdated Show resolved Hide resolved

VijayanB reviewed Aug 1, 2022

View reviewed changes

...rc/main/java/org/opensearch/geo/search/aggregations/metrics/AbstractGeoBoundsAggregator.java Outdated Show resolved Hide resolved

navneet1v force-pushed the main branch 2 times, most recently from c50c38f to c8f4681 Compare August 1, 2022 23:37

navneet1v force-pushed the main branch from c8f4681 to 92bff54 Compare August 2, 2022 00:14

navneet1v force-pushed the main branch from 92bff54 to 1ff755e Compare August 2, 2022 00:49

navneet1v requested a review from a team August 3, 2022 01:27

VijayanB reviewed Aug 4, 2022

View reviewed changes

modules/geo/src/main/java/org/opensearch/geo/GeoPlugin.java Outdated Show resolved Hide resolved

VijayanB approved these changes Aug 4, 2022

View reviewed changes

navneet1v force-pushed the main branch from 1ff755e to 3e35c52 Compare August 4, 2022 04:29

navneet1v force-pushed the main branch from 3e35c52 to 3c84bef Compare August 4, 2022 04:43

navneet1v force-pushed the main branch from 3c84bef to a335f28 Compare August 4, 2022 05:19

Refactored the src and test of GeoBoundsAggregation on GeoPoint from …

074b5fc

…server folder to geo module.(opensearch-project#3980) Signed-off-by: Navneet Verma <navneev@amazon.com>

navneet1v force-pushed the main branch from a335f28 to 074b5fc Compare August 4, 2022 19:49

kartg mentioned this pull request Aug 8, 2022

[BUG] : Gradle Build failed on Jenkins with Build Successful message #4125

Closed

nknize approved these changes Aug 9, 2022

View reviewed changes

...rg/opensearch/geo/search/aggregations/metrics/AbstractGeoAggregatorTestCaseModulePlugin.java Show resolved Hide resolved

nknize merged commit 4751f3b into opensearch-project:main Aug 9, 2022

navneet1v added the backport 2.x Backport to 2.x branch label Aug 9, 2022

navneet1v mentioned this pull request Aug 9, 2022

[Backport 2.x] Refactors the GeoBoundsAggregation for geo_point types from the core server to the geo module (#3992) #4179

Merged

5 tasks

navneet1v removed the v2.5.0 'Issues and PRs related to version v2.5.0' label Aug 9, 2022

navneet1v mentioned this pull request Aug 16, 2022

Merge Geo_Points and Geo_Shape CoreValue Source Type to 1 single Core Value Source Type Geo opensearch-project/geospatial#124

Open

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactored the GeoBoundsAggregation code from server folder to geo module. #3992

Refactored the GeoBoundsAggregation code from server folder to geo module. #3992

navneet1v commented Jul 22, 2022 •

edited

Loading

github-actions bot commented Jul 22, 2022

github-actions bot commented Jul 22, 2022

github-actions bot commented Jul 22, 2022

nknize left a comment

nknize Jul 27, 2022

navneet1v Jul 27, 2022 •

edited

Loading

nknize Jul 27, 2022

navneet1v Jul 27, 2022 •

edited

Loading

github-actions bot commented Jul 27, 2022

github-actions bot commented Jul 27, 2022

github-actions bot commented Jul 27, 2022

VijayanB commented Jul 30, 2022 •

edited

Loading

navneet1v commented Jul 30, 2022

navneet1v commented Jul 30, 2022

github-actions bot commented Aug 1, 2022

github-actions bot commented Aug 2, 2022

github-actions bot commented Aug 2, 2022

github-actions bot commented Aug 2, 2022

github-actions bot commented Aug 4, 2022

github-actions bot commented Aug 4, 2022

github-actions bot commented Aug 4, 2022

navneet1v commented Aug 4, 2022

github-actions bot commented Aug 4, 2022

nknize left a comment

navneet1v commented Aug 9, 2022

navneet1v commented Aug 9, 2022

opensearch-trigger-bot bot commented Aug 9, 2022

navneet1v commented Aug 9, 2022

Refactored the GeoBoundsAggregation code from server folder to geo module. #3992

Refactored the GeoBoundsAggregation code from server folder to geo module. #3992

Conversation

navneet1v commented Jul 22, 2022 • edited Loading

Description

Issues Resolved

Check List

github-actions bot commented Jul 22, 2022

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Jul 22, 2022

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Jul 22, 2022

Gradle Check (Jenkins) Run Completed with:

nknize left a comment

Choose a reason for hiding this comment

nknize Jul 27, 2022

Choose a reason for hiding this comment

navneet1v Jul 27, 2022 • edited Loading

Choose a reason for hiding this comment

nknize Jul 27, 2022

Choose a reason for hiding this comment

navneet1v Jul 27, 2022 • edited Loading

Choose a reason for hiding this comment

github-actions bot commented Jul 27, 2022

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Jul 27, 2022

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Jul 27, 2022

Gradle Check (Jenkins) Run Completed with:

VijayanB commented Jul 30, 2022 • edited Loading

navneet1v commented Jul 30, 2022

navneet1v commented Jul 30, 2022

github-actions bot commented Aug 1, 2022

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Aug 2, 2022

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Aug 2, 2022

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Aug 2, 2022

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Aug 4, 2022

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Aug 4, 2022

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Aug 4, 2022

Gradle Check (Jenkins) Run Completed with:

navneet1v commented Aug 4, 2022

github-actions bot commented Aug 4, 2022

Gradle Check (Jenkins) Run Completed with:

nknize left a comment

Choose a reason for hiding this comment

navneet1v commented Aug 9, 2022

navneet1v commented Aug 9, 2022

opensearch-trigger-bot bot commented Aug 9, 2022

navneet1v commented Aug 9, 2022

navneet1v commented Jul 22, 2022 •

edited

Loading

navneet1v Jul 27, 2022 •

edited

Loading

navneet1v Jul 27, 2022 •

edited

Loading

VijayanB commented Jul 30, 2022 •

edited

Loading