Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature/Extensions] Created new Request class for ActionListener onFailure #4553

Conversation

ryanbogan
Copy link
Member

@ryanbogan ryanbogan commented Sep 19, 2022

Description

Created new Request class for ActionListener onFailure

Companion PR on opensearch-sdk-java: opensearch-project/opensearch-sdk-java#141

Issues Resolved

#135

Check List

  • [ X] New functionality includes testing.
    • [ X] All tests pass
  • [ X] New functionality has been documented.
    • [ X] New functionality has javadoc added
  • [ X] Commits are signed per the DCO using --signoff
  • [ X] Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Ryan Bogan <rbogan@amazon.com>
Signed-off-by: Ryan Bogan <rbogan@amazon.com>
Signed-off-by: Ryan Bogan <rbogan@amazon.com>
Signed-off-by: Ryan Bogan <rbogan@amazon.com>
Signed-off-by: Ryan Bogan <rbogan@amazon.com>
Signed-off-by: Ryan Bogan <rbogan@amazon.com>
Signed-off-by: Ryan Bogan <rbogan@amazon.com>
Signed-off-by: Ryan Bogan <rbogan@amazon.com>
Signed-off-by: Ryan Bogan <rbogan@amazon.com>
Signed-off-by: Ryan Bogan <rbogan@amazon.com>
…sed comments on previous PR

Signed-off-by: Ryan Bogan <rbogan@amazon.com>
Signed-off-by: Ryan Bogan <rbogan@amazon.com>
Signed-off-by: Ryan Bogan <rbogan@amazon.com>
Signed-off-by: Ryan Bogan <rbogan@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Copy link
Member

@owaiskazi19 owaiskazi19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove requestType

Copy link
Member

@dbwiddis dbwiddis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the comments from @owaiskazi19 , will approve when those are addressed.

@owaiskazi19 owaiskazi19 changed the title Created new Request class for ActionListener onFailure [Feature/Extensions] Created new Request class for ActionListener onFailure Sep 19, 2022
@joshpalis joshpalis self-requested a review September 19, 2022 23:37
Signed-off-by: Ryan Bogan <rbogan@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov-commenter
Copy link

codecov-commenter commented Sep 20, 2022

Codecov Report

Merging #4553 (b2ba169) into feature/extensions (eae2c0b) will decrease coverage by 0.07%.
The diff coverage is 46.66%.

@@                   Coverage Diff                    @@
##             feature/extensions    #4553      +/-   ##
========================================================
- Coverage                 70.62%   70.55%   -0.08%     
+ Complexity                57557    57527      -30     
========================================================
  Files                      4654     4656       +2     
  Lines                    276657   276670      +13     
  Branches                  40427    40428       +1     
========================================================
- Hits                     195399   195214     -185     
- Misses                    64967    65159     +192     
- Partials                  16291    16297       +6     
Impacted Files Coverage Δ
...opensearch/extensions/ExtensionActionListener.java 72.72% <ø> (ø)
...va/org/opensearch/extensions/ExtensionRequest.java 29.41% <ø> (-14.59%) ⬇️
...sions/ExtensionActionListenerOnFailureRequest.java 29.41% <29.41%> (ø)
...rch/extensions/ExtensionActionListenerHandler.java 66.66% <66.66%> (ø)
.../opensearch/extensions/ExtensionsOrchestrator.java 71.75% <75.00%> (+0.87%) ⬆️
.../java/org/opensearch/node/NodeClosedException.java 50.00% <0.00%> (-50.00%) ⬇️
...cluster/coordination/PendingClusterStateStats.java 20.00% <0.00%> (-48.00%) ⬇️
...opensearch/persistent/PersistentTasksExecutor.java 22.22% <0.00%> (-44.45%) ⬇️
.../admin/cluster/reroute/ClusterRerouteResponse.java 60.00% <0.00%> (-40.00%) ⬇️
...luster/routing/allocation/RoutingExplanations.java 62.06% <0.00%> (-37.94%) ⬇️
... and 468 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Ryan Bogan <rbogan@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Signed-off-by: Ryan Bogan <rbogan@amazon.com>
Signed-off-by: Ryan Bogan <rbogan@amazon.com>
Signed-off-by: Ryan Bogan <rbogan@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Signed-off-by: Ryan Bogan <rbogan@amazon.com>
Signed-off-by: Ryan Bogan <rbogan@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Copy link
Member

@dbwiddis dbwiddis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the tests that modify the content of extensions.yml they need to have their own directory or enforce ordering.

Signed-off-by: Ryan Bogan <rbogan@amazon.com>
Signed-off-by: Ryan Bogan <rbogan@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Copy link
Member

@dbwiddis dbwiddis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dbwiddis
Copy link
Member

Failing gradle check tracked by #4162

@owaiskazi19
Copy link
Member

Started gradle check again

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants