Added a section of how to deal with flakey tests to the developer guide. #4868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
6 tasks
dblock
force-pushed
the
flakey-tests-dev-guide
branch
3 times, most recently
from
ad5cce6
to
b9e2ca4
Compare
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
andrross
reviewed
Oct 21, 2022
DEVELOPER_GUIDE.md
Outdated
| 3. Search through [issues](https://github.com/opensearch-project/OpenSearch/issues?q=is%3Aopen+is%3Aissue+label%3A%22Flakey+Random+Test+Failure%22) using the name of the failed test for whether this is a known flakey test. | ||
| 5. If an existing issue is found, paste a link to the known issue in a comment to your PR. | ||
| 6. If no existing issue is found, open one. | ||
| 7. Push an update to your PR to retry CI. |
There was a problem hiding this comment.
The gradle check github action can be retried directly without changing your commit, right?
Next to the failed action click: Details -> Re-run jobs -> Re-run failed jobs
There was a problem hiding this comment.
Don't you have to be a maintainer on the project to do so? Or can PR authors do it?
There was a problem hiding this comment.
I changed it to "Retry CI via the GitHub UX or by pushing an update to your PR."
Signed-off-by: Daniel (dB.) Doubrovkine <dblock@amazon.com>
dblock
force-pushed
the
flakey-tests-dev-guide
branch
from
b9e2ca4
to
4da1df7
Compare
andrross
approved these changes
Oct 21, 2022
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-4868-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b36906ffb2f81722e882752f35ee59eb8827a8c5
# Push it to GitHub
git push --set-upstream origin backport/backport-4868-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.xThen, create a pull request where the |
snuyanzin
pushed a commit
to snuyanzin/OpenSearch
that referenced
this pull request
Oct 28, 2022
…de. (opensearch-project#4868) Signed-off-by: Daniel (dB.) Doubrovkine <dblock@amazon.com> Signed-off-by: Daniel (dB.) Doubrovkine <dblock@amazon.com>
ashking94
pushed a commit
to ashking94/OpenSearch
that referenced
this pull request
Nov 7, 2022
…de. (opensearch-project#4868) Signed-off-by: Daniel (dB.) Doubrovkine <dblock@amazon.com> Signed-off-by: Daniel (dB.) Doubrovkine <dblock@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Daniel (dB.) Doubrovkine dblock@amazon.com
Description
Have a permalink to explain to contributors what to do when they encounter a flakey test.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.