[Extensions] Replace latches with CompletableFutures for extensions #5646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Bogan <rbogan@amazon.com>
ryanbogan
changed the title
Signed-off-by: Ryan Bogan <rbogan@amazon.com>
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Ryan Bogan <rbogan@amazon.com>
ryanbogan
requested review from
reta,
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
setiah,
kartg,
kotwanikunal,
mch2,
nknize,
owaiskazi19,
adnapibar,
Rishikesh1159,
saratvemulapalli,
shwetathareja,
dreamer-89,
tlfeng,
VachaShah and
xuezhou25
as code owners
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #5646 +/- ##
============================================
- Coverage 70.82% 70.76% -0.07%
+ Complexity 58756 58730 -26
============================================
Files 4770 4770
Lines 280721 280756 +35
Branches 40536 40553 +17
============================================
- Hits 198815 198665 -150
- Misses 65577 65783 +206
+ Partials 16329 16308 -21
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Ryan Bogan <rbogan@amazon.com>
Gradle Check (Jenkins) Run Completed with:
|
reta
reviewed
Jan 14, 2023
server/src/main/java/org/opensearch/extensions/ExtensionsManager.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Ryan Bogan <rbogan@amazon.com>
reta
reviewed
Jan 17, 2023
server/src/main/java/org/opensearch/extensions/action/ExtensionTransportActionsHandler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Ryan Bogan <rbogan@amazon.com>
reta
reviewed
Jan 17, 2023
server/src/main/java/org/opensearch/extensions/action/ExtensionTransportActionsHandler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Ryan Bogan <rbogan@amazon.com>
reta
approved these changes
Jan 17, 2023
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Ryan Bogan <rbogan@amazon.com>
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
dblock
approved these changes
Jan 20, 2023
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-5646-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 e2abc4702e94d27e24e64d9b5dbce7b3b136c332
# Push it to GitHub
git push --set-upstream origin backport/backport-5646-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.xThen, create a pull request where the |
6 tasks
andrross
reviewed
Jan 24, 2023
| @@ -34,6 +34,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), | |||
| - Add query for initialized extensions ([#5658](https://github.com/opensearch-project/OpenSearch/pull/5658)) | |||
| - Revert 'Added jackson dependency to server' and change extension reading ([#5768](https://github.com/opensearch-project/OpenSearch/pull/5768)) | |||
| - Add support to disallow search request with preference parameter with strict weighted shard routing([#5874](https://github.com/opensearch-project/OpenSearch/pull/5874)) | |||
| - Replace latches with CompletableFutures for extensions ([#5646](https://github.com/opensearch-project/OpenSearch/pull/5646)) | |||
There was a problem hiding this comment.
@ryanbogan Can you move this entry to the [Unreleased 2.x] section of this file since this is going to be released in the next 2.x version? The fact that this entry was in the wrong spot is possibly the reason why the cherry pick had conflicts on the backport. See the contributing doc for details about where to place your changelog entry.
This was referenced Jan 24, 2023
andrross
added a commit
to andrross/OpenSearch
that referenced
this pull request
Jan 26, 2023
This commit fixes the changelog entry placement error in opensearch-project#5646 Signed-off-by: Andrew Ross <andrross@amazon.com>
6 tasks
dblock
pushed a commit
that referenced
this pull request
Jan 26, 2023
This commit fixes the changelog entry placement error in #5646 Signed-off-by: Andrew Ross <andrross@amazon.com> Signed-off-by: Andrew Ross <andrross@amazon.com>
Merged
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ryan Bogan rbogan@amazon.com
Description
Removes latches and CompletableFuture .get() calls to make requests asynchronous
Issues Resolved
opensearch-project/opensearch-sdk-java#292
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.