[Backport 2.5] Add support for API versioning and fail open in weighted shard routing #5784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… weights in the response (opensearch-project#5680) * Add support for discovered master and remove local weights in the weighted routing API response Signed-off-by: Anshu Agarwal <anshukag@amazon.com>
* Support API versioning for weighted shard routing Signed-off-by: Anshu Agarwal <anshukag@amazon.com>
…pensearch-project#5072) * Fail open requests on search shard failures ( Signed-off-by: Anshu Agarwal <anshukag@amazon.com>
[Weighted Shard Routing] Refactor and fix singleton in FailAwareWeightedRouting Signed-off-by: Anshu Agarwal <anshukag@amazon.com>
anshu1106
requested review from
reta,
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
gbbafna,
setiah,
kartg,
kotwanikunal,
mch2,
nknize,
owaiskazi19,
adnapibar,
Rishikesh1159,
ryanbogan,
saratvemulapalli,
shwetathareja,
dreamer-89,
tlfeng,
VachaShah and
xuezhou25
as code owners
gbbafna
reviewed
Jan 10, 2023
CHANGELOG.md
Outdated
Comment on lines
17
to
20
| - Add project health badges to the README.md ([#4843](https://github.com/opensearch-project/OpenSearch/pull/4843)) | ||
| - [Test] Add IAE test for deprecated edgeNGram analyzer name ([#5040](https://github.com/opensearch-project/OpenSearch/pull/5040)) | ||
| - Allow mmap to use new JDK-19 preview APIs in Apache Lucene 9.4+ ([#5151](https://github.com/opensearch-project/OpenSearch/pull/5151)) | ||
| - Add feature flag for extensions ([#5211](https://github.com/opensearch-project/OpenSearch/pull/5211)) |
CHANGELOG.md
Outdated
| - Added jackson dependency to server ([#5366] (https://github.com/opensearch-project/OpenSearch/pull/5366)) | ||
| - Adding support to register settings dynamically ([#5495](https://github.com/opensearch-project/OpenSearch/pull/5495)) | ||
| - Adding auto release workflow ([#5582](https://github.com/opensearch-project/OpenSearch/pull/5582)) | ||
| - Added experimental support for extensions ([#5347](https://github.com/opensearch-project/OpenSearch/pull/5347)), ([#5518](https://github.com/opensearch-project/OpenSearch/pull/5518)), ([#5597](https://github.com/opensearch-project/OpenSearch/pull/5597)), ([#5615](https://github.com/opensearch-project/OpenSearch/pull/5615))) | ||
| - Add CI bundle pattern to distribution download ([#5348](https://github.com/opensearch-project/OpenSearch/pull/5348)) | ||
| - Add support for ppc64le architecture ([#5459](https://github.com/opensearch-project/OpenSearch/pull/5459)) |
CHANGELOG.md
Outdated
Comment on lines
33
to
34
| - Added support for feature flags in opensearch.yml ([#4959](https://github.com/opensearch-project/OpenSearch/pull/4959)) | ||
| - Add query for initialized extensions ([#5658](https://github.com/opensearch-project/OpenSearch/pull/5658)) |
added 2 commits
January 10, 2023 15:39
Signed-off-by: Anshu Agarwal <anshukag@amazon.com>
Signed-off-by: Anshu Agarwal <anshukag@amazon.com>
gbbafna
approved these changes
Jan 10, 2023
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Bukhtawar
approved these changes
Jan 10, 2023
Bukhtawar
reviewed
Jan 10, 2023
|
|
||
| public ClusterDeleteWeightedRoutingRequest(StreamInput in) throws IOException { | ||
| super(in); | ||
| version = in.readLong(); |
There was a problem hiding this comment.
Will this fail for mixed version cluster tests?
There was a problem hiding this comment.
This is a breaking change. Delete request will fail if version is not provided.
Not sure if I understood the question correctly.
There was a problem hiding this comment.
In a mixed cluster if the request lands on 2.4 version nodes will it fail with serialisation/deserialisation?
There was a problem hiding this comment.
Can we add a check to read these params only if OpenSearch version is 2.5 and above else there is a possibility that mixed version cluster tests will fail with serde issues. We might want to do the same in main as well.
Gradle Check (Jenkins) Run Completed with:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport PR for weighted routing changes
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.