Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding query fuzziness validation #5805

Merged
merged 14 commits into from
Mar 8, 2023
Merged

Adding query fuzziness validation #5805

merged 14 commits into from
Mar 8, 2023

Conversation

sejli
Copy link
Contributor

@sejli sejli commented Jan 10, 2023 •
edited

Description

Validates fuzziness query and returns error message on invalid fuzziness values

Issues Resolved

#4223

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@sejli
Adding fuzziness validation
0da6a50 
Signed-off-by: Sean Li <lnse@amazon.com>
@sejli
Merge branch 'opensearch-project:main' into fuzziness_validation
35e6cf8
@sejli
Updating imports
b4dd2af 
Signed-off-by: Sean Li <lnse@amazon.com>
@sejli
Adding fuzziness validation
bb8f47a 
Signed-off-by: Sean Li <lnse@amazon.com>
@sejli
Updating imports
96481e9 
Signed-off-by: Sean Li <lnse@amazon.com>
@sejli
removing comments
9dca8bc 
Signed-off-by: Sean Li <lnse@amazon.com>
@sejli
removing comments
9f5e9a8 
Signed-off-by: Sean Li <lnse@amazon.com>
@sejli
running spotlessApply
65d26d3 
Signed-off-by: Sean Li <lnse@amazon.com>
@sejli
resolving reviews
8542176 
Signed-off-by: Sean Li <lnse@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

noCharger
noCharger reviewed Jan 11, 2023
View reviewed changes
server/src/main/java/org/opensearch/common/unit/Fuzziness.java Outdated
@@ -189,7 +189,13 @@ public static Fuzziness parse(XContentParser parser) throws IOException {
return build(fuzziness);
}
} catch (NumberFormatException ex) {
return build(fuzziness);
// Validating if the inputted Fuzziness value is a float. If not, it is an invalid string.
Copy link
Contributor

@noCharger noCharger Jan 11, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

non blocking comment -
'Validate if the fuzziness is formatted correctly as a numeric value.'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressed in 4409f99

noCharger
noCharger approved these changes Jan 11, 2023
View reviewed changes
Copy link
Contributor

@noCharger noCharger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with one nit comment

@sejli
revising comment
4409f99 
Signed-off-by: Sean Li <lnse@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@sejli
Merging from upstream/main
ff43555 
Signed-off-by: Sean Li <lnse@amazon.com>
@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2023

Gradle Check (Jenkins) Run Completed with:

@sejli
updating CHANGELOG.md
cae5ac1 
Signed-off-by: Sean Li <lnse@amazon.com>
@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2023

Gradle Check (Jenkins) Run Completed with:

@codecov-commenter
Copy link

codecov-commenter commented Mar 8, 2023 •
edited

Codecov Report

Merging #5805 (2980409) into main (8c0e5d0) will decrease coverage by 0.11%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##               main    #5805      +/-   ##
============================================
- Coverage     70.77%   70.67%   -0.11%     
+ Complexity    59125    59068      -57     
============================================
  Files          4804     4804              
  Lines        283098   283101       +3     
  Branches      40813    40813              
============================================
- Hits         200372   200077     -295     
- Misses        66269    66623     +354     
+ Partials      16457    16401      -56
Impacted Files Coverage Δ
...ain/java/org/opensearch/common/unit/Fuzziness.java 85.00% <100.00%> (+0.46%) ⬆️
...adonly/AddIndexBlockClusterStateUpdateRequest.java 0.00% <0.00%> (-75.00%) ⬇️
...readonly/TransportVerifyShardIndexBlockAction.java 9.75% <0.00%> (-73.18%) ⬇️
...n/admin/indices/readonly/AddIndexBlockRequest.java 17.85% <0.00%> (-53.58%) ⬇️
.../java/org/opensearch/node/NodeClosedException.java 50.00% <0.00%> (-50.00%) ⬇️
...ava/org/opensearch/action/NoSuchNodeException.java 0.00% <0.00%> (-50.00%) ⬇️
...a/org/opensearch/tasks/TaskCancelledException.java 50.00% <0.00%> (-50.00%) ⬇️
.../opensearch/client/indices/CloseIndexResponse.java 42.50% <0.00%> (-48.75%) ⬇️
...opensearch/persistent/PersistentTasksExecutor.java 22.22% <0.00%> (-44.45%) ⬇️
...adcast/BroadcastShardOperationFailedException.java 55.55% <0.00%> (-44.45%) ⬇️
... and 492 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

reta
reta reviewed Mar 8, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@sejli
moving fix to 2.x in CHANGELOG.md
2980409 
Signed-off-by: Sean Li <lnse@amazon.com>
@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2023

Gradle Check (Jenkins) Run Completed with:

@reta reta merged commit add1871 into opensearch-project:main Mar 8, 2023
@reta reta added bug Something isn't working backport 2.x Backport to 2.x branch labels Mar 8, 2023
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Mar 8, 2023
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 8, 2023
@github-actions
Adding query fuzziness validation (#5805)
5c5e54b 
* Adding fuzziness validation

Signed-off-by: Sean Li <lnse@amazon.com>

* Updating imports

Signed-off-by: Sean Li <lnse@amazon.com>

* Adding fuzziness validation

Signed-off-by: Sean Li <lnse@amazon.com>

* Updating imports

Signed-off-by: Sean Li <lnse@amazon.com>

* removing comments

Signed-off-by: Sean Li <lnse@amazon.com>

* running spotlessApply

Signed-off-by: Sean Li <lnse@amazon.com>

* updating CHANGELOG.md

Signed-off-by: Sean Li <lnse@amazon.com>

* resolving reviews

Signed-off-by: Sean Li <lnse@amazon.com>

* revising comment

Signed-off-by: Sean Li <lnse@amazon.com>

* updating CHANGELOG.md

Signed-off-by: Sean Li <lnse@amazon.com>

* moving fix to 2.x in CHANGELOG.md

Signed-off-by: Sean Li <lnse@amazon.com>

---------

Signed-off-by: Sean Li <lnse@amazon.com>
(cherry picked from commit add1871)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
reta pushed a commit that referenced this pull request Mar 9, 2023
@opensearch-trigger-bot @github-actions
Adding query fuzziness validation (#5805) (#6590)
d9d1dc8 
* Adding fuzziness validation



* Updating imports



* Adding fuzziness validation



* Updating imports



* removing comments



* running spotlessApply



* updating CHANGELOG.md



* resolving reviews



* revising comment



* updating CHANGELOG.md



* moving fix to 2.x in CHANGELOG.md



---------


(cherry picked from commit add1871)

Signed-off-by: Sean Li <lnse@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This was referenced Mar 9, 2023
Closed
Closed
mingshl pushed a commit to mingshl/OpenSearch-Mingshl that referenced this pull request Mar 24, 2023
@sejli @mingshl
Adding query fuzziness validation (opensearch-project#5805)
92a95da 
* Adding fuzziness validation

Signed-off-by: Sean Li <lnse@amazon.com>

* Updating imports

Signed-off-by: Sean Li <lnse@amazon.com>

* Adding fuzziness validation

Signed-off-by: Sean Li <lnse@amazon.com>

* Updating imports

Signed-off-by: Sean Li <lnse@amazon.com>

* removing comments

Signed-off-by: Sean Li <lnse@amazon.com>

* running spotlessApply

Signed-off-by: Sean Li <lnse@amazon.com>

* updating CHANGELOG.md

Signed-off-by: Sean Li <lnse@amazon.com>

* resolving reviews

Signed-off-by: Sean Li <lnse@amazon.com>

* revising comment

Signed-off-by: Sean Li <lnse@amazon.com>

* updating CHANGELOG.md

Signed-off-by: Sean Li <lnse@amazon.com>

* moving fix to 2.x in CHANGELOG.md

Signed-off-by: Sean Li <lnse@amazon.com>

---------

Signed-off-by: Sean Li <lnse@amazon.com>
Signed-off-by: Mingshi Liu <mingshl@amazon.com>
@sejli sejli mentioned this pull request Apr 14, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reta reta reta approved these changes

@noCharger noCharger noCharger approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@setiah setiah Awaiting requested review from setiah

@kartg kartg Awaiting requested review from kartg

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@adnapibar adnapibar Awaiting requested review from adnapibar

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@ryanbogan ryanbogan Awaiting requested review from ryanbogan

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89 dreamer-89 is a code owner

@tlfeng tlfeng Awaiting requested review from tlfeng tlfeng is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

@xuezhou25 xuezhou25 Awaiting requested review from xuezhou25

Assignees
No one assigned
Labels
backport 2.x Backport to 2.x branch bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sejli @reta @codecov-commenter @noCharger