[Refactor] core.common to new opensearch-common library

[nknize]

Refactors all of o.opensearch.common classes in the core library to a new opensearch-commons library (inspired by apache commons). The intent is to refactor any o.opensearch.common.* classes in :server module to this new library. This will be done with care such that the dependencies are carefully managed to avoid any cyclic or unnecessarily complicated dependencies.

relates #5910

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/9778/
• CommitID: 15148ea
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/9779/
• CommitID: 6bc66bb
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/9782/
• CommitID: 45d59c8
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[reta]

@nknize I am a bit lost now, I thought that #5902 concluded we don't want/need to have opensearch-commons, the opensearch-core should the one? Also, those 2 always go together, this is what every build.gradle now has:

  api project(':libs:opensearch-commons')
  api project(':libs:opensearch-core')

Is the opensearch-commons is useful by itself?

On a slightly different subject, it seems like the convention for other modules in OpenSearch is to use common (not commons) suffix: analysis-common, ingest-common, ...

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/9785/
• CommitID: cdd7209
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/10103/
• CommitID: fa23acc
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: SUCCESS ✅
• URL: https://build.ci.opensearch.org/job/gradle-check/10105/
• CommitID: fa23acc

[codecov-commenter]

Codecov Report

Merging #5976 (8e15b58) into main (78d0d96) will increase coverage by 0.00%.
The diff coverage is 0.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff            @@
##               main    #5976   +/-   ##
=========================================
  Coverage     70.89%   70.90%           
+ Complexity    58839    58816   -23     
=========================================
  Files          4775     4775           
  Lines        280993   280993           
  Branches      40590    40590           
=========================================
+ Hits         199224   199230    +6     
+ Misses        65436    65383   -53     
- Partials      16333    16380   +47     

Impacted Files	Coverage Δ
...earch/gradle/precommit/JarHellPrecommitPlugin.java	31.25% <0.00%> (ø)
...rc/main/java/org/opensearch/bootstrap/JarHell.java	77.00% <ø> (ø)
...java/org/opensearch/bootstrap/JdkJarHellCheck.java	0.00% <ø> (ø)
.../src/main/java/org/opensearch/common/Booleans.java	59.32% <ø> (ø)
...rc/main/java/org/opensearch/common/CharArrays.java	56.00% <ø> (ø)
...mmon/src/main/java/org/opensearch/common/Glob.java	37.50% <ø> (ø)
...n/java/org/opensearch/common/MemoizedSupplier.java	100.00% <ø> (ø)
...n/src/main/java/org/opensearch/common/SetOnce.java	100.00% <ø> (ø)
.../main/java/org/opensearch/common/collect/List.java	83.33% <ø> (ø)
...c/main/java/org/opensearch/common/collect/Map.java	93.33% <ø> (ø)
... and 477 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[reta]

Could we do that since 3.0.0 has JDK-11 baseline?

[nknize]

Yes. I was planning it in a follow up PR.

[reta]

I think LGTM, @andrross what do you think? A side note, @nknize could you please update #5910, I believe the presence of opensearch-common is more or less justified, but not formalized, thank you.

[nknize]

...could you please update #5910

Done.

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: TIMEOUT ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/10241/
• CommitID: 8e15b58
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[andrross]

This is a nitpick, but I think this is a bit of an abuse of the @opensearch.internal annotation. This was clearly meant to be a public utility just like anything else in the common namespace. It just has been superseded by an alternative, which is exactly what the java.lang.Deprecated annotation is meant to convey.

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: SUCCESS ✅
• URL: https://build.ci.opensearch.org/job/gradle-check/10265/
• CommitID: 8e15b58