[Backport 2.x] Enable numeric sort optimisation for few numerical sort types #6330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
This commit restores the sort optimization to use BKD to skip non-competitive docs for numeric types whose BYTES size match between the BKD leaf and doc values encoding. For now this is only LONG, DOUBLE, DATE, and DATE_NANOSECONDS as the remaining NumericTypes use 64bit docvalue encoding while the BKD uses smaller byte encoded space. This also updates the QueryPhase to remove the long time unnecessary in order doc id check and minDoc boolean query for skipping non-competitive docs that is handled by all Lucene 7.0+ sorted indexes. Existing tests are updated. Signed-off-by: Nicholas Walter Knize <nknize@apache.org> Signed-off-by: gashutos <gashutos@amazon.com> Co-authored-by: Nicholas Walter Knize <nknize@apache.org> Co-authored-by: Chaitanya Gohel <gashutos@amazon.com> (cherry picked from commit 6bb9e3e) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
requested review from
reta,
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
gbbafna,
setiah,
kartg,
kotwanikunal,
mch2,
nknize,
owaiskazi19,
adnapibar,
Rishikesh1159,
ryanbogan,
saratvemulapalli,
shwetathareja,
dreamer-89,
tlfeng,
VachaShah and
xuezhou25
as code owners
andrross
approved these changes
Feb 15, 2023
nknize
approved these changes
Feb 15, 2023
Gradle Check (Jenkins) Run Completed with:
|
nknize
added
Performance
|
Do we want to backport this as a bugfix for all 2.x releases? |
I vote no because 2.6 is only a couple weeks out now so a 2.5.1 patch release seems unlikely, and we'd want to keep such a patch release lean anyway to address critical issues without introducing new problems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 6bb9e3e from #6321.