fix compiler warning and base blob path case for searchable snapshots

[samuel-oci]

Description

Fixing base blob path scenario for searchable snapshots

1. Adding base blob path configuration for FS directory
2. Add base blob path scenario in searchable snapshot tests and fix bug
3. Fix compiler warnings

Issues Resolved

Closes #6557

Check List

• New functionality includes testing.
  • All tests pass
• New functionality has been documented.
  • [] New functionality has javadoc added
• Commits are signed per the DCO using --signoff
• Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/12043/
• CommitID: 20bd290
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[kotwanikunal]

@samuel-oci Thanks for the contribution.
Can you please run ./gradlew spotlessApply to fix spotless errors and ./gradlew precommit to validate other checks?

More on that here.

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: UNSTABLE ❕
• TEST FAILURES:

      1 org.opensearch.smoketest.SmokeTestMultiNodeClientYamlTestSuiteIT.test {yaml=pit/10_basic/Delete all}
      1 org.opensearch.cluster.routing.allocation.decider.DiskThresholdDeciderIT.testIndexCreateBlockIsRemovedWhenAnyNodesNotExceedHighWatermarkWithAutoReleaseEnabled
      1 org.opensearch.cluster.allocation.AwarenessAllocationIT.testThreeZoneOneReplicaWithForceZoneValueAndLoadAwareness

• URL: https://build.ci.opensearch.org/job/gradle-check/12048/
• CommitID: 710ec2c
  Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: UNSTABLE ❕
• TEST FAILURES:

      1 org.opensearch.search.SearchWeightedRoutingIT.testSearchAggregationWithNetworkDisruption_FailOpenEnabled

• URL: https://build.ci.opensearch.org/job/gradle-check/12049/
• CommitID: 90ed8ff
  Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[samuel-oci]

@samuel-oci Thanks for the contribution. Can you please run ./gradlew spotlessApply to fix spotless errors and ./gradlew precommit to validate other checks?

More on that here.

Hi @kotwanikunal thanks for the feedback, done.
I do notice that there are some flakey IT tests that are not related to this change, but the gradle check seems to be passing.
Let me know if anything else is needed.

[kotwanikunal]

@samuel-oci This LGTM!
@andrross Can you please have a look as well?

[andrross]

Looks great, thanks @samuel-oci!

I actually think it makes sense to add a changelog entry here for "Add 'base_path' setting to File System Repository" since this is a user-facing feature. @kotwanikunal what do you think?

[andrross]

Just an FYI, if you've been getting javadoc warnings/failures in the tests, it might be due to building with JDK 14. The javadoc rules are supposed to be ignored for tests, but JDK-14 doesn't seem to do the right thing, though it has been end-of-life for quite awhile now.

[kotwanikunal]

Looks great, thanks @samuel-oci!

I actually think it makes sense to add a changelog entry here for "Add 'base_path' setting to File System Repository" since this is a user-facing feature. @kotwanikunal what do you think?

Ahh. Yep. I think since we have a new setting for FsRepository, an entry makes sense.
@samuel-oci You can follow the CHANGELOG guide here - https://github.com/opensearch-project/OpenSearch/blob/main/CONTRIBUTING.md#changelog
Please add an entry into the Unreleased 2.x section since this will be backported to 2.x

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/12095/
• CommitID: 94e3be3
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[kotwanikunal]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/12095/
• CommitID: 94e3be3
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

Unrelated failure due to heap space usage.

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: SUCCESS ✅
• URL: https://build.ci.opensearch.org/job/gradle-check/12098/
• CommitID: 94e3be3

[samuel-oci]

Thanks for your comments @kotwanikunal @andrross , added a CHANGELOG entry.

[opensearch-trigger-bot]

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-6558-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 8c0e5d0c680f51ecea82468c622508bda510cc26
# Push it to GitHub
git push --set-upstream origin backport/backport-6558-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-6558-to-2.x.

[opensearch-trigger-bot]

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-6558-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 8c0e5d0c680f51ecea82468c622508bda510cc26
# Push it to GitHub
git push --set-upstream origin backport/backport-6558-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-6558-to-2.x.

[kotwanikunal]

Backport: #6584