New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SegRep with Remote: Add hook for publishing checkpoint notifications after segment upload to remote store #7394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankitkala
requested review from
reta,
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
gbbafna,
setiah,
kartg,
kotwanikunal,
mch2,
nknize,
owaiskazi19,
Rishikesh1159,
ryanbogan,
saratvemulapalli,
shwetathareja,
dreamer-89,
tlfeng and
VachaShah
as code owners
May 3, 2023 15:08
Gradle Check (Jenkins) Run Completed with:
|
mch2
reviewed
May 3, 2023
server/src/main/java/org/opensearch/common/util/FeatureFlags.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/index/shard/RemoteStoreSegmentUploadNotifier.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/index/shard/CheckpointRefreshListener.java
Outdated
Show resolved
Hide resolved
ashking94
reviewed
May 4, 2023
server/src/main/java/org/opensearch/index/shard/RemoteStoreRefreshListener.java
Outdated
Show resolved
Hide resolved
ankitkala
force-pushed
the
remote_upload_hook
branch
2 times, most recently
from
May 11, 2023 12:14
1067906
to
511b605
Compare
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #7394 +/- ##
============================================
+ Coverage 70.47% 70.57% +0.09%
+ Complexity 59728 59726 -2
============================================
Files 4896 4896
Lines 286798 286807 +9
Branches 41331 41335 +4
============================================
+ Hits 202133 202417 +284
+ Misses 68078 67724 -354
- Partials 16587 16666 +79
|
…after segment upload to remote store Signed-off-by: Ankit Kala <ankikala@amazon.com>
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
mch2
reviewed
May 12, 2023
server/src/main/java/org/opensearch/index/shard/RemoteStoreRefreshListener.java
Outdated
Show resolved
Hide resolved
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Ankit Kala <ankikala@amazon.com>
ankitkala
force-pushed
the
remote_upload_hook
branch
from
May 15, 2023 09:40
cfc7f4c
to
e2b1a3b
Compare
Gradle Check (Jenkins) Run Completed with:
|
sachinpkale
reviewed
May 15, 2023
server/src/main/java/org/opensearch/index/shard/RemoteStoreRefreshListener.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/index/shard/RemoteStoreRefreshListener.java
Show resolved
Hide resolved
server/src/main/java/org/opensearch/indices/IndicesService.java
Outdated
Show resolved
Hide resolved
server/src/test/java/org/opensearch/index/shard/RemoteStoreRefreshListenerTests.java
Show resolved
Hide resolved
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Ankit Kala <ankikala@amazon.com>
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Ankit Kala <ankikala@amazon.com>
Bukhtawar
reviewed
May 15, 2023
Gradle Check (Jenkins) Run Completed with:
|
Bukhtawar
reviewed
May 15, 2023
Signed-off-by: Ankit Kala <ankikala@amazon.com>
Gradle Check (Jenkins) Run Completed with:
|
mch2
approved these changes
May 15, 2023
ashking94
pushed a commit
to ashking94/OpenSearch
that referenced
this pull request
May 23, 2023
…after segment upload to remote store (opensearch-project#7394) * SegRep with Remote: Add hook for publishing checkpoint notifications after segment upload to remote store Signed-off-by: Ankit Kala <ankikala@amazon.com> * Added changelog Signed-off-by: Ankit Kala <ankikala@amazon.com> * Fix the test Signed-off-by: Ankit Kala <ankikala@amazon.com> * gradle check Signed-off-by: Ankit Kala <ankikala@amazon.com> * Addressed PR comments Signed-off-by: Ankit Kala <ankikala@amazon.com> * Addressing PR comments 2 Signed-off-by: Ankit Kala <ankikala@amazon.com> * Addressed comments 3 Signed-off-by: Ankit Kala <ankikala@amazon.com> * Fix Changelog entry Signed-off-by: Ankit Kala <ankikala@amazon.com> --------- Signed-off-by: Ankit Kala <ankikala@amazon.com> Signed-off-by: Ashish Singh <ssashish@amazon.com>
ashking94
pushed a commit
to ashking94/OpenSearch
that referenced
this pull request
May 24, 2023
…after segment upload to remote store (opensearch-project#7394) * SegRep with Remote: Add hook for publishing checkpoint notifications after segment upload to remote store Signed-off-by: Ankit Kala <ankikala@amazon.com> * Added changelog Signed-off-by: Ankit Kala <ankikala@amazon.com> * Fix the test Signed-off-by: Ankit Kala <ankikala@amazon.com> * gradle check Signed-off-by: Ankit Kala <ankikala@amazon.com> * Addressed PR comments Signed-off-by: Ankit Kala <ankikala@amazon.com> * Addressing PR comments 2 Signed-off-by: Ankit Kala <ankikala@amazon.com> * Addressed comments 3 Signed-off-by: Ankit Kala <ankikala@amazon.com> * Fix Changelog entry Signed-off-by: Ankit Kala <ankikala@amazon.com> --------- Signed-off-by: Ankit Kala <ankikala@amazon.com> Signed-off-by: Ashish Singh <ssashish@amazon.com>
6 tasks
ankitkala
added a commit
to ankitkala/OpenSearch
that referenced
this pull request
May 31, 2023
…cations after segment upload to remote store (opensearch-project#7394) (opensearch-project#7718)" This reverts commit 92571b7. Signed-off-by: Ankit Kala <ankikala@amazon.com>
ankitkala
added a commit
to ankitkala/OpenSearch
that referenced
this pull request
May 31, 2023
…cations after segment upload to remote store (opensearch-project#7394) (opensearch-project#7718)" This reverts commit 92571b7. Signed-off-by: Ankit Kala <ankikala@amazon.com>
6 tasks
ankitkala
added a commit
to ankitkala/OpenSearch
that referenced
this pull request
May 31, 2023
…cations after segment upload to remote store (opensearch-project#7394) (opensearch-project#7718)" This reverts commit 92571b7. Signed-off-by: Ankit Kala <ankikala@amazon.com>
dreamer-89
pushed a commit
that referenced
this pull request
May 31, 2023
scrawfor99
pushed a commit
to scrawfor99/OpenSearch
that referenced
this pull request
May 31, 2023
…after segment upload to remote store (opensearch-project#7394) * SegRep with Remote: Add hook for publishing checkpoint notifications after segment upload to remote store Signed-off-by: Ankit Kala <ankikala@amazon.com> * Added changelog Signed-off-by: Ankit Kala <ankikala@amazon.com> * Fix the test Signed-off-by: Ankit Kala <ankikala@amazon.com> * gradle check Signed-off-by: Ankit Kala <ankikala@amazon.com> * Addressed PR comments Signed-off-by: Ankit Kala <ankikala@amazon.com> * Addressing PR comments 2 Signed-off-by: Ankit Kala <ankikala@amazon.com> * Addressed comments 3 Signed-off-by: Ankit Kala <ankikala@amazon.com> * Fix Changelog entry Signed-off-by: Ankit Kala <ankikala@amazon.com> --------- Signed-off-by: Ankit Kala <ankikala@amazon.com>
shiv0408
pushed a commit
to Gaurav614/OpenSearch
that referenced
this pull request
Apr 25, 2024
…after segment upload to remote store (opensearch-project#7394) * SegRep with Remote: Add hook for publishing checkpoint notifications after segment upload to remote store Signed-off-by: Ankit Kala <ankikala@amazon.com> * Added changelog Signed-off-by: Ankit Kala <ankikala@amazon.com> * Fix the test Signed-off-by: Ankit Kala <ankikala@amazon.com> * gradle check Signed-off-by: Ankit Kala <ankikala@amazon.com> * Addressed PR comments Signed-off-by: Ankit Kala <ankikala@amazon.com> * Addressing PR comments 2 Signed-off-by: Ankit Kala <ankikala@amazon.com> * Addressed comments 3 Signed-off-by: Ankit Kala <ankikala@amazon.com> * Fix Changelog entry Signed-off-by: Ankit Kala <ankikala@amazon.com> --------- Signed-off-by: Ankit Kala <ankikala@amazon.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change adds a hook to publish the notification to replicas when a segments are uploaded to the remote store.
This change also gates this behind a new feature flag for Segment Replication with remote store..
Related Issues
#5578
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.