Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Task cancellation monitoring service #8046

Merged

Conversation

sgup432
Copy link
Contributor

@sgup432 sgup432 commented Jun 13, 2023

Description

[Describe what this change achieves]
Backport #7642

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

sgup432 and others added 2 commits June 13, 2023 12:06
* Task cancellation monitoring service 

Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com>
Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.remotestore.SegmentReplicationUsingRemoteStoreIT.testDropPrimaryDuringReplication

@sgup432
Copy link
Contributor Author

sgup432 commented Jun 13, 2023

@andrross @dblock @Bukhtawar Can you help merging this backport PR? I will then proceed to create a similar PR in main t change version check.

@codecov
Copy link

codecov bot commented Jun 13, 2023

Codecov Report

Merging #8046 (fba9812) into 2.x (2b83949) will increase coverage by 0.10%.
The diff coverage is 84.24%.

@@             Coverage Diff              @@
##                2.x    #8046      +/-   ##
============================================
+ Coverage     70.61%   70.71%   +0.10%     
- Complexity    56704    56801      +97     
============================================
  Files          4697     4701       +4     
  Lines        268539   268701     +162     
  Branches      39714    39724      +10     
============================================
+ Hits         189622   190008     +386     
+ Misses        62594    62370     -224     
  Partials      16323    16323              
Impacted Files Coverage Δ
...min/cluster/stats/TransportClusterStatsAction.java 70.83% <ø> (ø)
...rg/opensearch/common/settings/ClusterSettings.java 92.85% <ø> (ø)
...rch/action/admin/cluster/node/stats/NodeStats.java 48.36% <33.33%> (-0.78%) ⬇️
...src/main/java/org/opensearch/node/NodeService.java 74.39% <50.00%> (-0.30%) ⬇️
...search/tasks/SearchShardTaskCancellationStats.java 77.27% <77.27%> (ø)
...rc/main/java/org/opensearch/tasks/TaskManager.java 66.66% <80.95%> (+0.91%) ⬆️
...va/org/opensearch/tasks/TaskCancellationStats.java 82.35% <82.35%> (ø)
...earch/tasks/TaskCancellationMonitoringService.java 90.32% <90.32%> (ø)
...on/admin/cluster/node/stats/NodesStatsRequest.java 69.00% <100.00%> (+0.31%) ⬆️
.../cluster/node/stats/TransportNodesStatsAction.java 100.00% <100.00%> (ø)
... and 2 more

... and 485 files with indirect coverage changes

@kotwanikunal kotwanikunal changed the title Backport/backport 7642 to 2.x [Backport 2.x] Task cancellation monitoring service Jun 13, 2023
Copy link
Collaborator

@Bukhtawar Bukhtawar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might need to update main with 2.9 as well

@Bukhtawar Bukhtawar merged commit 2673f84 into opensearch-project:2.x Jun 14, 2023
29 checks passed
@sgup432
Copy link
Contributor Author

sgup432 commented Jun 14, 2023

We might need to update main with 2.9 as well

@Bukhtawar Yes. I have raised a new PR for that - #8069

gaiksaya pushed a commit to gaiksaya/OpenSearch that referenced this pull request Jun 26, 2023
…ct#8046)

* Task cancellation monitoring service (opensearch-project#7642)

Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants