Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport-1.3] Fix mapping char_filter when mapping a hashtag (#7591) #8121

Merged
merged 1 commit into from
Jun 19, 2023
Merged

[Backport-1.3] Fix mapping char_filter when mapping a hashtag (#7591) #8121

merged 1 commit into from
Jun 19, 2023

Conversation

nathanmyles
Copy link
Contributor

Signed-off-by: Nathan Myles myles.n.a@gmail.com

Issue: #7308
(cherry picked from commit e049338)

@nathanmyles
Fix mapping char_filter when mapping a hashtag (opensearch-project#7591)
d789d8a 
Signed-off-by: Nathan Myles <myles.n.a@gmail.com>

Issue: opensearch-project#7308
(cherry picked from commit e049338)
@nathanmyles
Copy link
Contributor Author

Backports: #7591

@nathanmyles nathanmyles mentioned this pull request Jun 16, 2023
Merged
6 tasks
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov
Copy link

codecov bot commented Jun 16, 2023

Codecov Report

Merging #8121 (d789d8a) into 1.3 (6da7445) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##                1.3    #8121   +/-   ##
=========================================
  Coverage     77.58%   77.59%           
- Complexity    58750    58768   +18     
=========================================
  Files          4223     4223           
  Lines        253435   253437    +2     
  Branches      38705    38705           
=========================================
+ Hits         196638   196651   +13     
- Misses        40798    40820   +22     
+ Partials      15999    15966   -33
Impacted Files Coverage Δ
...arch/analysis/common/MappingCharFilterFactory.java 50.00% <100.00%> (ø)
...n/java/org/opensearch/index/analysis/Analysis.java 84.89% <100.00%> (+0.22%) ⬆️

... and 451 files with indirect coverage changes

@owaiskazi19 owaiskazi19 changed the title Fix mapping char_filter when mapping a hashtag (#7591) [Backport-1.3] Fix mapping char_filter when mapping a hashtag (#7591) Jun 19, 2023
@kartg kartg merged commit 73b36ae into opensearch-project:1.3 Jun 19, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@owaiskazi19 owaiskazi19 owaiskazi19 left review comments

@kartg kartg kartg approved these changes

@reta reta Awaiting requested review from reta reta is a code owner

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@setiah setiah Awaiting requested review from setiah

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@ryanbogan ryanbogan Awaiting requested review from ryanbogan

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89 dreamer-89 is a code owner

@tlfeng tlfeng Awaiting requested review from tlfeng tlfeng is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nathanmyles @owaiskazi19 @kotwanikunal @kartg