Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mapping char_filter when mapping a hashtag (#7591) #8147

Merged

Conversation

nathanmyles
Copy link
Contributor

Signed-off-by: Nathan Myles myles.n.a@gmail.com

Issue: #7308 (cherry picked from commit e049338)

Signed-off-by: Nathan Myles <myles.n.a@gmail.com>

Issue: opensearch-project#7308
(cherry picked from commit e049338)
@nathanmyles
Copy link
Contributor Author

Backports: #7591

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@kartg
Copy link
Member

kartg commented Jun 19, 2023

Tests with failures:
 - org.opensearch.cluster.routing.MovePrimaryFirstTests.testClusterGreenAfterPartialRelocation
 - org.opensearch.cluster.routing.MovePrimaryFirstTests.classMethod

This has cropped up in a some other 1.x backports - #8124 (comment)

It seems related to an old flaky test (#1957). A fix for this seems to have merged in - #2265 - but the test remains flaky on this branch. I'll refire Gradle check.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov
Copy link

codecov bot commented Jun 19, 2023

Codecov Report

Merging #8147 (61556de) into 1.x (a191f3d) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                1.x    #8147      +/-   ##
============================================
- Coverage     77.62%   77.61%   -0.02%     
+ Complexity    58808    58783      -25     
============================================
  Files          4223     4223              
  Lines        253545   253547       +2     
  Branches      38714    38714              
============================================
- Hits         196818   196786      -32     
- Misses        40715    40771      +56     
+ Partials      16012    15990      -22     
Impacted Files Coverage Δ
...arch/analysis/common/MappingCharFilterFactory.java 50.00% <100.00%> (ø)
...n/java/org/opensearch/index/analysis/Analysis.java 84.89% <100.00%> (+0.22%) ⬆️

... and 449 files with indirect coverage changes

@kartg kartg merged commit 420a63c into opensearch-project:1.x Jun 19, 2023
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants