Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump resteasy-jackson2-provider from 3.0.26.Final to 6.2.4.Final in /qa/wildfly #8209

Merged
merged 2 commits into from Jun 27, 2023

Conversation

Xtansia
Copy link
Contributor

@Xtansia Xtansia commented Jun 21, 2023

Description

Bumps resteasy-jackson2-provider in /qa/wildfly along with all the associated required dependencies.

Related Issues

Supersedes #8166

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.repositories.azure.AzureBlobStoreRepositoryTests.testReadNonExistingPath
      1 org.opensearch.indices.DateMathIndexExpressionsIntegrationIT.testIndexNameDateMathExpressions
      1 org.opensearch.index.shard.IndexShardIT.testIndexCanChangeCustomDataPath

@codecov
Copy link

codecov bot commented Jun 22, 2023

Codecov Report

Merging #8209 (04123a1) into main (0c7ba94) will increase coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #8209      +/-   ##
============================================
+ Coverage     70.96%   70.99%   +0.03%     
- Complexity    56780    56791      +11     
============================================
  Files          4733     4733              
  Lines        268140   268139       -1     
  Branches      39287    39287              
============================================
+ Hits         190285   190374      +89     
+ Misses        61816    61694     -122     
- Partials      16039    16071      +32     
Impacted Files Coverage Δ
...in/java/org/opensearch/wildfly/model/Employee.java 0.00% <ø> (ø)
...ildfly/transport/RestHighLevelClientActivator.java 0.00% <ø> (ø)
...transport/RestHighLevelClientEmployeeResource.java 0.00% <ø> (ø)
...wildfly/transport/RestHighLevelClientProducer.java 0.00% <ø> (ø)
...ly/transport/RestHighLevelJacksonJsonProvider.java 0.00% <ø> (ø)

... and 431 files with indirect coverage changes

@Xtansia Xtansia added dependencies Pull requests that update a dependency file backport 2.x Backport to 2.x branch labels Jun 22, 2023
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@scrawfor99
Copy link
Contributor

scrawfor99 commented Jun 23, 2023

This is just the runner acting up. If a maintainer can restart the action it should pass and this can get merged.

@owaiskazi19, @reta would either of you be able to restart this? Thanks.

@kotwanikunal
Copy link
Member

@Xtansia Can you please rebase?

… /qa/wildfly

Signed-off-by: Thomas Farr <tsfarr@amazon.com>
@Xtansia
Copy link
Contributor Author

Xtansia commented Jun 26, 2023

@kotwanikunal Have rebased

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Signed-off-by: Thomas Farr <tsfarr@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.snapshots.DedicatedClusterSnapshotRestoreIT.testIndexDeletionDuringSnapshotCreationInQueue
      1 org.opensearch.remotestore.SegmentReplicationUsingRemoteStoreIT.testNodeDropWithOngoingReplication
      1 org.opensearch.cluster.allocation.AwarenessAllocationIT.testThreeZoneOneReplicaWithForceZoneValueAndLoadAwareness

@reta
Copy link
Collaborator

reta commented Jun 27, 2023

@Xtansia I see the following error in logs (it does not cause test failures):

2023-06-27 10:15:05,272 TEST-WildflyIT.testRestClient-seed#[B3296C2D4B70ACF8] ERROR Unable to locate plugin type for HeaderWarningAppender
2023-06-27 10:15:05,343 TEST-WildflyIT.testRestClient-seed#[B3296C2D4B70ACF8] ERROR Unable to locate plugin for HeaderWarningAppender
2023-06-27 10:15:05,344 TEST-WildflyIT.testRestClient-seed#[B3296C2D4B70ACF8] ERROR Unable to invoke factory method in class org.apache.logging.log4j.core.config.AppendersPlugin for element Appenders: java.lang.NullPointerException: Cannot invoke "org.apache.logging.log4j.core.config.plugins.util.PluginType.getElementName()" because "childType" is null java.lang.NullPointerException: Cannot invoke "org.apache.logging.log4j.core.config.plugins.util.PluginType.getElementName()" because "childType" is null
	at org.apache.logging.log4j.core.config.plugins.visitors.PluginElementVisitor.visit(PluginElementVisitor.java:52)
	at org.apache.logging.log4j.core.config.plugins.util.PluginBuilder.generateParameters(PluginBuilder.java:262)
	at org.apache.logging.log4j.core.config.plugins.util.PluginBuilder.build(PluginBuilder.java:135)
	at org.apache.logging.log4j.core.config.AbstractConfiguration.createPluginObject(AbstractConfiguration.java:1120)
	at org.apache.logging.log4j.core.config.AbstractConfiguration.createConfiguration(AbstractConfiguration.java:1045)
	at org.apache.logging.log4j.core.config.AbstractConfiguration.doConfigure(AbstractConfiguration.java:651)
	at org.apache.logging.log4j.core.config.AbstractConfiguration.initialize(AbstractConfiguration.java:247)
	at org.apache.logging.log4j.core.config.AbstractConfiguration.start(AbstractConfiguration.java:293)
	at org.apache.logging.log4j.core.LoggerContext.setConfiguration(LoggerContext.java:626)
	at org.apache.logging.log4j.core.LoggerContext.reconfigure(LoggerContext.java:699)
	at org.apache.logging.log4j.core.LoggerContext.reconfigure(LoggerContext.java:716)
	at org.apache.logging.log4j.core.LoggerContext.start(LoggerContext.java:270)
	at org.apache.logging.log4j.core.impl.Log4jContextFactory.getContext(Log4jContextFactory.java:155)
	at org.apache.logging.log4j.core.impl.Log4jContextFactory.getContext(Log4jContextFactory.java:47)
	at org.apache.logging.log4j.LogManager.getContext(LogManager.java:196)
	at org.apache.logging.log4j.LogManager.getLogger(LogManager.java:599)
	at org.opensearch.wildfly.WildflyIT.<init>(WildflyIT.java:67)
	at java.base/jdk.internal.reflect.DirectConstructorHandleAccessor.newInstance(DirectConstructorHandleAccessor.java:67)
	at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:500)
	at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:484)
	at com.carrotsearch.randomizedtesting.RandomizedRunner$NewInstanceProvider.newInstance(RandomizedRunner.java:1580)
	at com.carrotsearch.randomizedtesting.RandomizedRunner.runSingleTest(RandomizedRunner.java:933)
	at com.carrotsearch.randomizedtesting.RandomizedRunner$5.evaluate(RandomizedRunner.java:832)
	at com.carrotsearch.randomizedtesting.RandomizedRunner$6.evaluate(RandomizedRunner.java:883)
	at com.carrotsearch.randomizedtesting.RandomizedRunner$7.evaluate(RandomizedRunner.java:894)
	at org.apache.lucene.tests.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
	at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
	at org.apache.lucene.tests.util.TestRuleStoreClassName$1.evaluate(TestRuleStoreClassName.java:38)
	at com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:40)
	at com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:40)
	at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
	at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
	at org.apache.lucene.tests.util.TestRuleAssertionsRequired$1.evaluate(TestRuleAssertionsRequired.java:53)
	at org.apache.lucene.tests.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
	at org.apache.lucene.tests.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:44)
	at org.apache.lucene.tests.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:60)
	at org.apache.lucene.tests.util.TestRuleIgnoreTestSuites$1.evaluate(TestRuleIgnoreTestSuites.java:47)
	at org.junit.rules.RunRules.evaluate(RunRules.java:20)
	at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
	at com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:368)
	at java.base/java.lang.Thread.run(Thread.java:1623)

2023-06-27 10:15:05,347 TEST-WildflyIT.testRestClient-seed#[B3296C2D4B70ACF8] ERROR Unable to locate appender "console" for logger config "root"
2023-06-27 10:15:05,348 TEST-WildflyIT.testRestClient-seed#[B3296C2D4B70ACF8] ERROR Unable to locate appender "header_warning" for logger config "org.opensearch.deprecation"

It seems like it was never properly configured, do you think we could add to qa/wildfly/src/main/resources/log4j2.properties the header_warning appender:

appender.header_warning.type = HeaderWarningAppender
appender.header_warning.name = header_warning

logger.deprecation.name = org.opensearch.deprecation
logger.deprecation.level = deprecation
logger.deprecation.appenderRef.deprecation_rolling.ref = deprecation_rolling
logger.deprecation.appenderRef.header_warning.ref = header_warning
logger.deprecation.additivity = false

I am fine doing it afterwards, non issue

@reta reta merged commit 246b922 into opensearch-project:main Jun 27, 2023
10 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-8209-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 246b922fc1a15985254d38222fc6c62570f16cf3
# Push it to GitHub
git push --set-upstream origin backport/backport-8209-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-8209-to-2.x.

@reta
Copy link
Collaborator

reta commented Jun 27, 2023

@Xtansia needs manual backport sadly :(

sarthakaggarwal97 pushed a commit to sarthakaggarwal97/OpenSearch that referenced this pull request Jun 27, 2023
… /qa/wildfly (opensearch-project#8209)

Signed-off-by: Thomas Farr <tsfarr@amazon.com>
@Xtansia Xtansia deleted the update/resteasy branch June 27, 2023 20:51
Xtansia added a commit to Xtansia/OpenSearch that referenced this pull request Jun 27, 2023
… /qa/wildfly (opensearch-project#8209)

Signed-off-by: Thomas Farr <tsfarr@amazon.com>
(cherry picked from commit 246b922)
Xtansia added a commit to Xtansia/OpenSearch that referenced this pull request Jun 27, 2023
… /qa/wildfly (opensearch-project#8209)

Signed-off-by: Thomas Farr <tsfarr@amazon.com>
(cherry picked from commit 246b922)
Xtansia added a commit to Xtansia/OpenSearch that referenced this pull request Jun 27, 2023
… /qa/wildfly (opensearch-project#8209)

Signed-off-by: Thomas Farr <tsfarr@amazon.com>
(cherry picked from commit 246b922)
Xtansia added a commit to Xtansia/OpenSearch that referenced this pull request Jun 27, 2023
… /qa/wildfly (opensearch-project#8209)

Signed-off-by: Thomas Farr <tsfarr@amazon.com>
(cherry picked from commit 246b922)
kotwanikunal pushed a commit that referenced this pull request Jun 27, 2023
… /qa/wildfly (#8209) (#8300)

Signed-off-by: Thomas Farr <tsfarr@amazon.com>
(cherry picked from commit 246b922)
sudarshan-baliga pushed a commit to Gaurav614/OpenSearch that referenced this pull request Jun 29, 2023
… /qa/wildfly (opensearch-project#8209)

Signed-off-by: Thomas Farr <tsfarr@amazon.com>
baba-devv pushed a commit to baba-devv/OpenSearch that referenced this pull request Jul 29, 2023
… /qa/wildfly (opensearch-project#8209)

Signed-off-by: Thomas Farr <tsfarr@amazon.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
… /qa/wildfly (opensearch-project#8209)

Signed-off-by: Thomas Farr <tsfarr@amazon.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants