Moving get snapshot requests to listener based async calls #8377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: INDRAJIT BANERJEE <indrajohn7@gmail.com>
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #8377 +/- ##
============================================
- Coverage 71.06% 70.99% -0.08%
+ Complexity 57314 57288 -26
============================================
Files 4766 4765 -1
Lines 270453 270485 +32
Branches 39555 39555
============================================
- Hits 192197 192028 -169
- Misses 62045 62309 +264
+ Partials 16211 16148 -63
|
indrajohn7
requested review from
reta,
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
gbbafna,
setiah,
kartg,
kotwanikunal,
mch2,
nknize,
owaiskazi19,
Rishikesh1159,
ryanbogan,
saratvemulapalli,
shwetathareja,
dreamer-89,
tlfeng,
VachaShah,
dbwiddis and
sachinpkale
as code owners
|
Porting the comment from old PR here
@indrajohn7 This is because SNAPSHOT threadpool can scale up to only 5 threads where as GENERIC threadpool can scale upto 512 depending on no. of cores. |
server/src/test/java/org/opensearch/snapshots/SnapshotResiliencyTests.java
Show resolved
Hide resolved
Signed-off-by: INDRAJIT BANERJEE <indrajohn7@gmail.com>
server/src/test/java/org/opensearch/snapshots/SnapshotResiliencyTests.java
Show resolved
Hide resolved
Signed-off-by: Indrajit Banerjee <banerind@amazon.com>
Signed-off-by: Indrajit Banerjee <banerind@amazon.com>
|
Compatibility status: |
Gradle Check (Jenkins) Run Completed with:
|
server/src/test/java/org/opensearch/snapshots/SnapshotResiliencyTests.java
Outdated
Show resolved
Hide resolved
server/src/test/java/org/opensearch/snapshots/SnapshotResiliencyTests.java
Outdated
Show resolved
Hide resolved
server/src/test/java/org/opensearch/snapshots/SnapshotResiliencyTests.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Indrajit Banerjee <banerind@amazon.com>
|
Compatibility status: |
Gradle Check (Jenkins) Run Completed with:
|
server/src/test/java/org/opensearch/snapshots/SnapshotResiliencyTests.java
Show resolved
Hide resolved
Signed-off-by: Indrajit Banerjee <banerind@amazon.com>
shwetathareja
approved these changes
Aug 7, 2023
|
Compatibility status: |
Gradle Check (Jenkins) Run Completed with:
|
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-8377-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 2de1c24e8947e15d6faebd448517e9d524a1b788
# Push it to GitHub
git push --set-upstream origin backport/backport-8377-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.xThen, create a pull request where the |
6 tasks
kaushalmahi12
pushed a commit
to kaushalmahi12/OpenSearch
that referenced
this pull request
Sep 12, 2023
…h-project#8377) * Moving get snapshot requests to listener based async calls --------- Signed-off-by: INDRAJIT BANERJEE <indrajohn7@gmail.com> Signed-off-by: Indrajit Banerjee <banerind@amazon.com> Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
brusic
pushed a commit
to brusic/OpenSearch
that referenced
this pull request
Sep 25, 2023
…h-project#8377) * Moving get snapshot requests to listener based async calls --------- Signed-off-by: INDRAJIT BANERJEE <indrajohn7@gmail.com> Signed-off-by: Indrajit Banerjee <banerind@amazon.com> Signed-off-by: Ivan Brusic <ivan.brusic@flocksafety.com>
shiv0408
pushed a commit
to Gaurav614/OpenSearch
that referenced
this pull request
Apr 25, 2024
…h-project#8377) * Moving get snapshot requests to listener based async calls --------- Signed-off-by: INDRAJIT BANERJEE <indrajohn7@gmail.com> Signed-off-by: Indrajit Banerjee <banerind@amazon.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is to discuss the optimisation changes for listener based get_snapshot calls handled through async based model.
The TransportGetSnapshotAction shouldn't block wait on the
repositoriesService.getRepositoryData and move to async processing
Due to this, pending tasks were stuck for hours on master.
Reproduction:
With Fix:
Use of
SNAPSHOTThreadpoolSNAPSHOTthreadpool in stead ofGENERICthreadpool for the get_snapshot calls.Observations:
*get_snapshot response:
SNAPSHOTthreadpools are lesser compared to the generic one.SNAPSHOTthreadpool would not be recommended here as it may block the create snapshot calls as well if its shared across get_snapshot requests.Related Issues
Resolves #1788
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.