-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 2.x] Support transport action names when registering NamedRoutes (#7957) #8459
Merged
owaiskazi19
merged 5 commits into
opensearch-project:2.x
from
DarshitChanpura:backport/backport-7957-to-2.x
Jul 9, 2023
Merged
[Backport 2.x] Support transport action names when registering NamedRoutes (#7957) #8459
owaiskazi19
merged 5 commits into
opensearch-project:2.x
from
DarshitChanpura:backport/backport-7957-to-2.x
Jul 9, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ch-project#7957) * Adds ability to register legacy action names along with route Signed-off-by: Darshit Chanpura <dchanp@amazon.com> Signed-off-by: Darshit Chanpura <35282393+DarshitChanpura@users.noreply.github.com> (cherry picked from commit 50d8006)
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## 2.x #8459 +/- ##
============================================
+ Coverage 70.57% 70.67% +0.10%
- Complexity 57094 57106 +12
============================================
Files 4746 4745 -1
Lines 270463 270481 +18
Branches 39931 39939 +8
============================================
+ Hits 190871 191171 +300
+ Misses 63231 62925 -306
- Partials 16361 16385 +24
|
Gradle Check (Jenkins) Run Completed with:
|
peternied
approved these changes
Jul 6, 2023
owaiskazi19
approved these changes
Jul 6, 2023
@DarshitChanpura can you resolve the conflicts? |
3 tasks
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
DarshitChanpura
added a commit
to DarshitChanpura/OpenSearch
that referenced
this pull request
Jul 11, 2023
…g NamedRoutes (opensearch-project#7957) (opensearch-project#8459)" This reverts commit cd82f4c.
DarshitChanpura
added a commit
to DarshitChanpura/OpenSearch
that referenced
this pull request
Jul 11, 2023
…g NamedRoutes (opensearch-project#7957) (opensearch-project#8459)" This reverts commit cd82f4c. Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
DarshitChanpura
added a commit
to DarshitChanpura/OpenSearch
that referenced
this pull request
Jul 12, 2023
…g NamedRoutes (opensearch-project#7957) (opensearch-project#8459)" This reverts commit cd82f4c.
DarshitChanpura
added a commit
to DarshitChanpura/OpenSearch
that referenced
this pull request
Jul 12, 2023
…g NamedRoutes (opensearch-project#7957) (opensearch-project#8459)" This reverts commit cd82f4c. Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
nknize
pushed a commit
that referenced
this pull request
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backports #7957
Companion PR: opensearch-project/security#2956
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.