Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Support transport action names when registering NamedRoutes (#7957) #8459

Conversation

DarshitChanpura
Copy link
Member

@DarshitChanpura DarshitChanpura commented Jul 5, 2023

Description

Backports #7957

Companion PR: opensearch-project/security#2956

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

DarshitChanpura and others added 2 commits July 5, 2023 18:52
…ch-project#7957)

* Adds ability to register legacy action names along with route

Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
Signed-off-by: Darshit Chanpura <35282393+DarshitChanpura@users.noreply.github.com>
(cherry picked from commit 50d8006)
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2023

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.search.SearchWeightedRoutingIT.testStrictWeightedRoutingWithCustomString

@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2023

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.remotestore.SegmentReplicationUsingRemoteStoreIT.testPrimaryStopped_ReplicaPromoted
      1 org.opensearch.action.admin.cluster.node.tasks.ResourceAwareTasksTests.testBasicTaskResourceTracking

@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Merging #8459 (4588904) into 2.x (610dc65) will increase coverage by 0.10%.
The diff coverage is 93.15%.

❗ Current head 4588904 differs from pull request most recent head 015c9e9. Consider uploading reports for the commit 015c9e9 to get more accurate results

@@             Coverage Diff              @@
##                2.x    #8459      +/-   ##
============================================
+ Coverage     70.57%   70.67%   +0.10%     
- Complexity    57094    57106      +12     
============================================
  Files          4746     4745       -1     
  Lines        270463   270481      +18     
  Branches      39931    39939       +8     
============================================
+ Hits         190871   191171     +300     
+ Misses        63231    62925     -306     
- Partials      16361    16385      +24     
Impacted Files Coverage Δ
...extensions/rest/RestInitializeExtensionAction.java 65.43% <0.00%> (ø)
...rch/extensions/rest/RestSendToExtensionAction.java 42.50% <92.85%> (-4.17%) ⬇️
.../main/java/org/opensearch/action/ActionModule.java 95.36% <93.75%> (+0.32%) ⬆️
.../src/main/java/org/opensearch/rest/NamedRoute.java 95.34% <95.23%> (-4.66%) ⬇️

... and 451 files with indirect coverage changes

@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2023

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.search.SearchWeightedRoutingIT.testStrictWeightedRoutingWithCustomString
      1 org.opensearch.remotestore.SegmentReplicationUsingRemoteStoreIT.testReplicaHasDiffFilesThanPrimary

@owaiskazi19
Copy link
Member

@DarshitChanpura can you resolve the conflicts?

@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2023

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.snapshots.CloneSnapshotIT.testCloneAfterRepoShallowSettingDisabled

@github-actions
Copy link
Contributor

github-actions bot commented Jul 9, 2023

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.search.SearchWeightedRoutingIT.testStrictWeightedRoutingWithCustomString

@owaiskazi19 owaiskazi19 merged commit cd82f4c into opensearch-project:2.x Jul 9, 2023
6 checks passed
DarshitChanpura added a commit to DarshitChanpura/OpenSearch that referenced this pull request Jul 11, 2023
DarshitChanpura added a commit to DarshitChanpura/OpenSearch that referenced this pull request Jul 11, 2023
…g NamedRoutes (opensearch-project#7957) (opensearch-project#8459)"

This reverts commit cd82f4c.

Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
DarshitChanpura added a commit to DarshitChanpura/OpenSearch that referenced this pull request Jul 12, 2023
DarshitChanpura added a commit to DarshitChanpura/OpenSearch that referenced this pull request Jul 12, 2023
…g NamedRoutes (opensearch-project#7957) (opensearch-project#8459)"

This reverts commit cd82f4c.

Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
nknize pushed a commit that referenced this pull request Jul 12, 2023
…g NamedRoutes (#7957) (#8459)" (#8651)

This reverts commit cd82f4c.

Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v2.9.0 'Issues and PRs related to version v2.9.0'
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants