Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating default compression level for ZStandard Codecs #8471

Conversation

sarthakaggarwal97
Copy link
Contributor

@sarthakaggarwal97 sarthakaggarwal97 commented Jul 6, 2023

Description

This PR is to update the default ZStandard compression level to 3 based on the performance gains we are observing over here at #7555

Related Issues

Resolves:
Optimization mentioned at #7555

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@sarthakaggarwal97 sarthakaggarwal97 force-pushed the change-zstd-def-compression-level branch from 47c99eb to 904a7b1 Compare July 6, 2023 06:34
@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2023

Gradle Check (Jenkins) Run Completed with:

@sarthakaggarwal97 sarthakaggarwal97 changed the title default compression level change Updating default compression level for ZSTD Jul 6, 2023
@sarthakaggarwal97 sarthakaggarwal97 changed the title Updating default compression level for ZSTD Updating default compression level for ZStandard Codecs Jul 6, 2023
@sarthakaggarwal97 sarthakaggarwal97 marked this pull request as ready for review July 6, 2023 06:47
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
@sarthakaggarwal97 sarthakaggarwal97 force-pushed the change-zstd-def-compression-level branch from 904a7b1 to 6dde2cc Compare July 6, 2023 06:55
@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2023

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.cluster.allocation.AwarenessAllocationIT.testThreeZoneOneReplicaWithForceZoneValueAndLoadAwareness
      1 org.opensearch.action.admin.cluster.node.tasks.ResourceAwareTasksTests.testBasicTaskResourceTracking

@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Merging #8471 (6dde2cc) into main (8bebf5b) will increase coverage by 0.09%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #8471      +/-   ##
============================================
+ Coverage     70.84%   70.94%   +0.09%     
- Complexity    56935    56954      +19     
============================================
  Files          4758     4758              
  Lines        269219   269219              
  Branches      39407    39407              
============================================
+ Hits         190740   191007     +267     
+ Misses        62416    62126     -290     
- Partials      16063    16086      +23     
Impacted Files Coverage Δ
.../index/codec/customcodecs/Lucene95CustomCodec.java 76.92% <ø> (ø)

... and 451 files with indirect coverage changes

@shwetathareja shwetathareja merged commit eca5a6c into opensearch-project:main Jul 6, 2023
9 checks passed
@shwetathareja shwetathareja added the backport 2.x Backport to 2.x branch label Jul 6, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 6, 2023
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
(cherry picked from commit eca5a6c)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
sarthakaggarwal97 added a commit to sarthakaggarwal97/OpenSearch that referenced this pull request Jul 6, 2023
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
(cherry picked from commit eca5a6c)
shwetathareja pushed a commit that referenced this pull request Jul 6, 2023
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
(cherry picked from commit eca5a6c)
vikasvb90 pushed a commit to raghuvanshraj/OpenSearch that referenced this pull request Jul 12, 2023
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
raghuvanshraj pushed a commit to raghuvanshraj/OpenSearch that referenced this pull request Jul 12, 2023
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
buddharajusahil pushed a commit to buddharajusahil/OpenSearch that referenced this pull request Jul 18, 2023
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
Signed-off-by: sahil buddharaju <sahilbud@amazon.com>
baba-devv pushed a commit to baba-devv/OpenSearch that referenced this pull request Jul 29, 2023
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants