Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump schema validator from from 1.0.85 to 1.0.86 #8573

Merged
merged 5 commits into from Jul 10, 2023

Conversation

scrawfor99
Copy link
Contributor

Description

Manually bump schema validator since #8570 failed.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Stephen Crawford <steecraw@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: null ❌
  • URL: null
  • CommitID: e66d867
    Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
    Is the failure a flaky test unrelated to your change?

Signed-off-by: Stephen Crawford <steecraw@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: null ❌
  • URL: null
  • CommitID: cb27e28
    Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
    Is the failure a flaky test unrelated to your change?

Signed-off-by: Stephen Crawford <steecraw@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: null ❌
  • URL: null
  • CommitID: 2c587db
    Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
    Is the failure a flaky test unrelated to your change?

@scrawfor99
Copy link
Contributor Author

Failure seems to be a jenkins issue not related to this change. Also happening here: https://github.com/opensearch-project/OpenSearch/actions/runs/5508946707/jobs/10040944804?pr=8576

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.indices.replication.SegmentReplicationIT.testScrollCreatedOnReplica

Signed-off-by: Stephen Crawford <steecraw@amazon.com>
@codecov
Copy link

codecov bot commented Jul 10, 2023

Codecov Report

Merging #8573 (9b681a3) into main (418ab51) will increase coverage by 0.05%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #8573      +/-   ##
============================================
+ Coverage     70.85%   70.91%   +0.05%     
- Complexity    56948    56967      +19     
============================================
  Files          4758     4758              
  Lines        269382   269382              
  Branches      39414    39414              
============================================
+ Hits         190877   191031     +154     
+ Misses        62429    62297     -132     
+ Partials      16076    16054      -22     
Impacted Files Coverage Δ
.../java/org/opensearch/identity/IdentityService.java 100.00% <ø> (ø)

... and 456 files with indirect coverage changes

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.remotestore.RemoteStoreIT.testStaleCommitDeletionWithInvokeFlush
      1 org.opensearch.indices.replication.SegmentReplicationIT.testDropPrimaryDuringReplication

Signed-off-by: Stephen Crawford <65832608+scrawfor99@users.noreply.github.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.remotestore.SegmentReplicationRemoteStoreIT.testScrollWithConcurrentIndexAndSearch
      1 org.opensearch.indices.replication.SegmentReplicationIT.testScrollCreatedOnReplica
      1 org.opensearch.cluster.allocation.AwarenessAllocationIT.testThreeZoneOneReplicaWithForceZoneValueAndLoadAwareness

@@ -40,6 +40,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
- Bump `org.bouncycastle:bcprov-jdk15on` to `org.bouncycastle:bcprov-jdk15to18` version 1.75 ([#8247](https://github.com/opensearch-project/OpenSearch/pull/8247))
- Bump `org.bouncycastle:bcmail-jdk15on` to `org.bouncycastle:bcmail-jdk15to18` version 1.75 ([#8247](https://github.com/opensearch-project/OpenSearch/pull/8247))
- Bump `org.bouncycastle:bcpkix-jdk15on` to `org.bouncycastle:bcpkix-jdk15to18` version 1.75 ([#8247](https://github.com/opensearch-project/OpenSearch/pull/8247))
- Bump `com.networknt:json-schema-validator` from 1.0.85 to 1.0.86 ([#8573](https://github.com/opensearch-project/OpenSearch/pull/8573))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Generally we add the changelog at the last

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I merged too early. This change needs to be in Unreleased 2.x section since we will backport it to 2.x @scrawfor99 can you take care of this? Thanks

@owaiskazi19 owaiskazi19 merged commit 71f8073 into opensearch-project:main Jul 10, 2023
7 checks passed
@owaiskazi19 owaiskazi19 added the backport 2.x Backport to 2.x branch label Jul 10, 2023
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-8573-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 71f807329a92f05012924348de0b5d8884023bd0
# Push it to GitHub
git push --set-upstream origin backport/backport-8573-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-8573-to-2.x.

reta pushed a commit that referenced this pull request Jul 11, 2023
* Manual backports

Signed-off-by: Stephen Crawford <steecraw@amazon.com>

* remove blank lines

Signed-off-by: Stephen Crawford <steecraw@amazon.com>

* fix numbers

Signed-off-by: Stephen Crawford <steecraw@amazon.com>

* fix numbering

Signed-off-by: Stephen Crawford <steecraw@amazon.com>

---------

Signed-off-by: Stephen Crawford <steecraw@amazon.com>
vikasvb90 pushed a commit to raghuvanshraj/OpenSearch that referenced this pull request Jul 12, 2023
…8573)

* Bump schema validator

Signed-off-by: Stephen Crawford <steecraw@amazon.com>

* Update changelog

Signed-off-by: Stephen Crawford <steecraw@amazon.com>

* Manually trigger retry

Signed-off-by: Stephen Crawford <steecraw@amazon.com>

* Make trivial change to trigger rerun

Signed-off-by: Stephen Crawford <steecraw@amazon.com>

---------

Signed-off-by: Stephen Crawford <steecraw@amazon.com>
Signed-off-by: Stephen Crawford <65832608+scrawfor99@users.noreply.github.com>
raghuvanshraj pushed a commit to raghuvanshraj/OpenSearch that referenced this pull request Jul 12, 2023
…8573)

* Bump schema validator

Signed-off-by: Stephen Crawford <steecraw@amazon.com>

* Update changelog

Signed-off-by: Stephen Crawford <steecraw@amazon.com>

* Manually trigger retry

Signed-off-by: Stephen Crawford <steecraw@amazon.com>

* Make trivial change to trigger rerun

Signed-off-by: Stephen Crawford <steecraw@amazon.com>

---------

Signed-off-by: Stephen Crawford <steecraw@amazon.com>
Signed-off-by: Stephen Crawford <65832608+scrawfor99@users.noreply.github.com>
dzane17 pushed a commit to dzane17/OpenSearch that referenced this pull request Jul 12, 2023
…8573)

* Bump schema validator

Signed-off-by: Stephen Crawford <steecraw@amazon.com>

* Update changelog

Signed-off-by: Stephen Crawford <steecraw@amazon.com>

* Manually trigger retry

Signed-off-by: Stephen Crawford <steecraw@amazon.com>

* Make trivial change to trigger rerun

Signed-off-by: Stephen Crawford <steecraw@amazon.com>

---------

Signed-off-by: Stephen Crawford <steecraw@amazon.com>
Signed-off-by: Stephen Crawford <65832608+scrawfor99@users.noreply.github.com>
buddharajusahil pushed a commit to buddharajusahil/OpenSearch that referenced this pull request Jul 18, 2023
…8573)

* Bump schema validator

Signed-off-by: Stephen Crawford <steecraw@amazon.com>

* Update changelog

Signed-off-by: Stephen Crawford <steecraw@amazon.com>

* Manually trigger retry

Signed-off-by: Stephen Crawford <steecraw@amazon.com>

* Make trivial change to trigger rerun

Signed-off-by: Stephen Crawford <steecraw@amazon.com>

---------

Signed-off-by: Stephen Crawford <steecraw@amazon.com>
Signed-off-by: Stephen Crawford <65832608+scrawfor99@users.noreply.github.com>
Signed-off-by: sahil buddharaju <sahilbud@amazon.com>
baba-devv pushed a commit to baba-devv/OpenSearch that referenced this pull request Jul 29, 2023
…8573)

* Bump schema validator

Signed-off-by: Stephen Crawford <steecraw@amazon.com>

* Update changelog

Signed-off-by: Stephen Crawford <steecraw@amazon.com>

* Manually trigger retry

Signed-off-by: Stephen Crawford <steecraw@amazon.com>

* Make trivial change to trigger rerun

Signed-off-by: Stephen Crawford <steecraw@amazon.com>

---------

Signed-off-by: Stephen Crawford <steecraw@amazon.com>
Signed-off-by: Stephen Crawford <65832608+scrawfor99@users.noreply.github.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
…8573)

* Bump schema validator

Signed-off-by: Stephen Crawford <steecraw@amazon.com>

* Update changelog

Signed-off-by: Stephen Crawford <steecraw@amazon.com>

* Manually trigger retry

Signed-off-by: Stephen Crawford <steecraw@amazon.com>

* Make trivial change to trigger rerun

Signed-off-by: Stephen Crawford <steecraw@amazon.com>

---------

Signed-off-by: Stephen Crawford <steecraw@amazon.com>
Signed-off-by: Stephen Crawford <65832608+scrawfor99@users.noreply.github.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants