[Backport] [2.x] replace with getField (#7855) #8600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gradle Check (Jenkins) Run Completed with:
|
mingshl
requested review from
reta,
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
gbbafna,
setiah,
kartg,
kotwanikunal,
mch2,
nknize,
owaiskazi19,
Rishikesh1159,
ryanbogan,
saratvemulapalli,
shwetathareja,
dreamer-89,
tlfeng,
VachaShah,
dbwiddis and
sachinpkale
as code owners
reta
approved these changes
Jul 10, 2023
|
Builds are failing because of #8591 |
|
#8591 get merged, need some help rerunning the gradle check. |
* replace with getField Signed-off-by: Shinsuke Sugaya <shinsuke@apache.org> * Update server/src/main/java/org/opensearch/index/mapper/FlatObjectFieldMapper.java Co-authored-by: Andriy Redko <drreta@gmail.com> Signed-off-by: Shinsuke Sugaya <shinsuke.sugaya@gmail.com> * add import Signed-off-by: Shinsuke Sugaya <shinsuke@apache.org> * add PR to CHANGELOG Signed-off-by: Shinsuke Sugaya <shinsuke@apache.org> * move SortedSetDocValuesField addition for field type Signed-off-by: Shinsuke Sugaya <shinsuke@apache.org> * remove a test case for flat-object field Signed-off-by: Shinsuke Sugaya <shinsuke@apache.org> * remove getField Signed-off-by: Mingshi Liu <mingshl@amazon.com> * remove unused import Signed-off-by: Shinsuke Sugaya <shinsuke@apache.org> --------- Signed-off-by: Shinsuke Sugaya <shinsuke@apache.org> Signed-off-by: Shinsuke Sugaya <shinsuke.sugaya@gmail.com> Signed-off-by: Mingshi Liu <mingshl@amazon.com> Co-authored-by: Andriy Redko <drreta@gmail.com> Co-authored-by: Mingshi Liu <mingshl@amazon.com> (cherry picked from commit 828730f)
mingshl
force-pushed
the
backport/backport-7855-to-2.x
branch
from
f87c27c
to
2ca2596
Compare
Gradle Check (Jenkins) Run Completed with:
|
|
Thanks @reta ! rebased and ready for merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shinsuke Sugaya shinsuke@apache.org
Signed-off-by: Shinsuke Sugaya shinsuke@apache.org
Signed-off-by: Shinsuke Sugaya shinsuke.sugaya@gmail.com
Signed-off-by: Mingshi Liu mingshl@amazon.com
Co-authored-by: Andriy Redko drreta@gmail.com
Co-authored-by: Mingshi Liu mingshl@amazon.com
(cherry picked from commit 828730f)
Description
[Backport] [2.x] replace with getField (#7855)
Related Issues
Resolves #7835
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.