Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Remove] Deprecated Fractional ByteSizeValue support #9005

Merged
merged 3 commits into from Jul 31, 2023

Conversation

nknize
Copy link
Collaborator

@nknize nknize commented Jul 31, 2023

This PR removes the deprecation warning for fractional bytes size values and, instead, throws an OpenSearchParseException if a user passes in a fraction byte value (e.g., 5.2b). This leniency was deprecated a long time ago in Legacy 6.2 so the removal should come as no surprise to users.

This commit removes the deprecation warning for fractional bytes size
values. This leniency was deprecated a long time ago in Legacy 6.2. The
removal should come as no surprise to users.

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@nknize nknize merged commit 0b1f875 into opensearch-project:main Jul 31, 2023
6 of 7 checks passed
@nknize nknize added the backport 2.x Backport to 2.x branch label Jul 31, 2023
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-9005-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 0b1f875d34c7d723afd41396234f8f2003c6be2c
# Push it to GitHub
git push --set-upstream origin backport/backport-9005-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-9005-to-2.x.

nknize added a commit to nknize/OpenSearch that referenced this pull request Jul 31, 2023
…ect#9005)

This commit removes the deprecation warning for fractional bytes size
values and, instead, throws an OpenSearchParseException if a user
passes in a fraction byte value (e.g., 5.2b).. This leniency was
deprecated a long time ago in Legacy 6.2 so the removal should come
as no surprise to users.

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
(cherry picked from commit 0b1f875)
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

nknize added a commit that referenced this pull request Jul 31, 2023
…9005) (#9007)

This commit removes the deprecation warning for fractional bytes size
values and, instead, throws an OpenSearchParseException if a user
passes in a fraction byte value (e.g., 5.2b).. This leniency was
deprecated a long time ago in Legacy 6.2 so the removal should come
as no surprise to users.

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
(cherry picked from commit 0b1f875)
kaushalmahi12 pushed a commit to kaushalmahi12/OpenSearch that referenced this pull request Sep 12, 2023
…ect#9005)

This commit removes the deprecation warning for fractional bytes size
values and, instead, throws an OpenSearchParseException if a user
passes in a fraction byte value (e.g., 5.2b).. This leniency was
deprecated a long time ago in Legacy 6.2 so the removal should come
as no surprise to users.

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
brusic pushed a commit to brusic/OpenSearch that referenced this pull request Sep 25, 2023
…ect#9005)

This commit removes the deprecation warning for fractional bytes size
values and, instead, throws an OpenSearchParseException if a user
passes in a fraction byte value (e.g., 5.2b).. This leniency was
deprecated a long time ago in Legacy 6.2 so the removal should come
as no surprise to users.

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Signed-off-by: Ivan Brusic <ivan.brusic@flocksafety.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
…ect#9005)

This commit removes the deprecation warning for fractional bytes size
values and, instead, throws an OpenSearchParseException if a user
passes in a fraction byte value (e.g., 5.2b).. This leniency was
deprecated a long time ago in Legacy 6.2 so the removal should come
as no surprise to users.

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch enhancement Enhancement or improvement to existing feature or request v2.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants