Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Allow test clusters to run with TLS #8900 #9444

Merged
merged 4 commits into from
Aug 24, 2023

Conversation

scrawfor99
Copy link
Contributor

Description

Manually backport "Allow test clusters to run with TLS" #8900

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Stephen Crawford <steecraw@amazon.com>
Signed-off-by: Stephen Crawford <steecraw@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Signed-off-by: Stephen Crawford <steecraw@amazon.com>
@opensearch-trigger-bot
Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change 98946b9

Incompatible components

Incompatible components: [https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/performance-analyzer.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer-rca.git]

@opensearch-trigger-bot
Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change 98946b9

Incompatible components

Incompatible components: [https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/performance-analyzer.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer-rca.git]

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Merging #9444 (8d72e71) into 2.x (6d94fd2) will increase coverage by 0.26%.
Report is 3 commits behind head on 2.x.
The diff coverage is 25.92%.

@@             Coverage Diff              @@
##                2.x    #9444      +/-   ##
============================================
+ Coverage     70.67%   70.93%   +0.26%     
- Complexity    57545    57668     +123     
============================================
  Files          4766     4766              
  Lines        272175   272214      +39     
  Branches      40112    40116       +4     
============================================
+ Hits         192360   193104     +744     
+ Misses        63326    62621     -705     
  Partials      16489    16489              
Files Changed Coverage Δ
...rg/opensearch/gradle/http/WaitForHttpResource.java 29.47% <0.00%> (-0.64%) ⬇️
...nsearch/gradle/testclusters/OpenSearchCluster.java 0.00% <0.00%> (ø)
...opensearch/gradle/testclusters/OpenSearchNode.java 0.00% <0.00%> (ø)
.../gradle/testclusters/TestClusterConfiguration.java 0.00% <ø> (ø)
...java/org/opensearch/index/shard/StoreRecovery.java 56.80% <14.28%> (-0.45%) ⬇️
...rc/main/java/org/opensearch/index/store/Store.java 80.94% <100.00%> (+0.10%) ⬆️
.../org/opensearch/index/translog/TranslogHeader.java 79.01% <100.00%> (-1.76%) ⬇️

... and 463 files with indirect coverage changes

@opensearch-trigger-bot
Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change c7fcd71

Incompatible components

Incompatible components: [https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/performance-analyzer.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/ml-commons.git]

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Signed-off-by: Stephen Crawford <65832608+scrawfor99@users.noreply.github.com>
@scrawfor99
Copy link
Contributor Author

Can we please merge this?

@github-actions
Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change 8d72e71

Incompatible components

Incompatible components: [https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/performance-analyzer.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/security-analytics.git]

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@peternied peternied changed the title Manually backport "Allow test clusters to run with TLS" #8900 [Backport 2.x] Allow test clusters to run with TLS #8900 Aug 24, 2023
@peternied peternied merged commit 3d9378c into opensearch-project:2.x Aug 24, 2023
12 of 13 checks passed
@scrawfor99
Copy link
Contributor Author

@reta can I get a 2.9 and 2.8 label on this? It is required for testing support. I need this in 2.8, 2.9, 2.x, main.

@peternied
Copy link
Member

I get a 2.9 and 2.8 label on this

@scrawfor99 Why is this needed on those branches? AFAIK the testing framework is from the version of the tools, so if we are running BWC tests on our 2.X branch, it would use the 2.X version of the tools to start a 2.X-1 & 2.X versions of the cluster

@reta
Copy link
Collaborator

reta commented Aug 24, 2023

@scrawfor99 have the same question @peternied :)

@peternied
Copy link
Member

Lets hold off on further backports until we know we need them. If it is working as I'd expect we should be able to run 1.3->2.10, 2.9->2.10, and 2.10->3.0 BCW test with this change in the 2.10 and 3.0 branches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants