Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to use trace propagated from client #9506

Merged
merged 17 commits into from
Aug 28, 2023

Conversation

Gaganjuneja
Copy link
Contributor

@Gaganjuneja Gaganjuneja commented Aug 23, 2023

Description

Add support to use trace propagated from client.

Related Issues

Resolves #9465

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Merging #9506 (8afe6f4) into main (5bbac14) will decrease coverage by 0.10%.
Report is 6 commits behind head on main.
The diff coverage is 63.52%.

@@             Coverage Diff              @@
##               main    #9506      +/-   ##
============================================
- Coverage     71.14%   71.04%   -0.10%     
+ Complexity    57486    57460      -26     
============================================
  Files          4778     4780       +2     
  Lines        271039   271126      +87     
  Branches      39585    39588       +3     
============================================
- Hits         192818   192635     -183     
- Misses        61973    62293     +320     
+ Partials      16248    16198      -50     
Files Changed Coverage Δ
.../opensearch/telemetry/tracing/noop/NoopTracer.java 57.14% <0.00%> (-9.53%) ⬇️
.../org/opensearch/repositories/FilterRepository.java 6.00% <0.00%> (-0.25%) ⬇️
...n/java/org/opensearch/repositories/Repository.java 28.57% <ø> (ø)
...ch/repositories/blobstore/BlobStoreRepository.java 61.07% <41.66%> (-0.95%) ⬇️
...earch/index/store/RemoteSegmentStoreDirectory.java 88.97% <42.85%> (+2.41%) ⬆️
...rg/opensearch/telemetry/tracing/WrappedTracer.java 78.57% <50.00%> (-6.05%) ⬇️
...main/java/org/opensearch/common/StreamLimiter.java 61.53% <61.53%> (ø)
...x/snapshots/blobstore/RateLimitingInputStream.java 70.00% <66.66%> (+10.00%) ⬆️
...elemetry/tracing/OTelTracingContextPropagator.java 73.33% <70.00%> (-1.67%) ⬇️
...va/org/opensearch/index/store/RemoteDirectory.java 79.59% <73.21%> (-9.05%) ⬇️
... and 4 more

... and 435 files with indirect coverage changes

@Gaganjuneja
Copy link
Contributor Author

@reta, Please take a look.

@Gaganjuneja
Copy link
Contributor Author

@reta Please take a look whenever you get time. Thanks!

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@Gaganjuneja
Copy link
Contributor Author

Gaganjuneja commented Aug 28, 2023

Known flaky test: #2502.

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@Gaganjuneja
Copy link
Contributor Author

Known flaky test: #9580.

@Gaganjuneja
Copy link
Contributor Author

Known flaky test: #2502.

Updated the correct one ;)

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@Gaganjuneja
Copy link
Contributor Author

Gaganjuneja commented Aug 28, 2023

@reta, please help with merging this PR. There are some other code changes which are having lower coverage, don't know why it is coming here.

@reta
Copy link
Collaborator

reta commented Aug 28, 2023

@reta, please help with merging this PR. There are some other code changes which are having lower coverage, don't know why it is coming here.

The codecov is non issue but the compatibility check is failing everywhere, let me bring this one up

@github-actions
Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change 8afe6f4

Incompatible components

Incompatible components: [https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/cross-cluster-replication.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git]

@reta reta merged commit f4106a4 into opensearch-project:main Aug 28, 2023
11 of 12 checks passed
@reta reta added the backport 2.x Backport to 2.x branch label Aug 28, 2023
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-9506-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 f4106a474c8503187b1d6bbe47a85a82f5243163
# Push it to GitHub
git push --set-upstream origin backport/backport-9506-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-9506-to-2.x.

@reta
Copy link
Collaborator

reta commented Aug 28, 2023

@Gaganjuneja hehe, surely 2.x needs manual backport ...

mch2 pushed a commit to mch2/OpenSearch that referenced this pull request Aug 28, 2023
)

* Add support to use trace propagated from client

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Add support to use trace propagated from client

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Refactor code

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Add support to use trace propagated from client

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Add support to use trace propagated from client

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Refactor code

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Refactor code

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Merged CHANGELOG

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Empty-Commit

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Empty-Commit

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Empty-Commit

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Empty-Commit

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Empty-Commit

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Empty-Commit

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

---------

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
Signed-off-by: Gagan Juneja <gagandeepjuneja@gmail.com>
Co-authored-by: Gagan Juneja <gjjuneja@amazon.com>
Gaganjuneja added a commit to Gaganjuneja/OpenSearch that referenced this pull request Aug 28, 2023
)

* Add support to use trace propagated from client

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Add support to use trace propagated from client

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Refactor code

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Add support to use trace propagated from client

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Add support to use trace propagated from client

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Refactor code

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Refactor code

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Merged CHANGELOG

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Empty-Commit

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Empty-Commit

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Empty-Commit

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Empty-Commit

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Empty-Commit

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Empty-Commit

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

---------

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
Signed-off-by: Gagan Juneja <gagandeepjuneja@gmail.com>
Co-authored-by: Gagan Juneja <gjjuneja@amazon.com>
sachinpkale pushed a commit to sachinpkale/OpenSearch that referenced this pull request Aug 29, 2023
)

* Add support to use trace propagated from client

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Add support to use trace propagated from client

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Refactor code

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Add support to use trace propagated from client

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Add support to use trace propagated from client

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Refactor code

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Refactor code

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Merged CHANGELOG

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Empty-Commit

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Empty-Commit

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Empty-Commit

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Empty-Commit

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Empty-Commit

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Empty-Commit

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

---------

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
Signed-off-by: Gagan Juneja <gagandeepjuneja@gmail.com>
Co-authored-by: Gagan Juneja <gjjuneja@amazon.com>
reta added a commit that referenced this pull request Aug 29, 2023
* Add support to use trace propagated from client



* Add support to use trace propagated from client



* Refactor code



* Add support to use trace propagated from client



* Add support to use trace propagated from client



* Refactor code



* Refactor code



* Merged CHANGELOG



* Empty-Commit



* Empty-Commit



* Empty-Commit



* Empty-Commit



* Empty-Commit



* Empty-Commit



---------

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
Signed-off-by: Gagan Juneja <gagandeepjuneja@gmail.com>
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Co-authored-by: Gagan Juneja <gjjuneja@amazon.com>
Co-authored-by: Andriy Redko <andriy.redko@aiven.io>
kaushalmahi12 pushed a commit to kaushalmahi12/OpenSearch that referenced this pull request Sep 12, 2023
)

* Add support to use trace propagated from client

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Add support to use trace propagated from client

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Refactor code

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Add support to use trace propagated from client

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Add support to use trace propagated from client

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Refactor code

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Refactor code

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Merged CHANGELOG

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Empty-Commit

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Empty-Commit

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Empty-Commit

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Empty-Commit

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Empty-Commit

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Empty-Commit

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

---------

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
Signed-off-by: Gagan Juneja <gagandeepjuneja@gmail.com>
Co-authored-by: Gagan Juneja <gjjuneja@amazon.com>
Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
brusic pushed a commit to brusic/OpenSearch that referenced this pull request Sep 25, 2023
)

* Add support to use trace propagated from client

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Add support to use trace propagated from client

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Refactor code

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Add support to use trace propagated from client

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Add support to use trace propagated from client

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Refactor code

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Refactor code

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Merged CHANGELOG

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Empty-Commit

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Empty-Commit

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Empty-Commit

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Empty-Commit

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Empty-Commit

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Empty-Commit

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

---------

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
Signed-off-by: Gagan Juneja <gagandeepjuneja@gmail.com>
Co-authored-by: Gagan Juneja <gjjuneja@amazon.com>
Signed-off-by: Ivan Brusic <ivan.brusic@flocksafety.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
)

* Add support to use trace propagated from client

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Add support to use trace propagated from client

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Refactor code

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Add support to use trace propagated from client

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Add support to use trace propagated from client

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Refactor code

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Refactor code

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Merged CHANGELOG

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Empty-Commit

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Empty-Commit

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Empty-Commit

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Empty-Commit

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Empty-Commit

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Empty-Commit

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

---------

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
Signed-off-by: Gagan Juneja <gagandeepjuneja@gmail.com>
Co-authored-by: Gagan Juneja <gjjuneja@amazon.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch backport-failed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Distributed Tracing] Add support to use trace propagated from client.
2 participants